From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.49]) by mx.groups.io with SMTP id smtpd.web10.12510.1662040911122654787 for ; Thu, 01 Sep 2022 07:01:52 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=iQp4qulq; spf=pass (domain: arm.com, ip: 40.107.7.49, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ROjjJtmF9KGhWLUz39szyMsdoHCkmwPA8K+uu/blkkBBRPK6yXYP3ETiPYQdg35c+qkh6LNh1p77rofuTNCdqevohc7sRRp2Zm1oAMI5K0iBJ1cswBPNlI933mwvSU5s75h5DwdDOVLP/Dh/mYdPppLpvxsaXJgf+o32KvEOWUerRVwDa44jdQC3zWrLusoDzxAMIy8p7UFMzH7VK+wMjI2IWgEn9z/bzQjQNtGy7RrPyDsXBap3Lbcsk9XLczG12V3QmryAK6grw4b9BB8Ybx8qpuJVFgtmxGenEFUWo0FYhNwxBuJ2yXDSxMUcBe6utWRY0ahhOMINHgyOb5yYFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BSTTnfGnyhPEnWeDS2iEnynjWOBZdyb2pSb6H9yvN34=; b=ijRsY52TaNDfOCqTiFMCp2IDg1aDh9xrYcVeKGWWqfJJq91FwP086mtBtSSTzKt+Pxp41vMEi6H4ze+ehY2JP3TvwzlrKoQU9qoTaLzIrLrMEXpZY3Qk9FxpfyIESBx7B62BBJF8NT5ZnNWOh7Kk67bw+geQIB3gCJaHxjFcKwBmTmVuLUmiKQXoFEU+OO4glFm1XGXfvXRJ6qOUsrPM7WENDQ84ZiLPykqwOmbBoxTSGfy8gvaf96GxPzCf34lqthxD2mXi/5p4PVU1fTkzRAu3YkJKoDGXlnIvHRyc4+v7h1gor3QoNsHLfCDeeJ9Qqhe8J8gtsVifvx4cOZoIhg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BSTTnfGnyhPEnWeDS2iEnynjWOBZdyb2pSb6H9yvN34=; b=iQp4qulqrSULgMNkIy2z88a+pNWWks1RtLtWa+X5+dY52N9BP+StCkkyF2MHt7YlfiNVftjZ39pE4dWe4fwfaXrqLltE+zHBgHh9ragHiRDxRvCNw//ZWk214s9u3KkjbxE3A0iXNpmz95XPVnZeYSly4XQij2J63vDzuaAbtlI= Received: from DB6P195CA0006.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::16) by DU0PR08MB7761.eurprd08.prod.outlook.com (2603:10a6:10:3bb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Thu, 1 Sep 2022 14:01:45 +0000 Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::4) by DB6P195CA0006.outlook.office365.com (2603:10a6:4:cb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 14:01:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 14:01:45 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Thu, 01 Sep 2022 14:01:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d593f999a6f211c3 X-CR-MTA-TID: 64aa7808 Received: from 464800c97a05.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6BD1F392-94BE-46F3-8ECB-1DAAAC25AA42.1; Thu, 01 Sep 2022 14:01:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 464800c97a05.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Sep 2022 14:01:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iTNL9U1AHpLwcR42NTmyx+cwAcM2b6CXsSIWZmrTPpQmUrBYF3RJJg40sAVpLWwB1iVyLwGihPdw130S9W117G4XSX2941+UmzZK0pD5ikdGEbK9dNRxgdjVYUREaTG05IXy45NpT8IbQ+imHA5FPjdJNlNXxxy/qycqZMpyQLEajIkMKdzhqyZVIYTnh7qavFIghGCweYavjm4LOuzN9d5E2gIahacDIPsyC9j2Us8bhrVKAOBEbdp++qznEu2Q0UMbIwbN01/EDwxMX1fznDdqyeVw7lC5iRiJgGsTrf1Wnmj60Yud5pOduOJ12ghDzGKu7dO3FHF10PKvC0vK0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BSTTnfGnyhPEnWeDS2iEnynjWOBZdyb2pSb6H9yvN34=; b=dLeUPgJ/2ljX/X5Etkg4YRB+Lpn7Af+yygNakZkCREDkBolk3Qe3jBxYWFEfCj6PdoH4N5g7IP9Ryf5M2YM8YIauHY1SFH+1FsppkbRDklba/4yRNjxgjhLga9ukkevCW/lShBJLgYLfX4E2HDaNnsUR5Fa3YbF4KL76N35htkZKuld+H2aws7L8jbagDL4tldoclbq8hL7gWe4ja0d0yWrX2Fm4zHHgvcDTVlJIAQFBlsUUokFiSAKI6OmaTYfXOtCNAJJfGvUQ0DmhVGkzS2G3N8bAHyG/sfzma4Wd/hcQoWhoEAa6emFjqh6iQ9AEfF8lO+BOws7hFPiYW6GLFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BSTTnfGnyhPEnWeDS2iEnynjWOBZdyb2pSb6H9yvN34=; b=iQp4qulqrSULgMNkIy2z88a+pNWWks1RtLtWa+X5+dY52N9BP+StCkkyF2MHt7YlfiNVftjZ39pE4dWe4fwfaXrqLltE+zHBgHh9ragHiRDxRvCNw//ZWk214s9u3KkjbxE3A0iXNpmz95XPVnZeYSly4XQij2J63vDzuaAbtlI= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by GV1PR08MB7364.eurprd08.prod.outlook.com (2603:10a6:150:23::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 14:01:36 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24%8]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 14:01:36 +0000 Message-ID: <551ff0ed-6d44-07a9-57c3-7eaf0da1d134@arm.com> Date: Thu, 1 Sep 2022 15:01:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation To: Jeff Brasen , devel@edk2.groups.io CC: pierre.gondois@arm.com, Alexei.Fedorov@arm.com, nd@arm.com References: <42a40dcf43d62ff985fd89bbcde47558344384bc.1661315727.git.jbrasen@nvidia.com> From: "Sami Mujawar" In-Reply-To: <42a40dcf43d62ff985fd89bbcde47558344384bc.1661315727.git.jbrasen@nvidia.com> X-ClientProxiedBy: LO2P265CA0490.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::15) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 94fdb08f-d5c8-4e93-a101-08da8c2281a1 X-MS-TrafficTypeDiagnostic: GV1PR08MB7364:EE_|DBAEUR03FT061:EE_|DU0PR08MB7761:EE_ X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5j2/LzGUNSUgS9RQjfmrJ63zO3FGHXdmF9iMGu5jVQQn+KkaAoMIhNZesfsSzOKJZnJsh5AiqXC7WLVxWw3h1FAfaW13XGGqzUFBCmmwPUii3nO6RP+NI/L8PVYNSOGJvQacU5nS927J+Qn11sT7gkHbdfa3VePCGmcOSrbZ/HPyKbWgJyifsU+bxSay9HKiup5auPpxOfcLy8p1R/v6L/p3dLeKj036N6RV0PpVZGXrb5sfe0TQFOVLofZUz51Lirq/WPuTYOb5EB9hDcYnq9jZZrrk7GD2s609tHv9GLUEVtGRdod1uJm7hnJ1E7V4Yl+VpvGJMaZuEs7hfCPC84ufp8bjA4HhB9TBDWH1Btt+3je6vKZ5GtAYQws5+oDXPPf067nwa1IJnvx36LY6sGO/nIsEBUiCojKDOjSD4HXI+hxxb1wDmQw1etPRKkh3OOPaylYMB8hKHAAhyWdt/85C0K1HYao2MSEOmXrUEdhDaacDvjtD72tCGj7EIBMCPeaFg2G3Qhg6OBGTKBe672Lunc83gHm14PddMjn/d65MXSjikhrAd821sV7WLWCEAC/3qHsZBKHSvuIR1TfcueWBayhzhWB/5kW8ooSZ6X9hX6QMjFRZaSSDpcModMn9ZGsNEX3MJeDWGxcXlUsd4VMPae06ov5bZZoC+Hqa5JRBDZLbe+CVOjTGQHoxsR6uR2rhRFUTdAfcPDwau4eq77o8w7XxkblVu/SampkiwGtB/JprCxmAMsaRgqNvIYsOFaZ21EdM9fAR3259cMt2CSXUNfX0KuzxlzM7ZYGvcc9eq1LNIhyJ9p6URL5UCGp4eKl4T4D2OSHad/smSsk1/ifyis6UGvzpEFVKO98YFwY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(31686004)(6506007)(26005)(6512007)(53546011)(83380400001)(186003)(2616005)(478600001)(41300700001)(36756003)(316002)(966005)(8676002)(2906002)(66476007)(66556008)(4326008)(66946007)(31696002)(8936002)(38100700002)(86362001)(6486002)(5660300002)(44832011)(213903007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7364 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 23a1698c-4267-4c07-58e9-08da8c227be4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Oqoph7rI8dlU6OTsyLxI/ItRNwdX2Kf+2/e5/ASkcut6uK+tDnKRz/X7JDvOYnwN3CVwOt3eCgcse1reILNUOyoMaMVoAqwXilHDuflBbZs5dUFNsyh1E0zJhjMk4xPpl4ymkSMusgokS2s+JraEL0TCd/za11aj7tvIq0UNmL+eRuifrm2dBKxA/oFeqLH4ktLhb190j9v4z6HmzBELFlX2neqHkAeK9ixWZ5F6iKfhRYTqB+HueSMmkSNUtWCO2urb/+X3MXsPNyu7xh41n9/7PkLkf5jDLzk/q5VdhFsL6i8f9n6Gm/wYTUzeU66TbqDfr6TOAhdyjpcGlJB5o10S3WbnD4FPDodhL+ZnwuhKo8Qeh5V0rFe54w4Vcx+mMyNL84EkMu51nab3uEhPAynVEc0h1PNDHPxnRWVzrDMirdZXdEX/nSY3oAKS7R63VmXda0MVKBhUroqVQok0m9pwzh7eAhrB4MjObwxndRflIs99WG5pT72Ln5YYDPuMTYjtiEYi6TbC1+wynHCUYuKH70p5oNHJICnswhVGkDLGlDQX9b4WgCGCIgLxSIAjyIy/Vhno2qeImlpIZhYy/pMak+yMk13XYLwb9E7ag9HWAXqKXLvhIWBeojQWLokyfpuu5P64jsMgAkIQsHsMAM1rdAUftGZu5xy4S8FA12VUdAQM9X+qybC0bJAKF4So2LldfQcEWAC1n8lbJeQ8o1npH/5K5Pdy4XPNZhnxNQY9T8b0WEqHAyigOMV2jrgHrH7h4k7Lf5lZFn0PYpzBQEDEhoComDQunhRtO2WjoAxJiYGvLhPbYmZoZeF8+pYIPDSsAhp+Hz36ZfsZABF0nvzrlCuRAZLQ3Xzpzrd0moA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(396003)(346002)(39860400002)(40470700004)(36840700001)(46966006)(44832011)(316002)(31686004)(2906002)(40480700001)(36756003)(4326008)(8676002)(70586007)(70206006)(5660300002)(82310400005)(53546011)(6506007)(41300700001)(478600001)(8936002)(966005)(6486002)(186003)(47076005)(356005)(336012)(83380400001)(6512007)(82740400003)(2616005)(26005)(81166007)(86362001)(31696002)(36860700001)(40460700003)(213903007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 14:01:45.7976 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94fdb08f-d5c8-4e93-a101-08da8c2281a1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7761 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Merged as=C2=A0 b9bb27e1ff40..0a4079ad86f5 Thanks. Regards, Sami Mujawar On 24/08/2022 05:35 am, Jeff Brasen wrote: > Expose the UID value to GeneratePciSlots(). > > This is needed for some cases for example: > > https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pci= e-root-ports#identifying-externally-exposed-pcie-root-ports > > > > Name (_DSD, Package () { > > ToUUID("EFCC06CC-73AC-4BC3-BFF0-76143807C389"), > > Package () { > > Package (2) {"ExternalFacingPort", 1}, > > Package (2) {"UID", 0}, > > } > > }) > > > > Signed-off-by: Jeff Brasen > > --- > > DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h | 8 +++++--- > > .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 5 ++++- > > .../Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c | 8 +++++--- > > 3 files changed, 14 insertions(+), 7 deletions(-) > > > > diff --git a/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h b/Dyna= micTablesPkg/Include/Library/SsdtPcieSupportLib.h > > index 85e283a994..4171dabc33 100644 > > --- a/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h > > +++ b/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h > > @@ -54,9 +54,10 @@ AddOscMethod ( > > used. It should be possible to enumerate them, but this is additional > > information. > > =20 > > - @param [in] PciInfo Pci device information. > > - @param [in] MappingTable The mapping table structure. > > - @param [in, out] PciNode Pci node to amend. > > + @param [in] PciInfo Pci device information. > > + @param [in] MappingTable The mapping table structure. > > + @param [in] Uid Unique Id of the Pci device. > > + @param [in, out] PciNode Pci node to amend. > > =20 > > @retval EFI_SUCCESS Success. > > @retval EFI_INVALID_PARAMETER Invalid parameter. > > @@ -67,6 +68,7 @@ EFIAPI > > GeneratePciSlots ( > > IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo, > > IN CONST MAPPING_TABLE *MappingTable, > > + IN UINT32 Uid, > > IN OUT AML_OBJECT_NODE_HANDLE PciNode > > ); > > =20 > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci= eGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci= eGenerator.c > > index ceffe2838c..24e074ea90 100644 > > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera= tor.c > > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera= tor.c > > @@ -295,6 +295,7 @@ GeneratePciDeviceInfo ( > > @param [in] CfgMgrProtocol Pointer to the Configuration Manage= r > > Protocol interface. > > @param [in] PciInfo Pci device information. > > + @param [in] Uid Unique Id of the Pci device. > > @param [in, out] PciNode Pci node to amend. > > =20 > > @retval EFI_SUCCESS The function completed successfully. > > @@ -308,6 +309,7 @@ GeneratePrt ( > > IN ACPI_PCI_GENERATOR *Generato= r, > > IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL *CONST CfgMgrPro= tocol, > > IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo, > > + IN UINT32 Uid, > > IN OUT AML_OBJECT_NODE_HANDLE PciNode > > ) > > { > > @@ -416,7 +418,7 @@ GeneratePrt ( > > PrtNode =3D NULL; > > =20 > > // Generate the Pci slots once all the device have been added. > > - Status =3D GeneratePciSlots (PciInfo, &Generator->DeviceTable, PciNode= ); > > + Status =3D GeneratePciSlots (PciInfo, &Generator->DeviceTable, Uid, Pc= iNode); > > if (EFI_ERROR (Status)) { > > ASSERT (0); > > goto exit_handler; > > @@ -687,6 +689,7 @@ GeneratePciDevice ( > > Generator, > > CfgMgrProtocol, > > PciInfo, > > + Uid, > > PciNode > > ); > > if (EFI_ERROR (Status)) { > > diff --git a/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieS= upportLib.c b/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSu= pportLib.c > > index e5ab3a3ca8..b35fb6a7dd 100644 > > --- a/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportL= ib.c > > +++ b/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportL= ib.c > > @@ -41,9 +41,10 @@ > > used. It should be possible to enumerate them, but this is additional > > information. > > =20 > > - @param [in] PciInfo Pci device information. > > - @param [in] MappingTable The mapping table structure. > > - @param [in, out] PciNode Pci node to amend. > > + @param [in] PciInfo Pci device information. > > + @param [in] MappingTable The mapping table structure. > > + @param [in] Uid Unique Id of the Pci device. > > + @param [in, out] PciNode Pci node to amend. > > =20 > > @retval EFI_SUCCESS Success. > > @retval EFI_INVALID_PARAMETER Invalid parameter. > > @@ -54,6 +55,7 @@ EFIAPI > > GeneratePciSlots ( > > IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo, > > IN CONST MAPPING_TABLE *MappingTable, > > + IN UINT32 Uid, > > IN OUT AML_OBJECT_NODE_HANDLE PciNode > > ) > > { >