Re: [edk2-devel] [PATCH v2] NetworkPkg/DxeNetLib: Change the order of conditions in IF statement

["Maciej Rabeda" <maciej.rabeda@linux.intel.com>]

Merged:
https://github.com/tianocore/edk2/pull/634
https://github.com/tianocore/edk2/commit/d3733188a2162abf72dd08c0cedd1119b5cfe6c4

Thanks,
Maciej

On 20-May-20 13:41, Philippe Mathieu-Daudé wrote:
> On 5/20/20 5:08 AM, Zhang, Shenglei wrote:
>> The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is
>> meaningless if Index = 0. So checking 'Index != 0' should be
>> performed first in the if statement.
>>
>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
>> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>> ---
>>
>> v2: Update 'Index > 0' to 'Index != 0'
>>
>>   NetworkPkg/Library/DxeNetLib/NetBuffer.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/NetworkPkg/Library/DxeNetLib/NetBuffer.c 
>> b/NetworkPkg/Library/DxeNetLib/NetBuffer.c
>> index a232802c9a21..329a17623d94 100644
>> --- a/NetworkPkg/Library/DxeNetLib/NetBuffer.c
>> +++ b/NetworkPkg/Library/DxeNetLib/NetBuffer.c
>> @@ -1063,7 +1063,7 @@ NetbufAllocSpace (
>>       } else {
>>         NetbufGetByte (Nbuf, 0, &Index);
>>   -      if ((NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len) && (Index 
>> > 0)) {
>> +      if ((Index != 0) && (NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < 
>> Len)) {
>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>
>>           Index--;
>>         }
>>       }
>>
>
>
> 
>