From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.3144.1599037107281470668 for ; Wed, 02 Sep 2020 01:58:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iKFCzfvS; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599037106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zcfJIkHo11HKHJdltV9MlXMGyi+DrzblNUa2gayutf4=; b=iKFCzfvS1U6fodWNv/Jgx1Lp6u1U4R2RBDPdu1cFtULM3NRc761KEwaruhP96ERD+nt3N/ N01gDk4Z3B3rDJn4W21HtBYJMmS1kl8YtmRIW0Z1uD79rKXk8yriV/A1P9XH0lRuGtKwod orLoPbPWqI6TTpB+9TCmim3saZnpqu0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-5jeUHzt6OtCmAMhfS4LLLA-1; Wed, 02 Sep 2020 04:58:18 -0400 X-MC-Unique: 5jeUHzt6OtCmAMhfS4LLLA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 167D1800C78; Wed, 2 Sep 2020 08:58:17 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-14.ams2.redhat.com [10.36.113.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 918615C1C4; Wed, 2 Sep 2020 08:58:15 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition To: devel@edk2.groups.io, paul.grimes@amd.com Cc: Michael D Kinney , Liming Gao , Zhiguang Liu References: <20200827204051.777-1-Paul.Grimes@amd.com> <20200827204051.777-2-Paul.Grimes@amd.com> From: "Laszlo Ersek" Message-ID: <552971bb-aa6d-ab1b-9df8-895415ec176e@redhat.com> Date: Wed, 2 Sep 2020 10:58:14 +0200 MIME-Version: 1.0 In-Reply-To: <20200827204051.777-2-Paul.Grimes@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.004 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Hi Paul, meta: On 08/27/20 22:40, Paul wrote: > In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10, > but should be 0x02 per the ACPI Specification. > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2937 > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Paul G > --- > MdePkg/Include/IndustryStandard/Acpi10.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) please consider setting the "user.name" git config knob to your full name. We now have: commit 5ffcbc46908a2037ae3260d3cfcc103e4a6a48c0 Author: Paul Date: Fri Aug 28 04:40:51 2020 +0800 MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition and I like to be friendly :) but I think the Author field should state, in general, the full name, not just the first name. Similary, the Signed-off-by tag at the end of the commit message should carry the full name too. Please see section "Developer Certificate of Origin" in "ReadMe.rst": """ Signed-off-by: Developer Name developer@example.org where ``Developer Name`` is the contributor's real name, and the email address is one the developer is reachable through at the time of contributing. """ It's quite obvious from the email address that "Paul G" stands for Paul Grimes, but still spell it out. (These requests are for the future, of course; the present patch has been merged.) Thanks! Laszlo