Re: [PATCH v3 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort

[Laszlo Ersek <lersek@redhat.com>]

On 02/22/18 19:15, Ard Biesheuvel wrote:
> Introduce a variant of BaseDebugLibSerialPort that behaves correctly with
> regards to the use of the serial port after ExitBootServices(). At boot
> time, all DEBUG() prints and ASSERT() invocations are executed normally.
> At runtime, DEBUG() prints are dropped entirely, and ASSERT()s omit the
> serial output as well, and only perform the configured post-ASSERT()
> action, i.e., issue a CPU breakpoint or enter a deadloop.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  MdePkg/Library/DxeRuntimeDebugLibSerialPort/DebugLib.c                       | 346 ++++++++++++++++++++
>  MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf |  55 ++++
>  MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.uni |  21 ++
>  3 files changed, 422 insertions(+)

I compared this to v2, and separately to BaseDebugLibSerialPort too. It
looks good to me.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo