From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.8393.1614785799537254455 for ; Wed, 03 Mar 2021 07:36:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Kcep845c; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614785796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uR8XjZfghfjC5n/UfBzRh0QjshpzeIEldvu3L2BYR0I=; b=Kcep845cbg3EOSxYGkYR2flsHpXyfHFMUgKkvR+hlxNg3mGKBDqG1t3xLPvXhnWb8O9QZW LEjZI9B5GMWsEfiv0BzRtp0AljXIIHk8FIRh1lhCt3wX06q6iIx/vrAfWEIk0OsMWNN4IE oB5c8m3/0gpcYqPQOu2FpFg5CPrQyn4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-415-66nTyqNtMVmR0gSBp1TFSw-1; Wed, 03 Mar 2021 10:36:34 -0500 X-MC-Unique: 66nTyqNtMVmR0gSBp1TFSw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3BB9801978; Wed, 3 Mar 2021 15:36:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-245.ams2.redhat.com [10.36.113.245]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0377100164C; Wed, 3 Mar 2021 15:36:31 +0000 (UTC) Subject: Re: [PATCH v4 2/7] OvmfPkg: resolve MmUnblockMemoryLib (mainly for VariableSmmRuntimeDxe) To: Kun Qin , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen References: <20210302200438.1901-1-kun.q@outlook.com> From: "Laszlo Ersek" Message-ID: <554b46ea-5ce8-c262-e8bd-a13abbf8ef3e@redhat.com> Date: Wed, 3 Mar 2021 16:36:31 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/02/21 21:04, Kun Qin wrote: > This change added NULL MmUnblockMemoryLib instance in dsc files of > OvmfPkg to pass CI build. When SMM_REQUIRE flag is set, the library > interface is consumed by VariableSmmRuntimeDxe to better support variable > runtime cache feature. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > > Signed-off-by: Kun Qin > Reviewed-by: Laszlo Ersek > --- > > Notes: > v4: > - Updated patch title. [Laszlo] > - Moved this patch before the variable driver change. [Laszlo] > - Added reviewed-by tag. [Laszlo] Looks good, thank you. Laszlo > > v3: > - Newly added in v3. [Hao] > > OvmfPkg/OvmfPkgIa32.dsc | 3 +++ > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ > OvmfPkg/OvmfPkgX64.dsc | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 1b8d34052b01..1eaf3e99c6c5 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -347,6 +347,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf > QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/DxeQemuFwCfgS3LibFwCfg.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > +!if $(SMM_REQUIRE) == TRUE > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > +!endif > > [LibraryClasses.common.UEFI_DRIVER] > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 9c1aee87e783..4a5a43014725 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -351,6 +351,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf > QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/DxeQemuFwCfgS3LibFwCfg.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > +!if $(SMM_REQUIRE) == TRUE > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > +!endif > > [LibraryClasses.common.UEFI_DRIVER] > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index fabb8b2f29e4..d4d601b44476 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -353,6 +353,9 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf > QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/DxeQemuFwCfgS3LibFwCfg.inf > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > +!if $(SMM_REQUIRE) == TRUE > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > +!endif > > [LibraryClasses.common.UEFI_DRIVER] > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf >