From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.55]) by mx.groups.io with SMTP id smtpd.web09.1015.1623869906118185252 for ; Wed, 16 Jun 2021 11:58:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=97aDAOso; spf=pass (domain: arm.com, ip: 40.107.14.55, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c1mdCaZHgPHL6QGX+DvwJd7qTonsezSLVUnchB3jS4M=; b=97aDAOsoWkuWyWfTSAJz7VlEIrw0AFLrubusns3VDpE9rnRtN3LM2AjKeXEFtbRfOAnvT0N6SKyR3sjCXNvkmiCAG9n+IuP9PgbykaIVI6zdxMuGALnD3xJHBCWhVCqAEudCXO1VAUIRe/gLwzIWGzm5dy15s6PdHyZFdFiNv84= Received: from AM6P194CA0082.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::23) by VI1PR08MB3760.eurprd08.prod.outlook.com (2603:10a6:803:c1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18; Wed, 16 Jun 2021 18:57:05 +0000 Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8f:cafe::23) by AM6P194CA0082.outlook.office365.com (2603:10a6:209:8f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.16 via Frontend Transport; Wed, 16 Jun 2021 18:57:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.16 via Frontend Transport; Wed, 16 Jun 2021 18:57:05 +0000 Received: ("Tessian outbound d8701fbbf774:v93"); Wed, 16 Jun 2021 18:57:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 92db08c187beaa51 X-CR-MTA-TID: 64aa7808 Received: from c1b235c038a6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5B4AE38F-258E-4B3D-9EBF-E972746CAE6B.1; Wed, 16 Jun 2021 18:56:53 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c1b235c038a6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 16 Jun 2021 18:56:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yii+uN/gjZbeG5My/85ip2ISFfyifkq4fABgN7pfFJb/E/MnH7N5EK9tW3rFnetwuFc+HgGQisyCsxtwsbpQuyJjE2mUMt1Mu7dzLWeb3K2gZQ2rwXUX6khFi9tAUiigRGnkdEkaiC7uJc/UW3lIW1bY5cJihQ0cbdyMKApsXItpbO5fjE2Ajg/PzmQlITY4EdLCBrjYZdeNTyamjC3G33z2IFzdMYSsQheDdBAlMnRXri9TFbru/mM1q+YQbUpLE0Aju5pPOf3C6yJLkzkwj9d4o5g3hWSzKl5ZKjWh4LeLArwqS44KAS10vpkcW1F5Cmt9f0Q/g3dmfY2jFE4sLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c1mdCaZHgPHL6QGX+DvwJd7qTonsezSLVUnchB3jS4M=; b=K29V8ja1NShsvA3CoowOmtFt8enriDgSa5xL3QkWMjBr8N7Vzkta7HhvF1pIVwXsweZfllqK0sd4dh69lxgcSxjZO48w35Q5xLrpBJkfhdEAjo2zBhFNaOClVW/q5R98gSxUz9IE2LMYGoJvXichOpcO7fwKAJsO+NrThQpghoxISd2EUPMqZUAF8HxfuDSTja4EUjAxZiEp6QpL3qpmEPv/rAlNGdBpRNV3RncSkJv/yq8MV6KA4AmxUxRMgbXm5POCfLyxcMU7ZRe53K+xb9x+2ZAqX6hSZLAMGoclJs5pmilwlD3Dit6a5iI84kLXromtGgOwLeljr0F4jHVwow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c1mdCaZHgPHL6QGX+DvwJd7qTonsezSLVUnchB3jS4M=; b=97aDAOsoWkuWyWfTSAJz7VlEIrw0AFLrubusns3VDpE9rnRtN3LM2AjKeXEFtbRfOAnvT0N6SKyR3sjCXNvkmiCAG9n+IuP9PgbykaIVI6zdxMuGALnD3xJHBCWhVCqAEudCXO1VAUIRe/gLwzIWGzm5dy15s6PdHyZFdFiNv84= Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6151.eurprd08.prod.outlook.com (2603:10a6:20b:290::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18; Wed, 16 Jun 2021 18:56:44 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::5c0d:142c:27df:c52b]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::5c0d:142c:27df:c52b%6]) with mapi id 15.20.4219.025; Wed, 16 Jun 2021 18:56:44 +0000 Subject: Re: [edk2-devel] [PATCH v1 2/8] MdePkg: IORT header update for IORT Rev E.b spec To: devel@edk2.groups.io Cc: Alexei.Fedorov@arm.com, Matteo.Carlini@arm.com, Ben.Adderson@arm.com, steven.price@arm.com, Lorenzo.Pieralisi@arm.com, michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, ray.ni@intel.com, zhichao.gao@intel.com, nd@arm.com, Ard Biesheuvel References: <20210615163618.85200-1-sami.mujawar@arm.com> <1688CEC74013EBBF.1864@groups.io> From: "Sami Mujawar" Message-ID: <556c20cb-7e32-205b-7857-add4aff908c9@arm.com> Date: Wed, 16 Jun 2021 19:56:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <1688CEC74013EBBF.1864@groups.io> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO4P123CA0461.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::16) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LO4P123CA0461.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18 via Frontend Transport; Wed, 16 Jun 2021 18:56:40 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4cb53b09-b2fb-419e-0a90-08d930f888d0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6151:|VI1PR08MB3760: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AdvAAH36umob4a6y1Y0+SJtlfrP5BJhRfzGb4IrNp482x6TRYfc7tSrlugNQTwDklrKbwK1hkcprZGDuSoPo1Ch8nIWDPWFcYNfMZwTw+d5Mjj+Ial5j35Ha8I4ZwFwPr+Rji3ki/ZFAuGmb6BZp3AcmVG36OkXwkyKcHugbbsAWbBIayDh9XZhKLcgX7NCb6Dr1rjoqoP2VhCzk0IagF2h6+A077XtyV6BJjijwcfkuoUOq07qyYWRVyA4oPF0StmBRCt8Z6X4LF2zZ/iQiSeoSuu0huRydcwgpxwnwF+uAR6S0PeDIzD+xCWNKfdzaDSwf8Iw4RRgTrooqjF/hGagJKZcXaVmYYCbS4hb4k/3eNVHHoxVuwNRB3V8LhrlhK+5uHuwFj6Erbcxvvv/b5/SqzK0xwyaRtuLcYiICL5q2AtPGeOj8S1KhaNXbQt1wkjz68G3E6+Dk3XE94AhDpII/CYR28flsFSj5VnQBqbIw1ipDa3O3ozyFoJkvN7kKtHdb+vtn46N+GiI4DIMY5XY0NicJoN4XbtVUR+BwAKU7jwBftyfUSTNu29CK+K+f71jXTlBkUvZ+Vu4AiTdDpQAJ3OUst2ow0r66Fpq8AB+uUf6DU8EIED7ywX8Kuc5PG45Zj/3Y3M4jSMOEN8HAapwveci+Mf8wfNEO7OfwKqnzmMKxv8I7G9Rmox/efq8iS2y2VZNrZVi2bf20luK6z7TbrGNGsc7bGRWtZm9HtvsqNHXfptwzgAr9DEJPRRr8u7mAH5XbN0buo+R+bRXq9aECv+OUr7OuaY8BxRm5faIWfQFSu2xOnwdnLWgTtgeTvSa1ET2lPzze2N+B31PdcanLHfexKESKH9mOBd5sFy49I3Ki26acFHyhkceZtHa9 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(39850400004)(396003)(346002)(16576012)(316002)(31686004)(83380400001)(478600001)(66946007)(66476007)(66556008)(4326008)(44832011)(966005)(36756003)(956004)(26005)(8676002)(38100700002)(38350700002)(86362001)(53546011)(15650500001)(6916009)(6666004)(2616005)(52116002)(31696002)(8936002)(16526019)(2906002)(5660300002)(6486002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N21ZUnYvQnNwL0c0L3FJejlXWmdRcldwRThWR01yT0poaUtLYkQzY1NSYjlt?= =?utf-8?B?eVdWdVpxVENFM2YxV1lUWFBJd1l6eEJNNmU1RDl0SVBBUVVWUmZCbVY4eER5?= =?utf-8?B?QjRhMWlFSVY2MkhOejdDSUpyZXNLU1lhYkhFUGUxUk9FNk9ZTjZ4MzJiVlhn?= =?utf-8?B?by96T1Vaam44VklMUVFCdEhJOFhtQ3JWYkp1eTVuRVZLUEIrTWlmcjVXVGFj?= =?utf-8?B?YjRMWXloS2tkKzFQSzJKS29VTldaRXJDQWZZQUtVWVlsYkJnNTNSSGg3MGVV?= =?utf-8?B?a0pTUmZGN2JxM1doUUYwMXhlUGhOaXFoQnYzdVBNOFl3TXYxbzJEa1h0dlda?= =?utf-8?B?Z0hhbDBpR25QbEVjSzJUZ0lmcXZ4RlJNUzhZOG9QbUFEUEUyakwwc21uYWFB?= =?utf-8?B?Uy9DZkgvajY4bEhxM0lKUEdxenVGVCtNTUNoWTBLTzYrZStmWGhoYjdhRzNx?= =?utf-8?B?LzNzb0ZobnJxUEVOdDZFMUU5NnhHY05lbnVpb2J5TlluV3JITHhBZFBla1hU?= =?utf-8?B?R2cwalVieWpnMFNlWlNsNlB3ZVUwODlrSUxlNktnbTFZaUVQanEyYTE4WHU1?= =?utf-8?B?eUF2R2k0bDNVMzBDSlRHSVdUVFJ3WmdzQ0VuT3M4b0FqU2ZQNXJhNjFtdTRS?= =?utf-8?B?dTVZNnNVSlgybDBEZVZ4Y3dsTGgrYUNnRlZ4elhiS09BbWNPWnhyUlhYdysx?= =?utf-8?B?aGprUndqZEluMWx3MnFaa2NmeHUvUWZuaWxrNnZ0eEtRdllWeU9tUUFaNEVw?= =?utf-8?B?bnU1MjgvWWtMRXh3TzZpRytCS2pIb0drdGpKcHFaSW5VK2RWL0JNZkEzMklP?= =?utf-8?B?WkxYMWg2T21Ualh5TUJuNkh0VzNNelJSZHJ2cFpWb0dYaXVsekFJU0hISVZ2?= =?utf-8?B?K2FZbFNTUkJwR3VZWWc5a1BvcjZoTVlTWjRvQnJmbmFKUVNqMjRoc3FpMzJ6?= =?utf-8?B?alNqeUYrYmhRT3FVZkowK25DeENSNXI2bkhyUkdsekZxd3pqZ1Z3THlRQyto?= =?utf-8?B?SVZiZC9VM3lhdEdUdE1ORUR3eEFOY2hLeVJWd0pQQnJwdlhUL21iQTR1NXBP?= =?utf-8?B?b2VqbFNHL3ZDUEdER1pGMTNCUWlMYnJjL3c5eGRwM0NRQnVwc1dOYi9Ib3gv?= =?utf-8?B?WTVLNGNSaXhMK1UrblJVMkJBWlZkOUxVNzVYMzdiMnI3UGVNNExONUoyaGJw?= =?utf-8?B?T2laOWpENGpyYmtLcWxNalpLaFdjVSttcHpkdnlZNFNSalJBSzMrNHZWeTNV?= =?utf-8?B?WjJVNDMrT2pHZjhkV1BsUFFDVENkcGppRnJ6WEJWZXRaK0pxR04wWW1sVUE3?= =?utf-8?B?bVJuY2UxekJ3bGRRei9Pbm9rU1E5SzZBek5HNytsYVFLWTNPbkxrUHIxY0gv?= =?utf-8?B?Z2xObFRHMlVXdHNoNGtwQWJOWFdmS212WEtDa0lOVkljRktzeS9nQldNY3A1?= =?utf-8?B?S0hwSU9xcENRUkpqN0ZUZVhDcWNSV2hLZTM5SUpSZ3U2YmlYemgzZ3RBdDRE?= =?utf-8?B?dlhoQkpZRHR0U2lDQnNZbnNpaWt0L2JCaXJRS3AvTkVicmNBR3UyMERXZGcr?= =?utf-8?B?MlMxZkRlOGVxdTJ5WFVJOVkwZkVpSTZkVFpyQ0pKcnZ4Um1CN3pEcnRDT2pj?= =?utf-8?B?bTFhaTI5Z3ZZLzJ3Mno4aEdJVkNVZ3hHQjRwYXUwMlBpRys0QlUya0NodjN1?= =?utf-8?B?Q3RIY0orM2t5WHJjSTZ4VUNLSTdPNUp2N0hXcEVwV050Nlk4dzJORU9BcVdM?= =?utf-8?Q?tIPhzkT2Bka23uVUiyCfidnn62Hqwiw3jOrR02R?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6151 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 2f33c86f-8cf8-413d-da33-08d930f879d1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tqQsFSDoSCTNWTV6+1A51QI80q3JMi8w9QweudM6VXpi/GYK579AhWyCQtemFQmQDO03dtNd8P+KM2aaMYbma5Z5pzFhP/2GyKCOKlZMdwZVFF6tfR0CS7gvwYb/LPPIU5Dg7Ahb+vEuzFGTToMpFTOrxvjrnEREMkIq/sL6KMuD/TWYLTO09FlqNU++zCEqa7VgEPC6+kMIgVkCA6M12fKUevrW8RCD4eJiR9DQ58hiIOiL7DHO1ieIIE7vaNdJ95Sneca3izOOJRw5Vvo7SfcQC8HVbSlPWyTDOFhsJI3dYDVqJYJRxLDFSpjLi5y6PhWO+DQVdDDxp8eMGO/7IgeFaNP51mYSRBw19eyTEj6XUzdmWtnSbD5ccwLvdIxiB8G3+UQoPK4XGX68xZl8q5fveRjgeFg1n0uZ7OiwtIIsqFT0xAYdiw3fIPCqvZl4Qf7HK3tCJqpLO8h8a51gXIqF6LbUdeZlPdI02LZto5/oos5YOY+b1A+G3aiJ9EZRoLwTT8A++K821eIAoopn5ZUTI4I2pEAG8DGD7WVaxym3dAojwxV2R0lBmpnXFrxYdBr85qfJ0wKnoHTRkkCY35FrGXjR+UCPndVdmoT8bkiNsSzRa2SXrmw31QnaK4xm3cY0KaBkYzZ1IYTPHiZWjv67BTbwpp+D4BCDa3yXuxkHKh+RrkWcAY+UKRuYwN50VqWSw8/ZPrhcax1MjYlczTOp9HAmd5J9EWZkomIqQaSg1EOsnYzu/t2JwX3CC7q5loo9hiUL83TK6cMNrN3t1fcti3yUti5XqtWddPdFcExSfSZhskiD8xuaL2U/toYyD1gNsRFVV6uCyDAeyC8Qag== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(396003)(376002)(346002)(136003)(46966006)(36840700001)(44832011)(8676002)(107886003)(336012)(6916009)(82310400003)(2906002)(16526019)(26005)(8936002)(31686004)(6666004)(186003)(81166007)(316002)(31696002)(16576012)(4326008)(356005)(6486002)(478600001)(36756003)(82740400003)(15650500001)(70586007)(5660300002)(53546011)(86362001)(83380400001)(966005)(2616005)(956004)(70206006)(47076005)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2021 18:57:05.3354 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4cb53b09-b2fb-419e-0a90-08d930f888d0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3760 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi All, I realised that setting EFI_ACPI_IO_REMAPPING_TABLE_REVISION to 3 (Rev 3) will break existing platforms as they would not be populating the Identifier field in the IORT nodes. This can result in the Identifier fileds being non-unique. I will send out a v2 patch series that sets EFI_ACPI_IO_REMAPPING_TABLE_REVISION to 0. Regards, Sami Mujawar On 15/06/2021 05:36 PM, Sami Mujawar via groups.io wrote: > Bugzilla: 3458 - Add support IORT Rev E.b specification updates > (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) > > The IO Remapping Table, Platform Design Document, Revision E.b, > Feb 2021 (https://developer.arm.com/documentation/den0049/) > introduces the following updates, collectively including the > updates and errata fixes to Rev E and Rev E.a: > - increments the IORT table revision to 3. > - updates the node definition to add an 'Identifier' field. > - adds definition of node type 6 - Reserved Memory Range node. > - adds definition for Memory Range Descriptors. > - adds flag to indicate PRI support for root complexes. > - adds flag to indicate if the root complex supports forwarding > of PASID information on translated transactions to the SMMU. > > Therefore, update the IORT header file to reflect these changes. > > Signed-off-by: Sami Mujawar > --- > MdePkg/Include/IndustryStandard/IoRemappingTable.h | 67 ++++++++++++++++++-- > 1 file changed, 60 insertions(+), 7 deletions(-) > > diff --git a/MdePkg/Include/IndustryStandard/IoRemappingTable.h b/MdePkg/Include/IndustryStandard/IoRemappingTable.h > index 731217441438a00dd5ff0bedf2010598d48d6dbf..c6f3e7bc321ea7d85e576b2fe3c2889422477506 100644 > --- a/MdePkg/Include/IndustryStandard/IoRemappingTable.h > +++ b/MdePkg/Include/IndustryStandard/IoRemappingTable.h > @@ -1,12 +1,19 @@ > /** @file > - ACPI IO Remapping Table (IORT) as specified in ARM spec DEN0049D > - > - http://infocenter.arm.com/help/topic/com.arm.doc.den0049d/DEN0049D_IO_Remapping_Table.pdf > + ACPI IO Remapping Table (IORT) definitions. > > Copyright (c) 2017, Linaro Limited. All rights reserved.
> - Copyright (c) 2018, ARM Limited. All rights reserved.
> + Copyright (c) 2018 - 2021, Arm Limited. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > + > + @par Reference(s): > + - IO Remapping Table, Platform Design Document, Revision E.b, Feb 2021 > + (https://developer.arm.com/documentation/den0049/) > + > + @par Glossary: > + - Ref : Reference > + - Mem : Memory > + - Desc : Descriptor > **/ > > #ifndef IO_REMAPPING_TABLE_H_ > @@ -14,7 +21,9 @@ > > #include > > -#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0 > +#define EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0 > +#define EFI_ACPI_IO_REMAPPING_TABLE_REV3 0x3 > +#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION EFI_ACPI_IO_REMAPPING_TABLE_REV3 > > #define EFI_ACPI_IORT_TYPE_ITS_GROUP 0x0 > #define EFI_ACPI_IORT_TYPE_NAMED_COMP 0x1 > @@ -22,6 +31,7 @@ > #define EFI_ACPI_IORT_TYPE_SMMUv1v2 0x3 > #define EFI_ACPI_IORT_TYPE_SMMUv3 0x4 > #define EFI_ACPI_IORT_TYPE_PMCG 0x5 > +#define EFI_ACPI_IORT_TYPE_RMR 0x6 > > #define EFI_ACPI_IORT_MEM_ACCESS_PROP_CCA BIT0 > > @@ -55,7 +65,16 @@ > #define EFI_ACPI_IORT_SMMUv3_MODEL_CAVIUM_CN99XX 0x2 > > #define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED 0x0 > -#define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_SUPPORTED 0x1 > +#define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_SUPPORTED BIT0 > + > +#define EFI_ACPI_IORT_ROOT_COMPLEX_PRI_UNSUPPORTED 0x0 > +#define EFI_ACPI_IORT_ROOT_COMPLEX_PRI_SUPPORTED BIT1 > + > +#define EFI_ACPI_IORT_ROOT_COMPLEX_PASID_FWD_UNSUPPORTED 0x0 > +#define EFI_ACPI_IORT_ROOT_COMPLEX_PASID_FWD_SUPPORTED BIT2 > + > +#define EFI_ACPI_IORT_RMR_REMAP_NOT_PERMITTED 0x0 > +#define EFI_ACPI_IORT_RMR_REMAP_PERMITTED BIT0 > > #define EFI_ACPI_IORT_ID_MAPPING_FLAGS_SINGLE BIT0 > > @@ -89,7 +108,7 @@ typedef struct { > UINT8 Type; > UINT16 Length; > UINT8 Revision; > - UINT32 Reserved; > + UINT32 Identifier; > UINT32 NumIdMappings; > UINT32 IdReference; > } EFI_ACPI_6_0_IO_REMAPPING_NODE; > @@ -198,6 +217,40 @@ typedef struct { > //EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE OverflowInterruptMsiMapping[1]; > } EFI_ACPI_6_0_IO_REMAPPING_PMCG_NODE; > > +/// > +/// Memory Range Descriptor. > +/// > +typedef struct { > + /// Base address of Reserved Memory Range, > + /// aligned to a page size of 64K. > + UINT64 Base; > + > + /// Length of the Reserved Memory range. > + /// Must be a multiple of the page size of 64K. > + UINT64 Length; > + > + /// Reserved, must be zero. > + UINT32 Reserved; > +} EFI_ACPI_6_0_IO_REMAPPING_MEM_RANGE_DESC; > + > +/// > +/// Node type 6: Reserved Memory Range (RMR) node > +/// > +typedef struct { > + EFI_ACPI_6_0_IO_REMAPPING_NODE Node; > + > + /// RMR flags > + UINT32 Flags; > + > + /// Memory range descriptor count. > + UINT32 NumMemRangeDesc; > + > + /// Offset of the memory range descriptor array. > + UINT32 MemRangeDescRef; > +// EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE IdMapping[1]; > +// EFI_ACPI_6_0_IO_REMAPPING_MEM_RANGE_DESC MemRangeDesc[1]; > +} EFI_ACPI_6_0_IO_REMAPPING_RMR_NODE; > + > #pragma pack() > > #endif