public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"vit9696@protonmail.com" <vit9696@protonmail.com>
Subject: Re: [edk2-devel] [PATCH V2 1/1] BaseTools: Switch to GNU mode for CLANGPDB
Date: Tue, 11 Feb 2020 09:11:08 +0000	[thread overview]
Message-ID: <55893d164f4e4a18a4f32b9fb2ea14c8@intel.com> (raw)
In-Reply-To: <20200211065255.60865-2-vit9696@protonmail.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Vitaly Cheptsov via Groups.Io
> Sent: Tuesday, February 11, 2020 2:53 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH V2 1/1] BaseTools: Switch to GNU mode for CLANGPDB
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2397
> 
> Signed-off-by: Vitaly Cheptsov <vit9696@protonmail.com>
> ---
>  BaseTools/Conf/tools_def.template | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index 6330b87392..837107a19f 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2755,11 +2755,11 @@ RELEASE_CLANG38_AARCH64_DLINK_FLAGS = DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl
>  DEFINE CLANGPDB_IA32_PREFIX          = ENV(CLANG_BIN)
>  DEFINE CLANGPDB_X64_PREFIX           = ENV(CLANG_BIN)
> 
> -DEFINE CLANGPDB_IA32_TARGET          = -target i686-unknown-windows
> -DEFINE CLANGPDB_X64_TARGET           = -target x86_64-unknown-windows
> +DEFINE CLANGPDB_IA32_TARGET          = -target i686-unknown-windows-gnu
> +DEFINE CLANGPDB_X64_TARGET           = -target x86_64-unknown-windows-gnu
> 
>  DEFINE CLANGPDB_WARNING_OVERRIDES    = -Wno-parentheses-equality -Wno-tautological-compare -Wno-tautological-constant-out-
> of-range-compare -Wno-empty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option -Wno-microsoft-enum-
> forward-reference
> -DEFINE CLANGPDB_ALL_CC_FLAGS         = DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB_WARNING_OVERRIDES) -DNO_MSABI_VA_FUNCS
> -fno-stack-protector -mms-bitfields -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas -Wno-incompatible-library-
> redeclaration -mno-implicit-float  -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -funsigned-char -fno-ms-
> extensions -Wno-null-dereference -fms-compatibility -mno-stack-arg-probe
> +DEFINE CLANGPDB_ALL_CC_FLAGS         = DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB_WARNING_OVERRIDES) -
> DNO_MSABI_VA_FUNCS -fno-stack-protector -funsigned-char -ftrap-
> function=undefined_behavior_has_been_optimized_away_by_clang -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas
> -Wno-incompatible-library-redeclaration -Wno-null-dereference -mno-implicit-float -mms-bitfields -mno-stack-arg-probe -nostdlib -
> nostdlibinc
> 
>  ###########################
>  # CLANGPDB IA32 definitions
> --
> 2.21.1 (Apple Git-122.3)
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#54185): https://edk2.groups.io/g/devel/message/54185
> Mute This Topic: https://groups.io/mt/71160541/1759384
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [liming.gao@intel.com]
> -=-=-=-=-=-=


      reply	other threads:[~2020-02-11  9:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11  6:52 [PATCH V2 0/1] BaseTools: Switch to GNU mode for CLANGPDB Vitaly Cheptsov
2020-02-11  6:52 ` [PATCH V2 1/1] " Vitaly Cheptsov
2020-02-11  9:11   ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55893d164f4e4a18a4f32b9fb2ea14c8@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox