Hi Jeff,

Thank you for this patch.
Please see my response inline.

On Mon, Jul 10, 2023 at 03:26 PM, Jeff Brasen wrote:

+
+ Status = AmlVarListAddTail (
+ (AML_NODE_HANDLE)PackageNode,
+ (AML_NODE_HANDLE)DataNode
+ );
+ ASSERT_EFI_ERROR (Status);
+

I think if the above function fails DataNode would need to be freed as it is not linked in the AML tree. Can you check, please?

With that addressed,

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

_._,_._,_

Groups.io Links:

You receive all messages sent to this group.

_._,_._,_