From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0C357740035 for ; Tue, 8 Aug 2023 04:35:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3LjxYaqmGUL/+tLUpxeBsFEZvMu4O/P1GQj+iKmK8yQ=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691469317; v=1; b=VuEUGvE6Y5D//77A3SBDau6zPQuZe4M2VkHpBtBsgw71OmW9OuRfKJlgWqyyyI1eTpCO5YPx 0MfIZ/aKnoE40mbcW0js7DtY/OgTqgzx9IHmFLNBcv0Z5eAlQ35aKLTaR73CeIA7ogcHKqu9Wfa UFxM3HkTZC5N63GPhcTqbBpE= X-Received: by 127.0.0.2 with SMTP id b6tIYY7687511xmAmpofmwZr; Mon, 07 Aug 2023 21:35:17 -0700 Subject: Re: [edk2-devel] [PATCH v2 3/4] DynamicTablesPkg: Add support to add Strings to package To: Jeff Brasen ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Bengaluru, Karnataka, IN (223.233.85.32) X-Originating-Platform: Mac Firefox 115 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 07 Aug 2023 21:35:17 -0700 References: <722520ae73c9581ce3cf45fd0cc8ca1fd54c62fa.1689027745.git.jbrasen@nvidia.com> In-Reply-To: <722520ae73c9581ce3cf45fd0cc8ca1fd54c62fa.1689027745.git.jbrasen@nvidia.com> Message-ID: <5592.1691469317245274945@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qdcRu1rehNyM0RzN66td60Acx7686176AA= Content-Type: multipart/alternative; boundary="qLAdZPUElvYNle88v8b9" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=VuEUGvE6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --qLAdZPUElvYNle88v8b9 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Jeff, Thank you for this patch. Please see my response inline. On Mon, Jul 10, 2023 at 03:26 PM, Jeff Brasen wrote: >=20 > + > + Status =3D AmlVarListAddTail ( > + (AML_NODE_HANDLE)PackageNode, > + (AML_NODE_HANDLE)DataNode > + ); > + ASSERT_EFI_ERROR (Status); > + I think if the above function fails DataNode would need to be freed as it i= s not linked in the AML tree. Can you check, please? With that addressed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107630): https://edk2.groups.io/g/devel/message/107630 Mute This Topic: https://groups.io/mt/100068078/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --qLAdZPUElvYNle88v8b9 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Jeff,

Thank you for this patch.
Please see my response i= nline.

On Mon, Jul 10, 2023 at 03:26 PM, Jeff Brasen wrote:
+
+ Status =3D AmlVarListAddTail (
+ (AML_NODE_HANDLE= )PackageNode,
+ (AML_NODE_HANDLE)DataNode
+ );
+ ASSERT_EFI_= ERROR (Status);
+
I think if the above function fails DataNode would need to be freed as it i= s not linked in the AML tree. Can you check, please?

With that a= ddressed,

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>=

Regards,

Sami Mujawar
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#107630) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--qLAdZPUElvYNle88v8b9--