From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 146901A1E4F for ; Fri, 9 Sep 2016 01:26:24 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 783D04E4D6; Fri, 9 Sep 2016 08:26:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-81.phx2.redhat.com [10.3.116.81]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u898QLK0002905; Fri, 9 Sep 2016 04:26:22 -0400 To: "Gao, Liming" , edk2-devel-01 , Ard Biesheuvel References: <20160909072356.4746-1-lersek@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14B3E63EF@shsmsx102.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <55929520-7be5-fbec-342b-fc61c70c128a@redhat.com> Date: Fri, 9 Sep 2016 10:26:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B3E63EF@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 09 Sep 2016 08:26:23 +0000 (UTC) Subject: Re: [PATCH v2] BaseTools/EfiRom: supply missing machine type lookup strings X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 08:26:24 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 09/09/16 09:25, Gao, Liming wrote: > Reviewed-by: Liming Gao Thanks. Ard, are you OK with this patch? (You were OK with "ARM" in advance, but the AARCH64 string also changed in this version.) Thanks Laszlo >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Friday, September 09, 2016 3:24 PM >> To: edk2-devel-01 >> Cc: Ard Biesheuvel ; Gao, Liming >> ; Zhu, Yonghong >> Subject: [PATCH v2] BaseTools/EfiRom: supply missing machine type lookup >> strings >> >> "EfiRom --dump" does not recognize the 0x8664 machine type: >> >>> EFI ROM header contents >>> EFI Signature 0x0EF1 >>> Compression Type 0x0001 (compressed) >>> Machine type 0x8664 (unknown) >>> Subsystem 0x000B (EFI boot service driver) >>> EFI image offset 0x0050 (@0xF650) >> >> Add lookup strings for the remaining EFI_IMAGE_MACHINE_* numeric >> macros >> that can be found in >> "BaseTools/Source/C/Include/IndustryStandard/PeImage.h". The strings >> follow Table 12. "UEFI Image Types" from the UEFI v2.6 spec. >> >> Cc: Ard Biesheuvel >> Cc: Liming Gao >> Cc: Yonghong Zhu >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> v2: >> - use ARM for ARM [Ard, Liming] >> - use AA64 for AARCH64 [Liming] >> - reference Table 12 in the commit message [Liming] >> >> BaseTools/Source/C/EfiRom/EfiRom.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/BaseTools/Source/C/EfiRom/EfiRom.h >> b/BaseTools/Source/C/EfiRom/EfiRom.h >> index 1214700826de..6763d6b1ec28 100644 >> --- a/BaseTools/Source/C/EfiRom/EfiRom.h >> +++ b/BaseTools/Source/C/EfiRom/EfiRom.h >> @@ -117,6 +117,9 @@ static STRING_LOOKUP mMachineTypes[] = { >> { EFI_IMAGE_MACHINE_IA32, "IA32" }, >> { EFI_IMAGE_MACHINE_IA64, "IA64" }, >> { EFI_IMAGE_MACHINE_EBC, "EBC" }, >> + { EFI_IMAGE_MACHINE_X64, "X64" }, >> + { EFI_IMAGE_MACHINE_ARMT, "ARM" }, >> + { EFI_IMAGE_MACHINE_AARCH64, "AA64" }, >> { 0, NULL } >> }; >> >> -- >> 2.9.2 >