From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5B2B621E14557 for ; Mon, 21 Aug 2017 01:19:15 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 21 Aug 2017 01:21:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,408,1498546800"; d="scan'208";a="142697094" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 21 Aug 2017 01:21:46 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 Aug 2017 01:21:46 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 Aug 2017 01:21:45 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.183]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.128]) with mapi id 14.03.0319.002; Mon, 21 Aug 2017 16:21:44 +0800 From: "Song, BinX" To: "Gao, Liming" , "Yao, Jiewen" CC: "edk2-devel@lists.01.org" Thread-Topic: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option Thread-Index: AdMaR4/UYVIifvoQTgaAWdAk42hJAQADnZfQAAAd5AA= Date: Mon, 21 Aug 2017 08:21:43 +0000 Message-ID: <559D2DF22BC9A3468B4FA1AA547F0EF10258DCD8@shsmsx102.ccr.corp.intel.com> References: <559D2DF22BC9A3468B4FA1AA547F0EF10258DBE0@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D773B02@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D773B02@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2017 08:19:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, Got it, will update V3. Best Regards, Bell Song > -----Original Message----- > From: Gao, Liming > Sent: Monday, August 21, 2017 4:20 PM > To: Song, BinX ; Yao, Jiewen > Cc: edk2-devel@lists.01.org > Subject: RE: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE > option >=20 > Bin: > Please remove VS2015 from the comments in source files. >=20 > Thanks > Liming > >-----Original Message----- > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > >Song, BinX > >Sent: Monday, August 21, 2017 2:35 PM > >To: Yao, Jiewen > >Cc: edk2-devel@lists.01.org > >Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHI= VE > >option > > > >V2: > >- Recover TempRamInitApi API and add dummy TempRamInitApi function to > >fix > > build error with WHOLEARCHIVE option > > > >V1: > >- Delete useless external TempRamInitApi API to fix /WHOLEARCHIVE build > > error with VS2015 tool chain > > > >Cc: Jiewen Yao > >Contributed-under: TianoCore Contribution Agreement 1.0 > >Signed-off-by: Bell Song > >--- > > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++ > > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++ > > 2 files changed, 20 insertions(+) > > > >diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > >b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > >index 9744e16..81b531e 100644 > >--- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > >+++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > >@@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset): > > ret > > > > ;----------------------------------------------------------------------= ------ > >+; TempRamInit API > >+; > >+; Dummy function for VS2015 WHOLEARCHIVE build option > >+; > >+;----------------------------------------------------------------------= ------ > >+global ASM_PFX(TempRamInitApi) > >+ASM_PFX(TempRamInitApi): > >+ ret > >+ > >+;----------------------------------------------------------------------= ------ > > ; Module Entrypoint API > > ;----------------------------------------------------------------------= ------ > > global ASM_PFX(_ModuleEntryPoint) > >diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > >b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > >index cdc1149..06a791f 100644 > >--- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > >+++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > >@@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue): > > ret > > > > ;----------------------------------------------------------------------= ------ > >+; TempRamInit API > >+; > >+; Dummy function for VS2015 WHOLEARCHIVE build option > >+; > >+;----------------------------------------------------------------------= ------ > >+global ASM_PFX(TempRamInitApi) > >+ASM_PFX(TempRamInitApi): > >+ ret > >+ > >+;----------------------------------------------------------------------= ------ > > ; Module Entrypoint API > > ;----------------------------------------------------------------------= ------ > > global ASM_PFX(_ModuleEntryPoint) > >-- > >2.10.2.windows.1 > > > >_______________________________________________ > >edk2-devel mailing list > >edk2-devel@lists.01.org > >https://lists.01.org/mailman/listinfo/edk2-devel