From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Permerror (SPF Permanent Error: More than 10 MX records returned) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=binx.song@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA2A12035B2C5 for ; Sun, 17 Dec 2017 21:12:41 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2017 21:17:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,420,1508828400"; d="scan'208";a="159647934" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 17 Dec 2017 21:17:26 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 17 Dec 2017 21:17:25 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Mon, 18 Dec 2017 13:17:23 +0800 From: "Song, BinX" To: "Kinney, Michael D" , "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "lersek@redhat.com" , "Dong, Eric" Thread-Topic: [edk2] [PATCH] UefiCpuPkg: Keep library class header file definition independent Thread-Index: AdN0teO6xpInh5KPTf+ChLPDpM1bdgAaOWKAABpBUYAAjeQ1oA== Date: Mon, 18 Dec 2017 05:17:23 +0000 Message-ID: <559D2DF22BC9A3468B4FA1AA547F0EF1025C2B79@shsmsx102.ccr.corp.intel.com> References: <559D2DF22BC9A3468B4FA1AA547F0EF1025C2739@shsmsx102.ccr.corp.intel.com> <195703e3-0831-80a7-b3c4-f44116c06aee@Intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] UefiCpuPkg: Keep library class header file definition independent X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 05:12:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray & Mike, Thanks for your suggestion, I will update a V2 patch. Best Regards, Bell Song > -----Original Message----- > From: Kinney, Michael D > Sent: Saturday, December 16, 2017 1:34 AM > To: Ni, Ruiyu ; Song, BinX ; > edk2-devel@lists.01.org; Kinney, Michael D > Cc: lersek@redhat.com; Dong, Eric > Subject: RE: [edk2] [PATCH] UefiCpuPkg: Keep library class header file > definition independent >=20 > Ray, >=20 > I agree. The max should not be in the lib class > header file. >=20 > Mike >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel- > > bounces@lists.01.org] On Behalf Of Ni, Ruiyu > > Sent: Thursday, December 14, 2017 9:02 PM > > To: Song, BinX ; edk2- > > devel@lists.01.org > > Cc: lersek@redhat.com; Dong, Eric > > Subject: Re: [edk2] [PATCH] UefiCpuPkg: Keep library > > class header file definition independent > > > > On 12/14/2017 4:31 PM, Song, BinX wrote: > > > Keep library class header file definition independent > > > > > > Cc: Eric Dong > > > Cc: Laszlo Ersek > > > Contributed-under: TianoCore Contribution Agreement > > 1.1 > > > Signed-off-by: Bell Song > > > --- > > > UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h > > | 7 +++---- > > > > > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFe > > aturesLib.c | 7 ++----- > > > 2 files changed, 5 insertions(+), 9 deletions(-) > > > > > > diff --git > > a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h > > b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h > > > index fc3ccda..9582ad8 100644 > > > --- > > a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h > > > +++ > > b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h > > > @@ -71,12 +71,11 @@ > > > #define CPU_FEATURE_APIC_TPR_UPDATE_MESSAGE > > (32+9) > > > #define CPU_FEATURE_ENERGY_PERFORMANCE_BIAS > > (32+10) > > > #define CPU_FEATURE_PPIN > > (32+11) > > > +#define CPU_FEATURE_PROC_TRACE > > (32+12) > > > // > > > -// Currently, CPU_FEATURE_PROC_TRACE is the MAX > > feature we support. > > > -// If you define a feature bigger than it, please > > also replace it > > > -// in RegisterCpuFeatureLibIsFeatureValid function. > > > +// Please keep CPU_FEATURE_MAX as the max CPU > > feature > > > // > > > -#define CPU_FEATURE_PROC_TRACE > > (32+12) > > > +#define CPU_FEATURE_MAX > > (32+12) > > I think we need to define this CPU_FEATURE_MAX in > > RegisterCpuFeaturesLib.c. > > > > Thinking about another instance of > > RegisterCpuFeatureLib > > that only supports features up to (32+9). > > The MAX will be 32+9 for that instance. > > The library class header only defines the features and > > corresponding ID (32+xx). > > Library instance chooses which features to support. > > > > > > > > #define CPU_FEATURE_BEFORE_ALL > > BIT27 > > > #define CPU_FEATURE_AFTER_ALL > > BIT28 > > > diff --git > > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpu > > FeaturesLib.c > > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpu > > FeaturesLib.c > > > index 6ec26e1..911f4d0 100644 > > > --- > > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpu > > FeaturesLib.c > > > +++ > > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpu > > FeaturesLib.c > > > @@ -97,11 +97,8 @@ > > RegisterCpuFeatureLibIsFeatureValid ( > > > > > > Data =3D Feature; > > > Data &=3D ~(CPU_FEATURE_BEFORE | CPU_FEATURE_AFTER > > | CPU_FEATURE_BEFORE_ALL | CPU_FEATURE_AFTER_ALL); > > > - // > > > - // Currently, CPU_FEATURE_PROC_TRACE is the MAX > > feature we support. > > > - // If you define a feature bigger than it, please > > replace it at below. > > > - // > > > - if (Data > CPU_FEATURE_PROC_TRACE) { > > > + > > > + if (Data > CPU_FEATURE_MAX) { > > > DEBUG ((DEBUG_ERROR, "Invalid CPU feature: 0x%x > > ", Feature)); > > > return FALSE; > > > } > > > > > > > > > -- > > Thanks, > > Ray > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel