* [PATCH] UefiCpuPkg: Enhance feature dependency check
@ 2018-01-12 2:19 Song, BinX
2018-01-15 2:53 ` Dong, Eric
0 siblings, 1 reply; 2+ messages in thread
From: Song, BinX @ 2018-01-12 2:19 UTC (permalink / raw)
To: edk2-devel@lists.01.org; +Cc: Dong, Eric, lersek@redhat.com
Enhance MCA feature dependency check base on SDM pseudocode example 15-1.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song <binx.song@intel.com>
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
index b012c69..58dc45a 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
@@ -105,6 +105,9 @@ McaSupport (
IN VOID *ConfigData OPTIONAL
)
{
+ if (!MceSupport (ProcessorNumber, CpuInfo, ConfigData)) {
+ return FALSE;
+ }
return (CpuInfo->CpuIdVersionInfoEdx.Bits.MCA == 1);
}
--
2.10.2.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] UefiCpuPkg: Enhance feature dependency check
2018-01-12 2:19 [PATCH] UefiCpuPkg: Enhance feature dependency check Song, BinX
@ 2018-01-15 2:53 ` Dong, Eric
0 siblings, 0 replies; 2+ messages in thread
From: Dong, Eric @ 2018-01-15 2:53 UTC (permalink / raw)
To: Song, BinX, edk2-devel@lists.01.org; +Cc: lersek@redhat.com
Reviewed-by: Eric Dong <eric.dong@intel.com>
-----Original Message-----
From: Song, BinX
Sent: Friday, January 12, 2018 10:19 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; lersek@redhat.com
Subject: [PATCH] UefiCpuPkg: Enhance feature dependency check
Enhance MCA feature dependency check base on SDM pseudocode example 15-1.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song <binx.song@intel.com>
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
index b012c69..58dc45a 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
@@ -105,6 +105,9 @@ McaSupport (
IN VOID *ConfigData OPTIONAL
)
{
+ if (!MceSupport (ProcessorNumber, CpuInfo, ConfigData)) {
+ return FALSE;
+ }
return (CpuInfo->CpuIdVersionInfoEdx.Bits.MCA == 1); }
--
2.10.2.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-15 2:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-12 2:19 [PATCH] UefiCpuPkg: Enhance feature dependency check Song, BinX
2018-01-15 2:53 ` Dong, Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox