* Re: [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib
2016-11-02 8:44 ` Gao, Liming
@ 2016-11-02 16:47 ` Kinney, Michael D
2016-11-03 1:08 ` Song, BinX
1 sibling, 0 replies; 4+ messages in thread
From: Kinney, Michael D @ 2016-11-02 16:47 UTC (permalink / raw)
To: Gao, Liming, Song, BinX, edk2-devel@lists.01.org,
Kinney, Michael D
Liming,
I agree. That is better than having to use #ifndef.
The UEFI Specification does not have the #defines for the CHAR_x values,
so we can move the subset of these character values required by libraries
of type BASE into Base.h starting with CHAR_NULL.
Thanks,
Mike
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao, Liming
> Sent: Wednesday, November 2, 2016 1:44 AM
> To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib
>
> Bin:
> I suggest move CHAR_NULL definition from Protocol\SimpleTextIn.h to Base.h
>
> Thanks
> Liming
> -----Original Message-----
> From: Song, BinX
> Sent: Wednesday, November 2, 2016 4:27 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib
>
> - https://bugzilla.tianocore.org/show_bug.cgi?id=172
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
> MdePkg/Include/Base.h | 7 +++++++
> MdePkg/Library/BaseLib/FilePaths.c | 2 --
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
> index 2217058..0c3318f 100644
> --- a/MdePkg/Include/Base.h
> +++ b/MdePkg/Include/Base.h
> @@ -338,6 +338,13 @@ struct _LIST_ENTRY {
> ///
> #define NULL ((VOID *) 0)
>
> +//
> +// Required unicode control chars
> +//
> +#ifndef CHAR_NULL
> +#define CHAR_NULL 0x0000
> +#endif
> +
> ///
> /// Maximum values for common UEFI Data Types
> ///
> diff --git a/MdePkg/Library/BaseLib/FilePaths.c b/MdePkg/Library/BaseLib/FilePaths.c
> index c8da6bb..183b323 100644
> --- a/MdePkg/Library/BaseLib/FilePaths.c
> +++ b/MdePkg/Library/BaseLib/FilePaths.c
> @@ -10,10 +10,8 @@
> THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> **/
> -#include <Uefi/UefiBaseType.h>
> #include <Library/BaseMemoryLib.h>
> #include <Library/BaseLib.h>
> -#include <Protocol/SimpleTextIn.h>
>
> /**
> Removes the last directory or file entry in a path by changing the last
> --
> 2.7.2.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib
2016-11-02 8:44 ` Gao, Liming
2016-11-02 16:47 ` Kinney, Michael D
@ 2016-11-03 1:08 ` Song, BinX
1 sibling, 0 replies; 4+ messages in thread
From: Song, BinX @ 2016-11-03 1:08 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Hi Liming,
Thanks for your info, I will update.
Best Regards,
Bell Song
> -----Original Message-----
> From: Gao, Liming
> Sent: Wednesday, November 2, 2016 4:44 PM
> To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> Subject: RE: [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib
>
> Bin:
> I suggest move CHAR_NULL definition from Protocol\SimpleTextIn.h to
> Base.h
>
> Thanks
> Liming
> -----Original Message-----
> From: Song, BinX
> Sent: Wednesday, November 2, 2016 4:27 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib
>
> - https://bugzilla.tianocore.org/show_bug.cgi?id=172
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
> MdePkg/Include/Base.h | 7 +++++++
> MdePkg/Library/BaseLib/FilePaths.c | 2 --
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
> index 2217058..0c3318f 100644
> --- a/MdePkg/Include/Base.h
> +++ b/MdePkg/Include/Base.h
> @@ -338,6 +338,13 @@ struct _LIST_ENTRY {
> ///
> #define NULL ((VOID *) 0)
>
> +//
> +// Required unicode control chars
> +//
> +#ifndef CHAR_NULL
> +#define CHAR_NULL 0x0000
> +#endif
> +
> ///
> /// Maximum values for common UEFI Data Types
> ///
> diff --git a/MdePkg/Library/BaseLib/FilePaths.c
> b/MdePkg/Library/BaseLib/FilePaths.c
> index c8da6bb..183b323 100644
> --- a/MdePkg/Library/BaseLib/FilePaths.c
> +++ b/MdePkg/Library/BaseLib/FilePaths.c
> @@ -10,10 +10,8 @@
> THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> **/
> -#include <Uefi/UefiBaseType.h>
> #include <Library/BaseMemoryLib.h>
> #include <Library/BaseLib.h>
> -#include <Protocol/SimpleTextIn.h>
>
> /**
> Removes the last directory or file entry in a path by changing the last
> --
> 2.7.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread