From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0B23F81CDC for ; Wed, 2 Nov 2016 19:02:53 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP; 02 Nov 2016 19:02:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,436,1473145200"; d="scan'208";a="27152532" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 02 Nov 2016 19:02:54 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Nov 2016 19:02:54 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Nov 2016 19:02:53 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0248.002; Thu, 3 Nov 2016 10:02:51 +0800 From: "Song, BinX" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in BaseLib Thread-Index: AdI1cfJrDdsxHpRYQsK8+mqvX7VDTwAAskdAAABnAzA= Date: Thu, 3 Nov 2016 02:02:51 +0000 Message-ID: <559D2DF22BC9A3468B4FA1AA547F0EF1354B8C@shsmsx102.ccr.corp.intel.com> References: <559D2DF22BC9A3468B4FA1AA547F0EF1354B23@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14B49DF7D@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B49DF7D@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in BaseLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 02:02:53 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, Got it, I will update again. Best Regards, Bell Song > -----Original Message----- > From: Gao, Liming > Sent: Thursday, November 3, 2016 9:56 AM > To: Song, BinX ; edk2-devel@lists.01.org > Subject: RE: [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to > Base.h in BaseLib >=20 > Bin: > On CHAR_NULL definition in Base.h, its comment should be Null character= . > And, for the second version patch, you need change title to PATCH V2, and > describe what changes in V2. >=20 > > +// > > +// Required unicode control chars =3D=3D> Null character > > +// > > +#define CHAR_NULL 0x0000 >=20 > Thanks > Liming > > -----Original Message----- > > From: Song, BinX > > Sent: Thursday, November 03, 2016 9:31 AM > > To: edk2-devel@lists.01.org > > Cc: Gao, Liming > > Subject: [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h > in > > BaseLib > > > > - https://bugzilla.tianocore.org/show_bug.cgi?id=3D172 > > > > Cc: Liming Gao > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Bell Song > > --- > > MdePkg/Include/Base.h | 5 +++++ > > MdePkg/Include/Protocol/SimpleTextIn.h | 1 - > > MdePkg/Library/BaseLib/FilePaths.c | 2 -- > > 3 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h > > index 2217058..2441875 100644 > > --- a/MdePkg/Include/Base.h > > +++ b/MdePkg/Include/Base.h > > @@ -338,6 +338,11 @@ struct _LIST_ENTRY { > > /// > > #define NULL ((VOID *) 0) > > > > +// > > +// Required unicode control chars > > +// > > +#define CHAR_NULL 0x0000 > > + > > /// > > /// Maximum values for common UEFI Data Types > > /// > > diff --git a/MdePkg/Include/Protocol/SimpleTextIn.h > > b/MdePkg/Include/Protocol/SimpleTextIn.h > > index 71dcb0b..ebe1c7e 100644 > > --- a/MdePkg/Include/Protocol/SimpleTextIn.h > > +++ b/MdePkg/Include/Protocol/SimpleTextIn.h > > @@ -46,7 +46,6 @@ typedef struct { > > // > > // Required unicode control chars > > // > > -#define CHAR_NULL 0x0000 > > #define CHAR_BACKSPACE 0x0008 > > #define CHAR_TAB 0x0009 > > #define CHAR_LINEFEED 0x000A > > diff --git a/MdePkg/Library/BaseLib/FilePaths.c > > b/MdePkg/Library/BaseLib/FilePaths.c > > index c8da6bb..183b323 100644 > > --- a/MdePkg/Library/BaseLib/FilePaths.c > > +++ b/MdePkg/Library/BaseLib/FilePaths.c > > @@ -10,10 +10,8 @@ > > THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > BASIS, > > WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > > EXPRESS OR IMPLIED. > > **/ > > -#include > > #include > > #include > > -#include > > > > /** > > Removes the last directory or file entry in a path by changing the l= ast > > -- > > 2.7.2.windows.1