* [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
@ 2016-11-08 3:01 Song, BinX
2016-11-09 2:24 ` Gao, Liming
0 siblings, 1 reply; 4+ messages in thread
From: Song, BinX @ 2016-11-08 3:01 UTC (permalink / raw)
To: edk2-devel@lists.01.org; +Cc: Gao, Liming
There are two invalid if judgments in BootLogoEnableLogo() function,
remove them.
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song <binx.song@intel.com>
---
MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
index 2c1e8ea..b69dda8 100644
--- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
+++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
@@ -141,14 +141,6 @@ BootLogoEnableLogo (
if (EFI_ERROR (Status)) {
break;
}
-
- if (EFI_ERROR (Status)) {
- continue;
- }
-
- if (Blt != NULL) {
- FreePool (Blt);
- }
Blt = Image.Bitmap;
//
--
2.7.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
2016-11-08 3:01 [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments Song, BinX
@ 2016-11-09 2:24 ` Gao, Liming
2016-11-10 5:42 ` Song, BinX
0 siblings, 1 reply; 4+ messages in thread
From: Gao, Liming @ 2016-11-09 2:24 UTC (permalink / raw)
To: Song, BinX, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu
Bin:
Why remove FreePool (Blt)? It is still used.
Thanks
Liming
> -----Original Message-----
> From: Song, BinX
> Sent: Tuesday, November 08, 2016 11:01 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
>
> There are two invalid if judgments in BootLogoEnableLogo() function,
> remove them.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
> MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 2c1e8ea..b69dda8 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -141,14 +141,6 @@ BootLogoEnableLogo (
> if (EFI_ERROR (Status)) {
> break;
> }
> -
> - if (EFI_ERROR (Status)) {
> - continue;
> - }
> -
> - if (Blt != NULL) {
> - FreePool (Blt);
> - }
> Blt = Image.Bitmap;
>
> //
> --
> 2.7.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
2016-11-09 2:24 ` Gao, Liming
@ 2016-11-10 5:42 ` Song, BinX
2016-11-10 7:54 ` Ni, Ruiyu
0 siblings, 1 reply; 4+ messages in thread
From: Song, BinX @ 2016-11-10 5:42 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu
Hi Liming,
In BootLogoEnableLogo() function, the FreePool(Blt) function will never be called, some Blt related code as below:
a. Blt = NULL; -> Step 1, Blt was initialized.
......
b. if (Blt != NULL) { \
FreePool (Blt); -- Step 2, Blt was checked, the judgment is always false.
} /
c. Blt = Image.Bitmap; Step 3, Blt get an valid value.
>From above, I think we can remove this if judgment.
Best Regards,
Bell Song
> -----Original Message-----
> From: Gao, Liming
> Sent: Wednesday, November 9, 2016 10:25 AM
> To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: RE: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if
> judgments
>
> Bin:
> Why remove FreePool (Blt)? It is still used.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: Song, BinX
> > Sent: Tuesday, November 08, 2016 11:01 AM
> > To: edk2-devel@lists.01.org
> > Cc: Gao, Liming <liming.gao@intel.com>
> > Subject: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if
> judgments
> >
> > There are two invalid if judgments in BootLogoEnableLogo() function,
> > remove them.
> >
> > Cc: Liming Gao <liming.gao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Bell Song <binx.song@intel.com>
> > ---
> > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > index 2c1e8ea..b69dda8 100644
> > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > @@ -141,14 +141,6 @@ BootLogoEnableLogo (
> > if (EFI_ERROR (Status)) {
> > break;
> > }
> > -
> > - if (EFI_ERROR (Status)) {
> > - continue;
> > - }
> > -
> > - if (Blt != NULL) {
> > - FreePool (Blt);
> > - }
> > Blt = Image.Bitmap;
> >
> > //
> > --
> > 2.7.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
2016-11-10 5:42 ` Song, BinX
@ 2016-11-10 7:54 ` Ni, Ruiyu
0 siblings, 0 replies; 4+ messages in thread
From: Ni, Ruiyu @ 2016-11-10 7:54 UTC (permalink / raw)
To: Song, BinX, Gao, Liming, edk2-devel@lists.01.org
Bell,
FreePool (Blt) purposely frees the pool of Image.Bitmap, which was returned from previous loop. It's useful.
Thanks/Ray
> -----Original Message-----
> From: Song, BinX
> Sent: Thursday, November 10, 2016 1:42 PM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: RE: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if
> judgments
>
> Hi Liming,
>
> In BootLogoEnableLogo() function, the FreePool(Blt) function will never be
> called, some Blt related code as below:
>
> a. Blt = NULL; -> Step 1, Blt was initialized.
> ......
> b. if (Blt != NULL) { \
> FreePool (Blt); -- Step 2, Blt was checked, the judgment is always false.
> } /
>
> c. Blt = Image.Bitmap; Step 3, Blt get an valid value.
>
> From above, I think we can remove this if judgment.
>
> Best Regards,
> Bell Song
>
> > -----Original Message-----
> > From: Gao, Liming
> > Sent: Wednesday, November 9, 2016 10:25 AM
> > To: Song, BinX <binx.song@intel.com>; edk2-devel@lists.01.org
> > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> > Subject: RE: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if
> > judgments
> >
> > Bin:
> > Why remove FreePool (Blt)? It is still used.
> >
> > Thanks
> > Liming
> > > -----Original Message-----
> > > From: Song, BinX
> > > Sent: Tuesday, November 08, 2016 11:01 AM
> > > To: edk2-devel@lists.01.org
> > > Cc: Gao, Liming <liming.gao@intel.com>
> > > Subject: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if
> > judgments
> > >
> > > There are two invalid if judgments in BootLogoEnableLogo() function,
> > > remove them.
> > >
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Contributed-under: TianoCore Contribution Agreement 1.0
> > > Signed-off-by: Bell Song <binx.song@intel.com>
> > > ---
> > > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 --------
> > > 1 file changed, 8 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > > index 2c1e8ea..b69dda8 100644
> > > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > > @@ -141,14 +141,6 @@ BootLogoEnableLogo (
> > > if (EFI_ERROR (Status)) {
> > > break;
> > > }
> > > -
> > > - if (EFI_ERROR (Status)) {
> > > - continue;
> > > - }
> > > -
> > > - if (Blt != NULL) {
> > > - FreePool (Blt);
> > > - }
> > > Blt = Image.Bitmap;
> > >
> > > //
> > > --
> > > 2.7.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-10 7:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-08 3:01 [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments Song, BinX
2016-11-09 2:24 ` Gao, Liming
2016-11-10 5:42 ` Song, BinX
2016-11-10 7:54 ` Ni, Ruiyu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox