public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Song, BinX" <binx.song@intel.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if judgments
Date: Thu, 10 Nov 2016 08:19:59 +0000	[thread overview]
Message-ID: <559D2DF22BC9A3468B4FA1AA547F0EF1359DB6@shsmsx102.ccr.corp.intel.com> (raw)

FreePool (Blt) function will be called in while loop, cannot be removed.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song <binx.song@intel.com>
---
 MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
index 2c1e8ea..8bd9985 100644
--- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
+++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
@@ -142,10 +142,6 @@ BootLogoEnableLogo (
       break;
     }
 
-    if (EFI_ERROR (Status)) {
-      continue;
-    }
-
     if (Blt != NULL) {
       FreePool (Blt);
     }
-- 
2.10.2.windows.1



             reply	other threads:[~2016-11-10  8:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10  8:19 Song, BinX [this message]
2016-11-10  8:31 ` [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if judgments Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559D2DF22BC9A3468B4FA1AA547F0EF1359DB6@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox