* [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if judgments
@ 2016-11-10 8:19 Song, BinX
2016-11-10 8:31 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Song, BinX @ 2016-11-10 8:19 UTC (permalink / raw)
To: edk2-devel@lists.01.org; +Cc: Gao, Liming
FreePool (Blt) function will be called in while loop, cannot be removed.
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song <binx.song@intel.com>
---
MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
index 2c1e8ea..8bd9985 100644
--- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
+++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
@@ -142,10 +142,6 @@ BootLogoEnableLogo (
break;
}
- if (EFI_ERROR (Status)) {
- continue;
- }
-
if (Blt != NULL) {
FreePool (Blt);
}
--
2.10.2.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if judgments
2016-11-10 8:19 [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if judgments Song, BinX
@ 2016-11-10 8:31 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2016-11-10 8:31 UTC (permalink / raw)
To: Song, BinX, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Song, BinX
> Sent: Thursday, November 10, 2016 4:20 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if
> judgments
>
> FreePool (Blt) function will be called in while loop, cannot be removed.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
> MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 2c1e8ea..8bd9985 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -142,10 +142,6 @@ BootLogoEnableLogo (
> break;
> }
>
> - if (EFI_ERROR (Status)) {
> - continue;
> - }
> -
> if (Blt != NULL) {
> FreePool (Blt);
> }
> --
> 2.10.2.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-10 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 8:19 [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if judgments Song, BinX
2016-11-10 8:31 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox