From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 83B5B941417 for ; Fri, 26 Jan 2024 14:11:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hlBYf3oYqEW87sw0OxNF34ShKcfn3uqTCsUNc5a3A9Q=; c=relaxed/simple; d=groups.io; h=Mime-Version:Subject:From:In-Reply-To:Date:Cc:Message-Id:References:To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706278280; v=1; b=dhilWzksS50dXKXDocEB1b1EUCcw2rzLfihmZlmNkA+7jW0qJESFLfvtUTDpcaZSuKI7P0an XPbvzr5Yo3lp7EiJZrc28SlF7WduZiEl91TUms4Fc8Z67dcmJ3Qa2t+ANgSiWt0WxwUoy47Xiv6 tRXMSzdy3HsaGCaMQWIfnuCc= X-Received: by 127.0.0.2 with SMTP id XlPIYY7687511xdEGKSrw8Q3; Fri, 26 Jan 2024 06:11:20 -0800 X-Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mx.groups.io with SMTP id smtpd.web11.16871.1706278279442841470 for ; Fri, 26 Jan 2024 06:11:19 -0800 X-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50edf4f478eso552414e87.3 for ; Fri, 26 Jan 2024 06:11:19 -0800 (PST) X-Gm-Message-State: JdAHjQHvZVrxt2VIY4VjdNDZx7686176AA= X-Google-Smtp-Source: AGHT+IGK1rK7x2hCG4QWrjPlRS9fmvFrQ1qYnfxJfRz5XlEjEm3WOla8+xOSKzMO8Wskfhthn/I+QQ== X-Received: by 2002:a19:750b:0:b0:510:14cd:1d16 with SMTP id y11-20020a19750b000000b0051014cd1d16mr765629lfe.63.1706278277261; Fri, 26 Jan 2024 06:11:17 -0800 (PST) X-Received: from smtpclient.apple ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id s11-20020a19770b000000b0051023c2e95asm191192lfc.209.2024.01.26.06.11.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jan 2024 06:11:16 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver From: "Mike Maslenkin" In-Reply-To: Date: Fri, 26 Jan 2024 17:11:15 +0300 Cc: "devel@edk2.groups.io" , Nickle Wang , Igor Kulchytskyy Message-Id: <55E3AADE-AC5B-4C86-84CB-31EC4166F92E@gmail.com> References: <20240126010023.958-1-abner.chang@amd.com> <5880033F-2E1E-445E-8B1B-F267A54853A8@gmail.com> To: "Chang, Abner" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dhilWzks; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io You are right. Sorry for the noise! No problems here. I mixed up with tags in my editor while looked into patch. Regards, Mike > On 26. 1. 2024., at 17:03, Chang, Abner wrote: >=20 > [AMD Official Use Only - General] >=20 > Hi Mike, > I can't identify the issue on %s as Private->Uri is defined as EFI_STRING= , or I miss something? >=20 > Thanks > Abner >=20 >> -----Original Message----- >> From: M M >> Sent: Friday, January 26, 2024 9:55 PM >> To: devel@edk2.groups.io; Nickle Wang >> Cc: Chang, Abner ; Igor Kulchytskyy >> >> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V2] >> RedfishClientPkg/FeatureDriver: ComputerSystem_1_13_0 driver >>=20 >> Caution: This message originated from an External Source. Use proper cau= tion >> when opening attachments, clicking links, or responding. >>=20 >>=20 >> Hi Abner, >>=20 >>> On 26. 1. 2024., at 05:20, Nickle Wang via groups.io >> wrote: >>>=20 >>> Hi Abner, >>>=20 >>> Same minor issue as 1_5_0. Please add "%a:" to below DEBUG call. >>>=20 >>>> + DEBUG ((DEBUG_MANAGEABILITY, " No platform Redfish >> ConfigureLang >>>> found for %s\n", __func__, Private->Uri)); >>>=20 >>> Regards, >>> Nickle >>=20 >> There are two issues in this string. The second one is incorrect %s for= mat used >> for Private->Uri. >> This issue exists in V3 not only in the line mentioned above. >>=20 >> Regards, >> Mike. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114615): https://edk2.groups.io/g/devel/message/114615 Mute This Topic: https://groups.io/mt/103967446/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-