Re: Patch List for 202008 stable tag

["Laszlo Ersek" <lersek@redhat.com>]

On 08/20/20 13:30, Gao, Liming wrote:
> Hi Stewards and all:
>   I collect current patch lists in devel mail list. Those patch contributors request to add them for 202008 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.
> 
> Feature List:
> https://edk2.groups.io/g/devel/message/63767 [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
> [Liming] This patch pass code review after Soft Feature Freeze (SFF) starts. According to SFF definition, it should not be merged for this stable tag. But, the patch submitter says this patch is important to RISC-V community. To catch it for this stable tag, Laszlo proposed the solution to defer SFF start day from 2020-08-14 to 2020-08-21, then hard feature freeze and release date will also defer one week. Any patches those pass review before new SFF start day can be merged. @ Stewards, please give your comments to defer this stable tag release by one week.

Thank you, very nice summary.

As stated earlier, I'm OK with 1 week (or even two weeks, if needed)
extension. I invite Andrew, Leif and Mike to comment.

> 
> https://edk2.groups.io/g/devel/message/63348 [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
> [Liming] This patch has collected the review comment. New version will be sent. I have no information how important it is. @Vladimir, does this patch must catch this stable tag? If yes, can you give the reason?

This is a feature addition. While it's a super useful feature, it needs
to mature (mainly from the coding style perspective, as I gather).
Posting of new versions and review are on-going.

Most likely material for the next stable tag. In case we extend the
deadlines, and Maciej and the ShellPkg maintainers approve one of the
upcoming versions until the new SFF, then yes, we can merge that too.

> Bug List:
> https://edk2.groups.io/g/devel/message/64383 [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
> [Liming] This patch has collected the review comment. New version will be sent.

This is a bugfix. Certainly a build fix on CLANGPDB. I tried to do some
(lightweight) analysis to see whether the bug is a functional one as
well (i.e. whether the bad code path that CLANG warns about can actually
occur in practice), but in the end I didn't want to spend much time on
it, as the build breakage needs to be fixed anyway.

So, this patch (more precisely, v2 of this patch) would even qualify
during the hard feature freeze (as it's clearly a bugfix).

> 
> https://edk2.groups.io/g/devel/message/50406 [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h
> [Liming] This patch passed review early. But, it is not merged. I will merge it.

Right, it was approved on 2019-Nov-18. If it still applies cleanly, it
should be merged, before we enter the Hard Feature Freeze.

Well... now that I'm writing this, we have already entered the HFF (as
planned originally) and the patch doesn't seem to be upstream yet. So
unless we extend, I don't think this patch qualifies.

(On the other hand -- it seems like we really should extend.)

Thanks!
Laszlo