Re: [PATCH v4 0/6] read-only UDF file system support

[Laszlo Ersek <lersek@redhat.com>]

Paulo,

On 09/07/17 02:23, Ni, Ruiyu wrote:
> Sure. Please.

Before pushing the series, I wanted to slightly regression-test OVMF and
ArmVirtQemu with it.

However, I've found that the series doesn't build for OVMF IA32. I get
an error like this:

> MdeModulePkg/Universal/Disk/UdfDxe/File.c: In function 'UdfRead':
> MdeModulePkg/Universal/Disk/UdfDxe/File.c:376:7: error: passing argument 8 of 'ReadFileData' from incompatible pointer type [-Werror]
>        );
>        ^
> In file included from MdeModulePkg/Universal/Disk/UdfDxe/File.c:15:0:
> MdeModulePkg/Universal/Disk/UdfDxe/Udf.h:1008:1: note: expected 'UINT64 *' but argument is of type 'UINTN *'
>  ReadFileData (

There could be further such errors (I didn't check, the build stopped
here).

Can you please submit a v5 that is 32-bit and 64-bit clean?

I expect that any changes you make will be in the first three patches
somewhere. If they are not trivial, please drop Ray's Reviewed-by from
the affected patches so he can review them again.

I'm not sure if Ray uses any tools for supporting incremental review;
you could help him by including a cumulative diff between v4 and v5 in
the v5 blurb.

Thanks!
Laszlo



> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, September 6, 2017 10:28 PM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>
> Cc: Paulo Alcantara <pcacjr@zytor.com>; edk2-devel@lists.01.org; Dong, Eric <eric.dong@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2] [PATCH v4 0/6] read-only UDF file system support
>
> Ray, Star,
>
> On 08/24/17 19:56, Paulo Alcantara wrote:
>
>> v2:
>>  - Rework to _partially_ support UDF revisions <2.60.
>>  - Use existing CDROM_VOLUME_DESCRIPTOR structure defined in Eltorito.h
>>    instead of creating another one (UDF_VOLUME_DESCRIPTOR).
>>  - Fixed UdfDxe to correctly follow UEFI driver model.
>>  - Use HARDDRIVE_DEVICE_PATH instead of a vendor-defined one.
>>  - Detect UDF file systems only in PartitionDxe, and let UdfDxe driver
>>    check for specific UDF device path to decide whether or not install
>>    SimpleFs protocol.
>>  - Place MdePkg changes in a separate patch.
>> v3:
>>  - Install UDF partition child handles with a Vendor-Defined Media
>>    Device Path.
>>  - Changed UdfDxe to check for Vendor-Defined Media Device Paths with a
>>    specific UDF file system GUID when determining to whether or not
>>    start the driver.
>>  - Removed leading TAB chars in some source files identified by
>>    PatchCheck.py tool.
>> v4:
>>  - Added missing R-b's.
>
> Looks like the series is now fully reviewed (with the Mde*Pkg patches having Ray's R-b). Are you guys OK if I push the v4 set?
>
> Thanks,
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>