From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CAFD821E977F6 for ; Thu, 7 Sep 2017 04:33:06 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 746384E4F3; Thu, 7 Sep 2017 11:35:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 746384E4F3 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-54.rdu2.redhat.com [10.10.120.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 465F15B806; Thu, 7 Sep 2017 11:35:55 +0000 (UTC) To: Paulo Alcantara Cc: "Ni, Ruiyu" , "Zeng, Star" , "Dong, Eric" , "Wu, Hao A" , "Justen, Jordan L" , "edk2-devel@lists.01.org" , Andrew Fish , "Gao, Liming" , "Kinney, Michael D" References: <9d28a05c-21de-1d7f-65f2-56c82811973e@redhat.com> <734D49CCEBEEF84792F5B80ED585239D5BA26BF3@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <560b0e20-9164-20f2-8cb5-bed753a820db@redhat.com> Date: Thu, 7 Sep 2017 13:35:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BA26BF3@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 07 Sep 2017 11:35:57 +0000 (UTC) Subject: Re: [PATCH v4 0/6] read-only UDF file system support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 11:33:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Paulo, On 09/07/17 02:23, Ni, Ruiyu wrote: > Sure. Please. Before pushing the series, I wanted to slightly regression-test OVMF and ArmVirtQemu with it. However, I've found that the series doesn't build for OVMF IA32. I get an error like this: > MdeModulePkg/Universal/Disk/UdfDxe/File.c: In function 'UdfRead': > MdeModulePkg/Universal/Disk/UdfDxe/File.c:376:7: error: passing argument 8 of 'ReadFileData' from incompatible pointer type [-Werror] > ); > ^ > In file included from MdeModulePkg/Universal/Disk/UdfDxe/File.c:15:0: > MdeModulePkg/Universal/Disk/UdfDxe/Udf.h:1008:1: note: expected 'UINT64 *' but argument is of type 'UINTN *' > ReadFileData ( There could be further such errors (I didn't check, the build stopped here). Can you please submit a v5 that is 32-bit and 64-bit clean? I expect that any changes you make will be in the first three patches somewhere. If they are not trivial, please drop Ray's Reviewed-by from the affected patches so he can review them again. I'm not sure if Ray uses any tools for supporting incremental review; you could help him by including a cumulative diff between v4 and v5 in the v5 blurb. Thanks! Laszlo > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, September 6, 2017 10:28 PM > To: Ni, Ruiyu ; Zeng, Star > Cc: Paulo Alcantara ; edk2-devel@lists.01.org; Dong, Eric ; Wu, Hao A ; Justen, Jordan L ; Andrew Fish ; Gao, Liming ; Kinney, Michael D > Subject: Re: [edk2] [PATCH v4 0/6] read-only UDF file system support > > Ray, Star, > > On 08/24/17 19:56, Paulo Alcantara wrote: > >> v2: >> - Rework to _partially_ support UDF revisions <2.60. >> - Use existing CDROM_VOLUME_DESCRIPTOR structure defined in Eltorito.h >> instead of creating another one (UDF_VOLUME_DESCRIPTOR). >> - Fixed UdfDxe to correctly follow UEFI driver model. >> - Use HARDDRIVE_DEVICE_PATH instead of a vendor-defined one. >> - Detect UDF file systems only in PartitionDxe, and let UdfDxe driver >> check for specific UDF device path to decide whether or not install >> SimpleFs protocol. >> - Place MdePkg changes in a separate patch. >> v3: >> - Install UDF partition child handles with a Vendor-Defined Media >> Device Path. >> - Changed UdfDxe to check for Vendor-Defined Media Device Paths with a >> specific UDF file system GUID when determining to whether or not >> start the driver. >> - Removed leading TAB chars in some source files identified by >> PatchCheck.py tool. >> v4: >> - Added missing R-b's. > > Looks like the series is now fully reviewed (with the Mde*Pkg patches having Ray's R-b). Are you guys OK if I push the v4 set? > > Thanks, > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >