From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mx.groups.io with SMTP id smtpd.web11.7085.1687180304738519068 for ; Mon, 19 Jun 2023 06:11:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@freebsd.org header.s=dkim header.b=gzlWZlxE; spf=pass (domain: freebsd.org, ip: 96.47.72.81, mailfrom: corvink@freebsd.org) Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4Ql9C36lLMz3KhK; Mon, 19 Jun 2023 13:11:43 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ql9C36030z3tfC; Mon, 19 Jun 2023 13:11:43 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687180303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Md6ZfjJEJZvtmW2KZuExRmtAlb4wWoglw9EtjUbEdXs=; b=gzlWZlxENGdyI+xtm+/+PTOs5euMy9IwlnkbeXhLBPH+bNP60na3Pao3Qfn+nnQ+EvJokx iq+5JIhc/37I0n2YzZHPXj6XzDpxUGwZOy1T7IbKmvtgUW+8xAyEKMjIg5zf4VUr88Ozlq yKGi0F0lr90gavjtehS6eWWdb0hHPry2V7eSRIvABIidjVvY/kb5gIsSoU1i/KSsa4uCbD wQF4JgDAbw5j/EOEhTzBGvVGYtd3GmMqYydgXTV9EAh3K03J4z95JipTa1a26I7i40jGud lVTgxt4L4pDuYu7a5Zz/gL287skkJDcB+7MLPDNaLnBAXaxfJiiejLXYEs9gOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687180303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Md6ZfjJEJZvtmW2KZuExRmtAlb4wWoglw9EtjUbEdXs=; b=JCt1EZCADiJrsVZWiKCj7nguO5XXB9dH+Ex4k4RFCYK1nwRF33uTtkORln3Stk2K/nWEhB +KFG8coTknYOswZnAUKwTIBd8xxM9DGFq4+2unhScLdWe2iWRTzfn5/ZRRE74m3krHsgbd FlgPMef6H3dZcdCTbLCQ5kbqBl8JDd+sHWlmLQvMcK72aksvKplVwLkC1Up7ZCe2krR5RN cUBVeg94+IPE51CvOjEy2Y/39DE7mfo45V8Fudg7YH1kaFnBOlIhTSnXYOP4B3UUgbQmzf PfoSn8XXmKQ2VjXwcoj8zLbApcm1OZt77TvdcHS1LHAVkhYa4Ls8lWWXMlAXTA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687180303; a=rsa-sha256; cv=none; b=WBnQ2d6ie5SufboTAxPv8j7NkH6qnosMhSMCYV4Z8wnXBX9smj2zWwGzr7CEuG4y1yd6fk 8PzNeYsFYSn9dxFXRHOZbTqwd/IXT0tBgZcIV2C7mN1h+Pru2LSU3Puk2hJao9UQ3vdlGV DSGICWWp3nsSRNufVJnIt86Z11Aku2TSDqWnaReIJkGESlzzuPzpxwj3nSr+TVgz0BcOoV U14mKRu69GwTN//KV6ee723mXbRqvXTtUtRi4x89aJ/Xef4pFG6L25AKDpIm99yY/S/4SY 3iFM6LAiW/oFn9XDQfzrVTCCBkuq9IuR9yPUf/V3sUXkJkBS1xP+vVziyD3z4g== Received: from [IPv6:2001:9e8:da5e:c500:c216:138:c907:f83b] (unknown [IPv6:2001:9e8:da5e:c500:c216:138:c907:f83b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Ql9C24vxbzTyy; Mon, 19 Jun 2023 13:11:42 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: <561c34c8807f88c987290c53578393469cfd2750.camel@FreeBSD.org> Subject: Re: [PATCH 1/5] OvmfPkg: avoid including AcpiPlatformLib twice From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: Gerd Hoffmann Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Leif Lindholm , Peter Grehan , Rebecca Cran , Sami Mujawar Date: Mon, 19 Jun 2023 15:11:40 +0200 In-Reply-To: References: <20230614075915.141380-1-corvink@FreeBSD.org> <20230614075915.141380-2-corvink@FreeBSD.org> <86c9b635ed392aac2b25b67a8383d1f33654e3f1.camel@FreeBSD.org> User-Agent: Evolution 3.48.3 MIME-Version: 1.0 X-Groupsio-MsgNum: 106172 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-/cq6MIRpk6SaVD8sUWka" --=-/cq6MIRpk6SaVD8sUWka Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2023-06-19 at 15:04 +0200, Gerd Hoffmann wrote: > On Mon, Jun 19, 2023 at 01:52:19PM +0200, Corvin K=C3=B6hne wrote: > > On Mon, 2023-06-19 at 12:41 +0200, Gerd Hoffmann wrote: > > > On Wed, Jun 14, 2023 at 09:55:43AM +0200, Corvin K=C3=B6hne wrote: > > > > Signed-off-by: Corvin K=C3=B6hne > > > > Cc: Ard Biesheuvel > > > > Cc: Gerd Hoffmann > > > > Cc: Jiewen Yao > > > > Cc: Jordan Justen > > > > Cc: Leif Lindholm > > > > Cc: Peter Grehan > > > > Cc: Rebecca Cran > > > > Cc: Sami Mujawar > > >=20 > > > Series breaks OvmfPkg/OvmfPkgIa32.dsc build. > > >=20 > > > take care, > > > =C2=A0 Gerd > > >=20 > >=20 > > Hi Gerd, > >=20 > > CI was successful for OvmfPkg/OvmfPkgIa32.dsc: > > https://github.com/tianocore/edk2/pull/4545 > > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D95435&= view=3Dresults >=20 > /home/kraxel/projects/edk2/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPla > tformLib.c:18:1: error: conflicting types for > =E2=80=98GetAcpiRsdpFromMemory=E2=80=99; have =E2=80=98EFI_STATUS(UINTN,= =C2=A0 UINTN,=C2=A0 > EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER **)=E2=80=99 {aka =E2=80=98u= nsigned > int(unsigned int,=C2=A0 unsigned int,=C2=A0 > EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER **)=E2=80=99} > =C2=A0=C2=A0 18 | GetAcpiRsdpFromMemory ( > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | ^~~~~~~~~~~~~~~~~~~~~ > In file included from > /home/kraxel/projects/edk2/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPla > tformLib.c:12: > /home/kraxel/projects/edk2/OvmfPkg/Include/Library/AcpiPlatformLib.h: > 33:1: note: previous declaration of =E2=80=98GetAcpiRsdpFromMemory=E2=80= =99 with type > =E2=80=98EFI_STATUS(UINT64,=C2=A0 UINT64,=C2=A0 > EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER **)=E2=80=99 {aka =E2=80=98u= nsigned > int(long long unsigned int,=C2=A0 long long unsigned int,=C2=A0 > EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER **)=E2=80=99} > =C2=A0=C2=A0 33 | GetAcpiRsdpFromMemory ( > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | ^~~~~~~~~~~~~~~~~~~~~ > make: *** [GNUmakefile:311: > /home/kraxel/projects/edk2/Build/OvmfIa32/DEBUG_GCC5/IA32/OvmfPkg/Lib > rary/AcpiPlatformLib/DxeAcpiPlatformLib/OUTPUT/DxeAcpiPlatformLib.obj > ] Error 1 >=20 > Looks like UINTN vs. UINT64 >=20 > take care, > =C2=A0 Gerd >=20 Sry, forgot to send an update of my series. Already fixed it in my PR: https://github.com/tianocore/edk2/pull/4545/commits/3b7b1e09051228ee0cfb5ef= 0765a707e4c83bbfc --=20 Kind regards, Corvin --=-/cq6MIRpk6SaVD8sUWka Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmSQVAwACgkQ2FTaVjFe AmqI/Q/8DW8eY7R1ekApusvnvljSPZw6E6z6lC10I7r/+IJhOUgqiPm71EfPvT/K Q3wlG6Wsb1M8heaNToGcfNMjq/4N8itSaFcRscivY25kAjOVCY7fF0GqrvPJcmfc Hm49ZTKUNT2nDixZyJs+yY5JrevVsjTo01YjId5jccvavO43QVCFyTVYAXblKaVd ORoixlj/IRWfqWeoW9fvRzVZVcvpP1435ugAPFaq3oQdB3RhZpLxM4C07+hSqtN8 bSq8LygVYeSfKqmS4M2XjF5q+8LXez4PgUPW7GiMo0FmxqJh53ICut3TsuVKS5Vp 7D92LpdMczkThIZEBRprupf6DASmv1KvS2WUe+HVE5t/niB6TyZvdrcgLJnxwSTM JkgpvatxhOxt809LlwlfTTjICVV3+2g7g+pN6p/4uJuRy8TizGRB7S7f4iUPajPs Zkuk/faA8Fwkpcs1V2oq2bnTSzRhnLwbLiIK4nuYf1z58y8E3a7idDaGctUVVbh2 ZJPZlmBy6EHA7AfszXwcleiKTnyu8tqi6PlJUfZQ7RCsYNIgtdlrfMvEr53qpwj2 4gryKlMwxdInSCKBvgVegPWw7EC8EaV+dGtl5odCgVx5Ng2EzWJKb2yDcuN/hDBq ghUciyPXHDttT3Y6EfMFFvgc/w7UL4YtOA1bgezvgJzZI/E33tA= =W5HO -----END PGP SIGNATURE----- --=-/cq6MIRpk6SaVD8sUWka--