public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile
@ 2021-08-04 19:58 Benjamin Doron
  2021-08-04 19:58 ` [edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: " Benjamin Doron
                   ` (3 more replies)
  0 siblings, 4 replies; 15+ messages in thread
From: Benjamin Doron @ 2021-08-04 19:58 UTC (permalink / raw)
  To: devel; +Cc: Chasel Chiu, Nate DeSimone

Follow AcpiPlatformDxe (from which this module is derived) and install
all ACPI tables added by board.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
 Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c   | 1 +
 Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
index 0361ffc2fbf9..fd227d9b410e 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
@@ -289,6 +289,7 @@ InstallAcpiBoard (
   // Platform ACPI Tables
   //
   PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
+  PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile));
 
   //
   // This protocol publish must be done after PublishAcpiTablesFromFv.
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
index 7d2e105e5447..4d7f5cdb3eeb 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
@@ -59,6 +59,8 @@
   gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints
   gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints
 
+  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
+
 [Depex]
   gEfiAcpiTableProtocolGuid           AND
   gEfiFirmwareVolume2ProtocolGuid     AND
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [edk2-devel][edk2-platforms][PATCH v1 0/4] Platform/Intel:
@ 2022-09-06 16:55 Benjamin Doron
  2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron
  0 siblings, 1 reply; 15+ messages in thread
From: Benjamin Doron @ 2022-09-06 16:55 UTC (permalink / raw)
  To: devel

BoardAcpiDxe is derived from AcpiPlatformDxe, but only the
silicon/platform DSDT is installed. However, boards can have tables that
must be installed too. For instance, laptops often have an EC ACPI
device. Therefore, implement support for installing the generic
PcdAcpiTableStorageFile too.

Tested with KabylakeOpenBoardPkg, the Aspire VN7-572G's BoardAcpiTables
are successfully installed.

Benjamin Doron (4):
  KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all
    PcdAcpiTableStorageFile
  CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all
    PcdAcpiTableStorageFile
  MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile
  WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all
    PcdAcpiTableStorageFile

 .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c              | 15 ++++++++++++++-
 .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf            |  2 ++
 .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c              | 15 ++++++++++++++-
 .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf            |  2 ++
 .../Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c   | 10 ++++++++++
 .../Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf |  3 +++
 .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c              | 15 ++++++++++++++-
 .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf            |  2 ++
 8 files changed, 61 insertions(+), 3 deletions(-)

-- 
2.37.2


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-09-06 16:56 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-04 19:58 [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron
2021-08-04 19:58 ` [edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: " Benjamin Doron
2021-08-04 21:27   ` Chaganty, Rangasai V
2021-08-04 21:51     ` [edk2-devel] " Benjamin Doron
2021-08-04 22:25       ` Nate DeSimone
2021-09-04 21:50         ` Benjamin Doron
2021-08-13  7:03   ` Nate DeSimone
2021-08-04 19:58 ` [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron
2021-08-13  7:04   ` [edk2-devel] " Nate DeSimone
2021-08-26  2:52   ` Nate DeSimone
2021-08-04 19:59 ` [edk2-platforms][PATCH v1 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe " Benjamin Doron
2021-08-13  7:04   ` Nate DeSimone
2021-08-13  7:03 ` [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: " Nate DeSimone
2021-08-28 20:38   ` [edk2-devel] " Benjamin Doron
  -- strict thread matches above, loose matches on Subject: below --
2022-09-06 16:55 [edk2-devel][edk2-platforms][PATCH v1 0/4] Platform/Intel: Benjamin Doron
2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox