From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C0B9D780091 for ; Fri, 8 Dec 2023 13:28:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NluxxNkwVjGVHjviXbfbDcrJ5tBBPSt+jaZvjrV5yiA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702042099; v=1; b=ji0Mic660XqUIpv7yiF8c0GfQQ/Irvf33ZEK1lOAqZhq0ajkv3fRhNIE/VKccjNjll/sOl9X sws3DrY+zNriiYJPKZjB5S3qtfVds7RM9T04/87bi0Vdc3ObG3K8gdFF0oFVNkhlU7TDbTKyHjS QAsIjLlw/Nv8eq9XpxEVDdhE= X-Received: by 127.0.0.2 with SMTP id wZy8YY7687511xd1192SqQsj; Fri, 08 Dec 2023 05:28:19 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.35478.1702042098738134384 for ; Fri, 08 Dec 2023 05:28:18 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-yejmNrbYN0yoRiIwuZozJw-1; Fri, 08 Dec 2023 08:28:14 -0500 X-MC-Unique: yejmNrbYN0yoRiIwuZozJw-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 00974185A785; Fri, 8 Dec 2023 13:28:14 +0000 (UTC) X-Received: from [10.39.193.124] (unknown [10.39.193.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 947EE1C060AF; Fri, 8 Dec 2023 13:28:12 +0000 (UTC) Message-ID: <562d543c-efc5-ce98-739f-cf06887c2ba3@redhat.com> Date: Fri, 8 Dec 2023 14:28:11 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Use processor extended information To: devel@edk2.groups.io, jiaxin.wu@intel.com, "Ni, Ray" Cc: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , "Zeng, Star" References: <20231115111553.6592-1-jiaxin.wu@intel.com> <20231115111553.6592-4-jiaxin.wu@intel.com> <8626fc57-1956-e9f1-f0ab-6c5a3ba45059@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zjXXXXXZXmuOTGBN8ZwhImSrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ji0Mic66; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/20/23 13:42, Wu, Jiaxin wrote: > For core id in cpu features library, I agree it should be not easy or > simple change to 0x1f. > >   > > But in SMM CPU, there is no usage case depends on the number of cores > retrieved from cupid 0x0b return value, only PackageId will be used. So, > this patch doesn’t do bad things, should no regression issue. I agree > with Ray’s explanation that  “CPUID.0B.PackageId == CPUID.1F.PackageId”, > thus no need update for the PackageId update. > >   > > I checked the latest SDM: > >   > > “The sub-leaves of CPUID leaf 0BH describe an ordered hierarchy of > logical processors starting from the smallest-scoped domain of a Logical > Processor (sub-leaf index 0) to the Core domain (sub-leaf index 1) to > the largest-scoped domain (the last valid sub-leaf index) **that is > implicitly subordinate to the unenumerated highest-scoped domain of the > processor package (socket)**” > >   > > Looks it already updated to indicate the largest-scoped domain is package. > >   > > With all above, I agree to drop this path, but other 2 patches in this > set should be ok. Thanks Ray help clarify this. Merged the first two patches in the series as commits ad0b1cc144b56fcbd8d369eaff6eaf5f3020efe7 and 7eb504060787c9c37d5b3c33f5d65021d553ea3f, via . Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112229): https://edk2.groups.io/g/devel/message/112229 Mute This Topic: https://groups.io/mt/102602853/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-