public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, samer@elhajmahmoud.com
Cc: Leif Lindholm <leif@nuviainc.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [edk2-devel] [edk2][PATCH v2 2/2] Revert "ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher"
Date: Tue, 14 Apr 2020 14:19:11 +0200	[thread overview]
Message-ID: <5637071c-b254-d95b-3773-b58bd69a08cb@redhat.com> (raw)
In-Reply-To: <20200410152925.6119-3-samer@elhajmahmoud.com>

On 04/10/20 17:29, Samer El-Haj-Mahmoud wrote:
> This reverts commit e0692789058ee2c0099f88852503c16dbb0bae4e.
> 
> The default value for PcdAcpiExposedTableVersions is now set to 0x20
> for Aarch64 systems. Setting this PCD in ArmVirtPkg/ArmVirtQemu.dsc
> is no longer necessary.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmVirtPkg/ArmVirtQemu.dsc | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 5a210a0bac72..1233f1ece484 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -209,10 +209,6 @@
>    # point only, for entry point versions >= 3.0.
>    gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x2
>  
> -  # ACPI predates the AARCH64 architecture by 5 versions, so
> -  # we only target OSes that support ACPI v5.0 or later
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
> -
>  [PcdsDynamicDefault.common]
>    gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
>  
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


      reply	other threads:[~2020-04-14 12:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 15:29 [edk2][PATCH v2 0/2] ACPI table defailt for Aarch64 Samer El-Haj-Mahmoud
2020-04-10 15:29 ` [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms Samer El-Haj-Mahmoud
2020-04-14  9:45   ` [edk2-devel] " Sami Mujawar
2020-04-14 13:33     ` Samer El-Haj-Mahmoud
2020-04-18 15:14   ` Samer El-Haj-Mahmoud
2020-04-20 12:15     ` Laszlo Ersek
2020-04-21  4:56       ` Dandan Bi
2020-04-21  8:41         ` Laszlo Ersek
2020-04-21  8:46           ` Liming Gao
2020-04-21  8:54   ` Wu, Hao A
2020-04-21 17:06     ` Ard Biesheuvel
2020-04-10 15:29 ` [edk2][PATCH v2 2/2] Revert "ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher" Samer El-Haj-Mahmoud
2020-04-14 12:19   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5637071c-b254-d95b-3773-b58bd69a08cb@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox