From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.9814.1586866757703083368 for ; Tue, 14 Apr 2020 05:19:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LGPCqG5/; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586866756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7DSuZ2PM3jwA/lUdCf9yZ+FgbCupC+q+Qujg1mDqmxc=; b=LGPCqG5/M1dp1WcwdgQTeIpW0royzNX31mUBTKdOvhLd1jF58qbhAbnLCgfDKUipdgmOUY 7OlHWRcaLnOIHXDo+qKfU7lkj4Rs2EBjKZEPcMRovJDAQpIoxUM+gW9b7Tt0Ct80rgRIvU xWj/y1GMsUEspek6kvlanV8gnLJonCM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-ZM_9mnZXPeSZpyHl4pC0IQ-1; Tue, 14 Apr 2020 08:19:15 -0400 X-MC-Unique: ZM_9mnZXPeSZpyHl4pC0IQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B59D7801E70; Tue, 14 Apr 2020 12:19:13 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-193.ams2.redhat.com [10.36.113.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id A6B6760BE1; Tue, 14 Apr 2020 12:19:12 +0000 (UTC) Subject: Re: [edk2-devel] [edk2][PATCH v2 2/2] Revert "ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher" To: devel@edk2.groups.io, samer@elhajmahmoud.com Cc: Leif Lindholm , Ard Biesheuvel References: <20200410152925.6119-1-samer@elhajmahmoud.com> <20200410152925.6119-3-samer@elhajmahmoud.com> From: "Laszlo Ersek" Message-ID: <5637071c-b254-d95b-3773-b58bd69a08cb@redhat.com> Date: Tue, 14 Apr 2020 14:19:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200410152925.6119-3-samer@elhajmahmoud.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/10/20 17:29, Samer El-Haj-Mahmoud wrote: > This reverts commit e0692789058ee2c0099f88852503c16dbb0bae4e. > > The default value for PcdAcpiExposedTableVersions is now set to 0x20 > for Aarch64 systems. Setting this PCD in ArmVirtPkg/ArmVirtQemu.dsc > is no longer necessary. > > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Ard Biesheuvel > > Signed-off-by: Samer El-Haj-Mahmoud > Acked-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirtQemu.dsc | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 5a210a0bac72..1233f1ece484 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -209,10 +209,6 @@ > # point only, for entry point versions >= 3.0. > gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x2 > > - # ACPI predates the AARCH64 architecture by 5 versions, so > - # we only target OSes that support ACPI v5.0 or later > - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 > - > [PcdsDynamicDefault.common] > gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 > > Reviewed-by: Laszlo Ersek