From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.55]) by mx.groups.io with SMTP id smtpd.web12.20761.1621265624183652384 for ; Mon, 17 May 2021 08:33:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=6N/DOEL6; spf=pass (domain: arm.com, ip: 40.107.7.55, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f9JgC6X2plSi8noGBmb2RC2uSstonrhQw6ZQEgNb6I8=; b=6N/DOEL6844O76DKSYcIcjSwYTuDSOUuethICXF4KCDMqP0ojQGIatlg07JqbbfBdfH+m4GsyNh+GvC9+tZtJdS7PC7bVKujR69fgbcmTxZSkH1f5SWUhxGfjGhgS2YYrzKZ0vnjTEdfQ4vmeiciJGaJF8GYNJihAtZcuD/WIZs= Received: from AS8PR04CA0054.eurprd04.prod.outlook.com (2603:10a6:20b:312::29) by AM0PR08MB5283.eurprd08.prod.outlook.com (2603:10a6:208:123::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Mon, 17 May 2021 15:33:40 +0000 Received: from AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:312:cafe::2f) by AS8PR04CA0054.outlook.office365.com (2603:10a6:20b:312::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 17 May 2021 15:33:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT056.mail.protection.outlook.com (10.152.17.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 17 May 2021 15:33:38 +0000 Received: ("Tessian outbound 504317ef584c:v92"); Mon, 17 May 2021 15:33:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ca4c9a2b28c01693 X-CR-MTA-TID: 64aa7808 Received: from 865979082a85.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 550D7A58-E9CF-47B4-96C3-D0C88D3E2DE5.1; Mon, 17 May 2021 15:33:28 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 865979082a85.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 17 May 2021 15:33:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KJaF9wNJyPVzt5plIb49zsfMJCK2fZ1ybLKUjSFO/scMiKa1sC3Vapbs/1Ibog1w9Y4FVkdU7dYD0CZyAuQZ5Vpvh2XzR379490CRGqcU+ib/rwTR6HtnAu/81Yc2S8tQGNzjgN41tg+NTYOUCsZaeBkukiteCvVcYIycpEA6cjBJHgXihkMuABc9d2xHvp+zjIAY+doC73ukRk19WwI3NnwvA3iCOVSWxltwsItq93M5XUYQFBHD865bY9RPCfBoTf48xbvmL6DE8i7cL8b7KIJt9HiqJEB5vM1Qm6g3L1+ZBx26EbdRCDSBxbMeh2rEXmdVN0R+tFiF/zcpdAOkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f9JgC6X2plSi8noGBmb2RC2uSstonrhQw6ZQEgNb6I8=; b=BOsuIwB/KIFrO5PaAdORa3qVIpTl0Yf+mX3sVhzHBc1GdEg0ViCrj1WmvXKqraoN1AbKZd8/mUaCvMouU1Mdc1TjFjtOgm4t16STh/WdAjCH9zLceEUOuxmuTLrjAOKe1kXJY2ixd6SJzMH17FcL+GXs6/vJqMrxA94iM+gxv3+O7cwU+ZnG/grvD3n6C5ILSqWCFwayam8RoWjslrEQCqFGu9AnBV+X2MpJgoIwaNbfbA66SHfOGfwdAFtQ47JmsWKzgI8b6GPcOaCbAN6sK9kkUMm4dhLbKRMWOnTM21iNH6H7N223mq+Pzgh+A9pWsFzHaEsjPObbiEShNReqsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f9JgC6X2plSi8noGBmb2RC2uSstonrhQw6ZQEgNb6I8=; b=6N/DOEL6844O76DKSYcIcjSwYTuDSOUuethICXF4KCDMqP0ojQGIatlg07JqbbfBdfH+m4GsyNh+GvC9+tZtJdS7PC7bVKujR69fgbcmTxZSkH1f5SWUhxGfjGhgS2YYrzKZ0vnjTEdfQ4vmeiciJGaJF8GYNJihAtZcuD/WIZs= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4343.eurprd08.prod.outlook.com (2603:10a6:20b:ba::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Mon, 17 May 2021 15:33:23 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4129.031; Mon, 17 May 2021 15:33:23 +0000 Subject: Re: [edk2-platforms][PATCH V2 05/11] Platform/Sgi: Add SMBIOS Type3 Table To: Pranav Madhu , devel@edk2.groups.io Cc: Ard Biesheuvel , nd@arm.com References: <20210516092917.21124-1-pranav.madhu@arm.com> <20210516092917.21124-6-pranav.madhu@arm.com> From: "Sami Mujawar" Message-ID: <56522b95-30e7-238e-7a3a-ec041978410d@arm.com> Date: Mon, 17 May 2021 16:33:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210516092917.21124-6-pranav.madhu@arm.com> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LNXP123CA0023.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::35) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LNXP123CA0023.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 17 May 2021 15:33:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6aba58ce-29dc-471c-477a-08d9194924c6 X-MS-TrafficTypeDiagnostic: AM6PR08MB4343:|AM0PR08MB5283: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2582;OLM:2582; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SuDe7Djs1lRiDO2AFt8GSo/LYc4uxn6Dd5MLKxwDXaYlowmkMJI3DuF9AvzpVN2pL5VkGfHZ7DG+BnhZz3JaCiUbKUDd3Aye/oICDhzAaBF74Qx62+fnC/12Vn+jqvSbG57cqNUsDLE4tRivmYy14bK6uXb1tNkYPp+nCnCHgyx+URH+U+OHfxszFfUIOHMUa1yqtommK31FOI+nCmG4JgNheKYXCpHm4fT1RT0HIH9mGaQSg+MZtLu8+Z625mfpXFykDmZvBkWTBxM4ovqFfS7zA9iZIdKHtRvgxReCjXw1o8EbqmHm3uXAQDvGPcormhTX9a7F+gR9PqKxUlZr/0fuT0BIhgaxK0CLEdFI4ePLB+67VzDVFmuSdbecuS7LX2hUaCmJHhEjKveI0/uT3/Ebp1o8AhIhRCiKM2KplVuaWvAdOWbUEN3DO/2olm2So7SEOmmd6x4lZDD60Xdg2PAFMft1hp+/o1YzXiIecjAZmdLrk09LwKSNgpwGXiT/yeWUXR85obEzbHsh5IwMX1ngOonR4UFZuRQKP5oE64FeG3HoKgQ0ctrok3mgkdBy1aCvWzvgvgM7y/HNUwwuKFCNsEifOyzSXZEV6dywib+XMXuPCQ8s3CiJfXJ3Tb8NCAXmkIt3v3p73akqRxDAgaaxjQ07+mORtvLlArz6GUxoKI9kjwhA5gs3A4cf/sXR3VN5lmO1uy0u2vFzvzrppXtOK+Vp1VJBauywmjSNU5o= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(366004)(346002)(39850400004)(396003)(186003)(19627235002)(16526019)(36756003)(316002)(83380400001)(52116002)(26005)(38100700002)(38350700002)(6486002)(16576012)(44832011)(66556008)(2906002)(53546011)(31696002)(4326008)(86362001)(8936002)(8676002)(956004)(2616005)(5660300002)(66946007)(66476007)(31686004)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?V2VhZE9HUlI1RVc1NzNMTUhPWmdTenBYU2toWFhzTDE2NVI0TENUYVBXbnZs?= =?utf-8?B?UUxhRDU5Mm1GMUxDMUdkRkNCM0lBaENIQjY4aWt0UlU2dTM1NGxUVDY3UkNs?= =?utf-8?B?ZG4reUF5MTNqTzd4RUkrZmt4WWVFSWo5RWJTUDY0VHFzSGN2WFk3Z2dEeDVh?= =?utf-8?B?a21kT0VJRWk5MEZiS0FVRENmQlJPZ0xBMXRwMlJOdVFRMjJWMWVINmR3bmRW?= =?utf-8?B?Q2FiQmYyUVlxOThSTnRrR3dRckhOaFRycVErZHVXYkxCdVJEeDZ2T1lDL0lH?= =?utf-8?B?c2k2SlNhQWppMk9GbmI4bzdVcFpUVnp1RWx3OVZmZDBtQVd2TE5WMVNRQWFM?= =?utf-8?B?ZFhKZXpqRnpUQUFJZDQwT2VSZFg0U2RNV3dtbzlOb1h4RU83M3p6aUdOeWtD?= =?utf-8?B?OUVsd2UyYWJzYnFsdmVXZjVrUm5CWFJzeExQcE43TzhxWUhKYmRhb2kyZ2Jk?= =?utf-8?B?aGlaQjJiTlFHZU83M0JZSHlKR0NucDc3UzlUVXpvRytSMDFZSHRjdlQvbS9j?= =?utf-8?B?ajNQTWdSbzhDa3VVSnRkZXBmam83VHY1aWZNSm1MVkZjRi9iZmVoSGJFcmxE?= =?utf-8?B?dUFvUkVkZ08wSUV2eFpkSDNKT3N1eFhzUnl3Q0pvUzVZbDJ2eGhYV3BHREdC?= =?utf-8?B?Y1VOOEJRMWowUnU2ZC9vaUtuQnk4RUs4WnkwNlpXbGZFOVhrUlZnMG8xMHpH?= =?utf-8?B?bGZtOThLVW5Qc1AzMDFXZTNLY21SWUtVbXpLQVpBbzlMYlJJTk9vZ04vb09k?= =?utf-8?B?dGpiNmxxUEZ0NTZpMmJIN1gzT1ZyRncycDE5bGFCWk9vOTJmbXJEaUpqbmg1?= =?utf-8?B?WFVDS0JDSzg2SUlUTldyNTQxdHgzZ2VDbGsyWk5YcktyNktkaG1ZclFmck0z?= =?utf-8?B?RTU1czM3T2M2K3RpT2JLdlNSaU9jeHR1NCt6bTIzOTZmKzNCSW1HRWo4TTRG?= =?utf-8?B?cHlzNnkyYStmMHd1ZVREN2RRUm1yTFhRbnlVbnMySTJ4MSt4NHBDd3c1d3Zp?= =?utf-8?B?L0pETWJnKzkyLzJISXFMS3lKemJrTDIwMDlTbDd5Q1E4RWxIMEcyZngxam1B?= =?utf-8?B?amdJT2RlVDlsUURrSGdsTXVtVzN2VmpxNmV5eVhhNzhLdkFibjhnOWV3WGtx?= =?utf-8?B?L0JVSThONDZHMTdiOWFnWkxEcUtUa3Z3d2tPM2JZOXJ3aW9DaUFYYVNUNDB6?= =?utf-8?B?YXk2N1Y3Q3FWSEJzTnNzYzNPMHNLbFFPWlljd29OTEJBQjMyQk4zbU9sdnpT?= =?utf-8?B?dG82UEc1ZERVZHpTMlZxZS9UalZyWk85bWZJL2ZKOUlUL05oclhuWEZsVmRt?= =?utf-8?B?ckdGU1M4SytvaFF1TE1XUjloRUtCeVNWNDZIeklWVkpXUHVTWHRjUGdjcDkr?= =?utf-8?B?YjRnSWIvdmV4YzMzU1dhV3pLMThRUmkxNFBIaGxzeHpYY1dpeUF0WDhIVFI3?= =?utf-8?B?T0lsQXhzenZyS2dCL1E2b2hMRGFCN2VoK0NDeFoyT0tuTEZhZ0gxTW5iczla?= =?utf-8?B?cWdsdEZmUHJBTW1xT3phaC82VVdoYysvbkM0NUlqRmpGbTQwMkpIUmJlQVRo?= =?utf-8?B?eDZiYVNseWxiS2F4V2FtVFNudTJlOWNQMWxEekZhY2Vzc2crZWJhYnJaK0tv?= =?utf-8?B?c2F4cThteFdobGs2UFZBYVBUTnBUNm5uVTFvdEcxenl6QWJwMDFUb1R1OGF6?= =?utf-8?B?NmhqKzA3Q00vbnNEUXlCMTNwZnl3MzMrSDhZUVNTNU95c3luTkpPdTRSQTh1?= =?utf-8?Q?BwiARIAbiWevYmi7S/czloWfn0GwUD2Ww9YXSeo?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4343 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d1dc8a90-3938-4cb0-3720-08d919491b29 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gTEeOvbBqTJsZ6ARf6V12z7ItlPjv9Ex6T4BGbWB3/GW1uHrBR4AiZZNkIRXSPXn0XSWXtd4pBkYWfyoF/fRLKukFy0cUbnKjAoM2au8t3Ct0BPssktSbumAI+KgsSKCqu0B4IHwcjNKMuH9OQG6uoRRWTaKTooiJkM6WILivtyrgfdCspIMurMR/jAT6YWaCo9T6P1722xv9a/9Vw+bsjDmNg9GSm0vtTyyzTcu5f47TR6zmKgeQzod3eKM180OmPVKy8Y5Yb2yJxFiW6L9msZ3IJ81DmAWyJ6deZE2P8Hby4aAeeYF30mFto9M/Svxv6hUKF7UndQi1sXxQTm680W/LP9RtATJ99eg8Yt6Ib37aOoTROe4q81ASslp6splbCx0Xrme0VGP7QGEknZPwQk0fn8/mTWmfDdbUDdm6cWg6RoNlvekgk7n4XyroQsaLOZ4/kQsw+RCL85nQtQW3/jhgKy0ys844SxdmMP/6d+Dn2uByimmkgpHKegL6ZxY0Em1rb/z8JXXg5GpTwqB4rHtLxvw6BJGGK/vfoJ2UbHabommjD2nIAdQ4TMUxXeQrIErsIv91tz6r/IN/vG/B1AD3dXyJP9xGpNWpFPzCj02RUVjl8jpEpEHKiQvu+fZQWOwA2t6YOLfx8jvOTG14GNFLh3NLydTkhXIQSqATEXZxMRCtBZ8JLd90nD1euaC X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(346002)(396003)(39850400004)(376002)(36840700001)(46966006)(36860700001)(81166007)(44832011)(356005)(36756003)(6486002)(2616005)(956004)(82740400003)(82310400003)(26005)(478600001)(19627235002)(70586007)(70206006)(31696002)(83380400001)(16526019)(186003)(47076005)(8936002)(336012)(16576012)(31686004)(316002)(4326008)(5660300002)(8676002)(2906002)(53546011)(86362001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2021 15:33:38.9247 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6aba58ce-29dc-471c-477a-08d9194924c6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5283 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Pranav, Please find my comments inline marked [SAMI]. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: > Add the SMBIOS type 3 table (System Enclosure) that includes information > about manufacturer, type, serial number and other information related to > system enclosure. > > Signed-off-by: Pranav Madhu > --- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 1 + > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h | 10 ++ > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 1 + > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type3SystemEnclosure.c | 96 ++++++++++++++++++++ > 4 files changed, 108 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > index f7beb1c66c80..b3c1619ddc66 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > @@ -17,6 +17,7 @@ > SmbiosPlatformDxe.c > Type0BiosInformation.c > Type1SystemInformation.c > + Type3SystemEnclosure.c > > [Packages] > ArmPkg/ArmPkg.dec > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > index d7b3aadba948..4a6f8be2a2c2 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > @@ -23,4 +23,14 @@ InstallSystemInformation ( > IN EFI_SMBIOS_PROTOCOL *Smbios > ); > > +EFI_STATUS > +EFIAPI > +InstallSystemEnclosure ( > + IN EFI_SMBIOS_PROTOCOL *Smbios > + ); > + > +enum SMBIOS_REFRENCE_HANDLES { > + SMBIOS_HANDLE_ENCLOSURE = 0x1000, > +}; [SAMI] typedef for enum? > + > #endif // SMBIOS_PLATFORM_DXE_H_ > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > index 7b478063e223..5f4b833dc9fe 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > @@ -28,6 +28,7 @@ STATIC > ARM_RD_SMBIOS_TABLE_INSTALL_FPTR mSmbiosTableList[] = { > &InstallBiosInformation, > &InstallSystemInformation, > + &InstallSystemEnclosure, > }; > > /** > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type3SystemEnclosure.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type3SystemEnclosure.c > new file mode 100644 > index 000000000000..ef0c36d37923 > --- /dev/null > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type3SystemEnclosure.c > @@ -0,0 +1,96 @@ > +/** @file > + SMBIOS Type 3 (System enclosure) table for ARM RD platforms. > + > + This file installs SMBIOS Type 3 (System enclosure) table for Arm Reference > + Design platforms. SMBIOS Type 3 table (System Enclosure) includes information > + about manufacturer, type, serial number and other information related to > + system enclosure. > + > + Copyright (c) 2021, ARM Limited. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > + @par Specification Reference: > + - SMBIOS Reference Specification 3.4.0, Chapter 7.4 > +**/ > + > +#include > +#include > + > +#include "SmbiosPlatformDxe.h" > + > +#define TYPE3_STRINGS \ > + "ARM LTD\0" /* Manufacturer */ \ > + "Version not set\0" /* Version */ \ > + "Serial not set\0" /* Serial */ \ > + "Asset Tag not set\0" /* Asset Tag */ > + > +/* SMBIOS Type3 structure */ > +#pragma pack(1) > +struct ArmRdSmbiosType3 { > + SMBIOS_TABLE_TYPE3 Base; > + UINT8 Strings[sizeof (TYPE3_STRINGS)]; > +}; > +#pragma pack() > + > +/* System information */ > +static struct ArmRdSmbiosType3 mArmRdSmbiosType3 = { > + { > + { > + // SMBIOS header > + EFI_SMBIOS_TYPE_SYSTEM_ENCLOSURE, // Type 3 > + sizeof (SMBIOS_TABLE_TYPE1), // Length > + SMBIOS_HANDLE_ENCLOSURE, // Assign an unused handle number > + }, > + 1, // Manufacturer > + 2, // Enclosure type unknown > + 2, // Version > + 3, // Serial > + 4, // Asset Tag > + ChassisStateSafe, // Boot chassis state > + ChassisStateSafe, // Power supply state > + ChassisStateSafe, // Thermal state > + ChassisSecurityStatusUnknown, // Security Status > + {0}, // BIOS vendor specific Information > + }, > + // Text strings (unformatted) > + TYPE3_STRINGS > +}; > + > +/** > + Install SMBIOS System Enclosure Table > + > + Install the SMBIOS System Enclosure (type 3) table for Arm's Reference Design > + platforms. > + > + @param[in] Smbios SMBIOS protocol. > + > + @retval EFI_SUCCESS Record was added. > + @retval EFI_OUT_OF_RESOURCES Record was not added. > + @retval EFI_ALREADY_STARTED The SmbiosHandle passed in is already in use. > +**/ > +EFI_STATUS > +InstallSystemEnclosure ( > + IN EFI_SMBIOS_PROTOCOL *Smbios > + ) > +{ > + EFI_STATUS Status; > + EFI_SMBIOS_HANDLE SmbiosHandle; > + > + SmbiosHandle = ((EFI_SMBIOS_TABLE_HEADER *)&mArmRdSmbiosType3)->Handle; > + > + /* Install type 3 table */ > + Status = Smbios->Add ( > + Smbios, > + NULL, > + &SmbiosHandle, > + (EFI_SMBIOS_TABLE_HEADER *)&mArmRdSmbiosType3 > + ); > + if (Status != EFI_SUCCESS) { > + DEBUG (( > + DEBUG_ERROR, > + "SMBIOS: Failed to install Type3 SMBIOS table.\n" > + )); > + } > + > + return Status; > +}