From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 69504211A43A3 for ; Fri, 14 Dec 2018 01:54:10 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DB43130016F5; Fri, 14 Dec 2018 09:54:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-97.rdu2.redhat.com [10.10.120.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id B95E6662FE; Fri, 14 Dec 2018 09:54:08 +0000 (UTC) To: Shenglei Zhang , edk2-devel@lists.01.org Cc: Jaben Carsey , Ruiyu Ni References: <20181214075632.29988-1-shenglei.zhang@intel.com> From: Laszlo Ersek Message-ID: <567ce971-8afb-8e29-3843-fd0c2b9f36a1@redhat.com> Date: Fri, 14 Dec 2018 10:54:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181214075632.29988-1-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 14 Dec 2018 09:54:09 +0000 (UTC) Subject: Re: [PATCH v2] ShellPkg/UefiShellDebug1CommandsLib: Remove the unused function CharToUpper X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 09:54:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/14/18 08:56, Shenglei Zhang wrote: > CharToUpper is an unused function, so it will be removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=1399 > > v2:Update the title. > > Cc: Laszlo Ersek > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > .../UefiShellDebug1CommandsLib.c | 28 ------------------- > 1 file changed, 28 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c > index bd4dfa98f7..480441b0f9 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c > @@ -113,34 +113,6 @@ UefiShellDebug1CommandsLibDestructor ( > return (EFI_SUCCESS); > } > > -/** > - Convert a Unicode character to upper case only if > - it maps to a valid small-case ASCII character. > - > - This internal function only deal with Unicode character > - which maps to a valid small-case ASCII character, i.e. > - L'a' to L'z'. For other Unicode character, the input character > - is returned directly. > - > - @param Char The character to convert. > - > - @retval LowerCharacter If the Char is with range L'a' to L'z'. > - @retval Unchanged Otherwise. > - > - > - //Stolen from MdePkg Baselib > -**/ > -CHAR16 > -CharToUpper ( > - IN CHAR16 Char > - ) > -{ > - if (Char >= L'a' && Char <= L'z') { > - return (CHAR16) (Char - (L'a' - L'A')); > - } > - > - return Char; > -} > > /** > Function returns a system configuration table that is stored in the > Reviewed-by: Laszlo Ersek Thanks! Laszlo