public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, osteffen@redhat.com
Cc: Andrew Fish <afish@apple.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Bob Feng <bob.c.feng@intel.com>,
	Daniel Schaefer <git@danielschaefer.me>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Sunil V L <sunilvl@ventanamicro.com>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Chris Fernald <chfernal@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v10 04/17] OvmfPkg: CI: use Python version from defaults template
Date: Thu, 1 Dec 2022 15:42:03 -0500	[thread overview]
Message-ID: <56865994-d6cd-47fb-b9a4-b25df9b73c30@linux.microsoft.com> (raw)
In-Reply-To: <CA+bRGFotNZwQtLLWwftMs-HZnNyeSpAEHXXtevk9W2CDKjM5-A@mail.gmail.com>

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 12/1/2022 3:28 PM, Oliver Steffen wrote:
> Use the default Python version from the defaults template
> (.azurepipelines/templates/defaults.yml) in the Windows and
> Linux CI jobs.
> 
> Previous changes to the CI job templates make it necessary
> to specify a version number, if Python shall be pulled
> at CI runtime.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>   OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml    | 4 ++++
>   OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 5 +++++
>   2 files changed, 9 insertions(+)
> 
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 7160d95f7e04..6dd90711ac70 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -15,6 +15,9 @@ pr:
>     - master
>     - stable/*
> 
> +variables:
> +  - template: ../../../.azurepipelines/templates/defaults.yml
> +
>   jobs:
>     - job: Platform_CI
>       variables:
> @@ -187,6 +190,7 @@ jobs:
>           build_file: $(Build.File)
>           build_flags: $(Build.Flags)
>           run_flags: $(Run.Flags)
> +        usePythonVersion: ${{ variables.default_python_version }}
>           extra_install_step:
>           - bash: sudo apt-get install qemu
>             displayName: Install qemu
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> index 7d6344d6383d..7e63f419b26b 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> @@ -14,6 +14,10 @@ trigger:
>   pr:
>     - master
>     - stable/*
> +
> +variables:
> +  - template: ../../../.azurepipelines/templates/defaults.yml
> +
>   jobs:
>     - job: Platform_CI
>       variables:
> @@ -133,6 +137,7 @@ jobs:
>           build_file: $(Build.File)
>           build_flags: $(Build.Flags)
>           run_flags: $(Run.Flags)
> +        usePythonVersion: ${{ variables.default_python_version }}
>           extra_install_step:
>           - powershell: choco install qemu --version=2021.5.5;
> Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
>             displayName: Install QEMU and Set QEMU on path # friendly
> name displayed in the UI

  reply	other threads:[~2022-12-01 20:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221201202810.109662-1-osteffen@redhat.com>
2022-12-01 20:28 ` [PATCH v10 01/17] CI: make Python version configurable Oliver Steffen
2022-12-01 20:41   ` [edk2-devel] " Michael Kubacki
2022-12-01 20:28 ` [PATCH v10 02/17] ArmVirtPkg: CI: use Python version from defaults template Oliver Steffen
2022-12-01 20:41   ` [edk2-devel] " Michael Kubacki
2022-12-01 20:28 ` [PATCH v10 03/17] EmulatorPkg: " Oliver Steffen
2022-12-01 20:41   ` [edk2-devel] " Michael Kubacki
2022-12-01 20:28 ` [PATCH v10 04/17] OvmfPkg: " Oliver Steffen
2022-12-01 20:42   ` Michael Kubacki [this message]
2022-12-01 20:28 ` [PATCH v10 05/17] CI: add ~/.local/bin to PATH (Linux only) Oliver Steffen
2022-12-01 20:28 ` [PATCH v10 06/17] CI: Allow running in a container Oliver Steffen
2022-12-01 20:28 ` [PATCH v10 07/17] CI: Use Fedora 35 container (Linux only) Oliver Steffen
2022-12-02 19:31   ` [edk2-devel] " Michael Kubacki
2022-12-01 20:28 ` [PATCH v10 08/17] ArmVirtPkg: " Oliver Steffen
2022-12-01 20:42   ` [edk2-devel] " Michael Kubacki
2022-12-01 20:28 ` [PATCH v10 09/17] EmulatorPkg: " Oliver Steffen
2022-12-01 20:43   ` [edk2-devel] " Michael Kubacki
2022-12-01 20:28 ` [PATCH v10 10/17] OvmfPkg: " Oliver Steffen
2022-12-01 20:43   ` [edk2-devel] " Michael Kubacki
2022-12-01 20:28 ` [PATCH v10 11/17] .pytool: CISettings.py: don't add scopes for GCC Oliver Steffen
2022-12-01 20:28 ` [PATCH v10 12/17] BaseTools: remove ext_dep files for gcc Oliver Steffen
2022-12-01 20:44   ` [edk2-devel] " Michael Kubacki
2022-12-01 20:28 ` [PATCH v10 13/17] ArmVirtPkg: CI: use ubuntu-22.04 vm_image (Linux only) Oliver Steffen
2022-12-01 20:28 ` [PATCH v10 14/17] EmulatorPgk: " Oliver Steffen
2022-12-01 20:28 ` [PATCH v10 15/17] OvmfPkg: " Oliver Steffen
2022-12-01 20:28 ` [PATCH v10 16/17] CI: use ubuntu-22.04 image " Oliver Steffen
2022-12-01 20:44   ` Michael Kubacki
2022-12-01 20:28 ` [PATCH v10 17/17] do not merge: modify *.dsc to trigger CI Oliver Steffen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56865994-d6cd-47fb-b9a4-b25df9b73c30@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox