From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web11.56649.1669927326573087181
 for <devel@edk2.groups.io>;
 Thu, 01 Dec 2022 12:42:06 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=m0W7sT1O;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id ED47F20B83C2;
	Thu,  1 Dec 2022 12:42:03 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ED47F20B83C2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1669927326;
	bh=z9w3wIGcyIAEhDjd0kCNZcb5oDyIE2917WVVRtJuofE=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=m0W7sT1OX8OrwkaGDTdgJcQTXMcbGc5xDG+nfSd7PJUl9OjMLInMDK46Q1ydxeeMp
	 uI069Ov7UecPIJoz5jRculT2dvVdhjJvAfnXkUKuyRqggPfNE2MibPidv3129ZFw1S
	 ckQ7c4ySzze8PtZ/3l2J5cZOFjlx38MsxT/BAzeE=
Message-ID: <56865994-d6cd-47fb-b9a4-b25df9b73c30@linux.microsoft.com>
Date: Thu, 1 Dec 2022 15:42:03 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [edk2-devel] [PATCH v10 04/17] OvmfPkg: CI: use Python version from defaults template
To: devel@edk2.groups.io, osteffen@redhat.com
Cc: Andrew Fish <afish@apple.com>, Ard Biesheuvel
 <ardb+tianocore@kernel.org>, Bob Feng <bob.c.feng@intel.com>,
 Daniel Schaefer <git@danielschaefer.me>, Gerd Hoffmann <kraxel@redhat.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen
 <jordan.l.justen@intel.com>, Leif Lindholm <quic_llindhol@quicinc.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>, Ray Ni <ray.ni@intel.com>,
 Sami Mujawar <sami.mujawar@arm.com>, Sean Brogan
 <sean.brogan@microsoft.com>, Sunil V L <sunilvl@ventanamicro.com>,
 Yuwei Chen <yuwei.chen@intel.com>, Zhiguang Liu <zhiguang.liu@intel.com>,
 Pawel Polawski <ppolawsk@redhat.com>, Chris Fernald <chfernal@microsoft.com>
References: <20221201202810.109662-1-osteffen@redhat.com>
 <CA+bRGFotNZwQtLLWwftMs-HZnNyeSpAEHXXtevk9W2CDKjM5-A@mail.gmail.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <CA+bRGFotNZwQtLLWwftMs-HZnNyeSpAEHXXtevk9W2CDKjM5-A@mail.gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 12/1/2022 3:28 PM, Oliver Steffen wrote:
> Use the default Python version from the defaults template
> (.azurepipelines/templates/defaults.yml) in the Windows and
> Linux CI jobs.
> 
> Previous changes to the CI job templates make it necessary
> to specify a version number, if Python shall be pulled
> at CI runtime.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>   OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml    | 4 ++++
>   OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 5 +++++
>   2 files changed, 9 insertions(+)
> 
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 7160d95f7e04..6dd90711ac70 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -15,6 +15,9 @@ pr:
>     - master
>     - stable/*
> 
> +variables:
> +  - template: ../../../.azurepipelines/templates/defaults.yml
> +
>   jobs:
>     - job: Platform_CI
>       variables:
> @@ -187,6 +190,7 @@ jobs:
>           build_file: $(Build.File)
>           build_flags: $(Build.Flags)
>           run_flags: $(Run.Flags)
> +        usePythonVersion: ${{ variables.default_python_version }}
>           extra_install_step:
>           - bash: sudo apt-get install qemu
>             displayName: Install qemu
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> index 7d6344d6383d..7e63f419b26b 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> @@ -14,6 +14,10 @@ trigger:
>   pr:
>     - master
>     - stable/*
> +
> +variables:
> +  - template: ../../../.azurepipelines/templates/defaults.yml
> +
>   jobs:
>     - job: Platform_CI
>       variables:
> @@ -133,6 +137,7 @@ jobs:
>           build_file: $(Build.File)
>           build_flags: $(Build.Flags)
>           run_flags: $(Run.Flags)
> +        usePythonVersion: ${{ variables.default_python_version }}
>           extra_install_step:
>           - powershell: choco install qemu --version=2021.5.5;
> Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
>             displayName: Install QEMU and Set QEMU on path # friendly
> name displayed in the UI