[PATCH v1 0/2] DynamicTablesPkg: Build option updates

[PATCH v1 0/2] DynamicTablesPkg: Build option updates

[Sami Mujawar]

This patch series updates the build options for DynamicTablesPkg to
reflect the recent Basetools updates done to facilitate the generation
of C file containing AML data using the AmlToC script. This change
removes the dependency on iASL compiler options. 

The second patch in this series adds the MDEPKG_NDEBUG flag to release
builds.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/851_dynamictables_build_options_v1

Pierre Gondois (1):
  DynamicTablesPkg: Update ASL build options

Sami Mujawar (1):
  DynamicTablesPkg: Update release build flags

 DynamicTablesPkg/DynamicTables.dsc.inc |  4 +--
 DynamicTablesPkg/Readme.md             | 29 ++------------------
 2 files changed, 5 insertions(+), 28 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH v1 1/2] DynamicTablesPkg: Update ASL build options

[Sami Mujawar]

From: Pierre Gondois <pierre.gondois@arm.com>

The EdkII BaseTools have been updated to facilitate the
generation of C file containing AML data using the AmlToC
script. The build system follows the following sequence
for an ASL file compilation:
 - The ASL file is preprocessed using the C preprocessor
 - The Trim utility prunes the preprocessed file to removed
   unwanted data.
 - This file is compiled using an ASL compiler to generate
   an AML file.
 - The AmlToC python script reads the AML data and generates
   a C file with an array containing the AML data.
 - This C file containing a unique symbol name for the AML
   data array is then compiled with the firmware module.

This removes the dependency on the ACPICA iASL compiler's
"-tc" option which achieved the same effect but was less
portable. Therefore, remove the "-tc" option from the ASL
flags as this option is only been supported by the ACPICA
iASL compiler.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 DynamicTablesPkg/DynamicTables.dsc.inc |  3 +-
 DynamicTablesPkg/Readme.md             | 29 ++------------------
 2 files changed, 4 insertions(+), 28 deletions(-)

diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/DynamicTables.dsc.inc
index 0bf7a77cf2dcf82135f52a834774769bb06ba21a..d15b74884f0b618e427ac8c6804c50b4746ea602 100644
--- a/DynamicTablesPkg/DynamicTables.dsc.inc
+++ b/DynamicTablesPkg/DynamicTables.dsc.inc
@@ -1,7 +1,7 @@
 ## @file
 #  Dsc include file for Dynamic Tables Framework.
 #
-#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.<BR>
+#  Copyright (c) 2017 - 2020, Arm Limited. All rights reserved.<BR>
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -10,7 +10,6 @@
 [Defines]
 
 [BuildOptions]
-  *_*_*_ASL_FLAGS          = -tc -li -so
 
 [LibraryClasses.common]
   TableHelperLib|DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf
diff --git a/DynamicTablesPkg/Readme.md b/DynamicTablesPkg/Readme.md
index 93fd1f313aa5227df5c1ccc82dfe17cb4c8f9e0a..da900146d3df35d98f417f0846c614ec9af09941 100644
--- a/DynamicTablesPkg/Readme.md
+++ b/DynamicTablesPkg/Readme.md
@@ -68,22 +68,6 @@ information file is planned.
 Also support for generating SMBIOS tables is planned and will be added
 subsequently.
 
-Related Modules
----------------
-
-### ACPICA iASL compiler
-The RAW table generator, used to process the DSDT/SSDT files depends on
-the iASL compiler to convert the DSDT/SSDT ASL files to a C array containing
-the hex AML code. The "-tc" option of the iASL compiler has been enhanced to
-support generation of an AML hex file (C header) with a unique symbol name
-so that it is suitable for inclusion from a C source file.
-
-Related Links
---------------
-
-<https://github.com/acpica/acpica.git>
-
-
 Supported Platforms
 -------------------
 1. Juno
@@ -120,16 +104,9 @@ or
 
 Prerequisites
 -------------
-ACPICA iASL compiler with the enhanced "-tc" option to support generation of
-AML hex (C header) files with unique symbol names.
-
-A patch *'[iASL: Enhance the -tc option (create AML hex file in C)](https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37)'*, dated 16 March 2018 (2018-03-16),
-to enable this support has been integrated to the ACPICA source repository.
-
-Ensure that the iASL compiler used for building *Dynamic Tables Framework* has this feature enabled.
-
-This feature was made available in the *ACPICA Compiler update
-[Version 20180508](https://www.acpica.org/node/156)*, dated 8 May 2018 (2018-05-08).
+Ensure that the latest ACPICA iASL compiler is used for building *Dynamic Tables Framework*.
+*Dynamic Tables Framework* has been tested using the following iASL compiler version:
+[Version 20200717](https://www.acpica.org/node/183)*, dated 17 July, 2020.
 
 Documentation
 -------------
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: Update ASL build options

[Alexei Fedorov]

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>

[-- Attachment #2: Type: text/html, Size: 60 bytes --]

[PATCH v1 2/2] DynamicTablesPkg: Update release build flags

[Sami Mujawar]

If MDEPKG_NDEBUG is defined, then debug and assert related
macros wrapped by it are mapped to NULL implementations.
Therefore, add MDEPKG_NDEBUG flags for release builds of
DynamicTablesPkg.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 DynamicTablesPkg/DynamicTables.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/DynamicTables.dsc.inc
index d15b74884f0b618e427ac8c6804c50b4746ea602..df64e1dc4cd7ce0b68037ef544fbde1c435e43e3 100644
--- a/DynamicTablesPkg/DynamicTables.dsc.inc
+++ b/DynamicTablesPkg/DynamicTables.dsc.inc
@@ -10,6 +10,7 @@
 [Defines]
 
 [BuildOptions]
+  RELEASE_*_*_CC_FLAGS     = -DMDEPKG_NDEBUG
 
 [LibraryClasses.common]
   TableHelperLib|DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [edk2-devel] [PATCH v1 2/2] DynamicTablesPkg: Update release build flags

[Alexei Fedorov]

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>

[-- Attachment #2: Type: text/html, Size: 60 bytes --]

Re: [edk2-devel] [PATCH v1 0/2] DynamicTablesPkg: Build option updates

[Alexei Fedorov]

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>

[-- Attachment #2: Type: text/html, Size: 60 bytes --]