From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9DFF6222CF1D2 for ; Wed, 10 Jan 2018 10:16:56 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D6FE7653E6; Wed, 10 Jan 2018 18:22:07 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-123-164.rdu2.redhat.com [10.10.123.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id B51C381213; Wed, 10 Jan 2018 18:22:03 +0000 (UTC) To: Liming Gao , edk2-devel@lists.01.org Cc: Andrew Fish References: <20180110152432.15964-1-liming.gao@intel.com> <20180110152432.15964-8-liming.gao@intel.com> From: Laszlo Ersek Message-ID: <568d7bf9-2928-5a64-c772-9582f8e41ad9@redhat.com> Date: Wed, 10 Jan 2018 19:22:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180110152432.15964-8-liming.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 10 Jan 2018 18:22:08 +0000 (UTC) Subject: Re: [Patch 7/7] OvmfPkg: Don't add -mno-mmx -mno-sse option for XCODE5 tool chain X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 18:16:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01/10/18 16:24, Liming Gao wrote: > Ovmf appended option -mno-mmx -mno-sse, but these two options were enabled > in Openssl. The compiler option becomes -mmmx –msse -mno-mmx -mno-sse. It > trig mac clang compiler hang when compile one source file in openssl. > This issue is found when SECURE_BOOT_ENABLE is TRUE. This may be the compiler > issue. To work around it, don't add these two options for XCODE5 tool chain. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Andrew Fish > Cc: Laszlo Ersek > --- > OvmfPkg/OvmfPkgIa32.dsc | 4 +++- > OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++- > OvmfPkg/OvmfPkgX64.dsc | 4 +++- > 3 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 9d23f8c162..d762955c5d 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -1,7 +1,7 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # > # This program and the accompanying materials > @@ -64,7 +64,9 @@ > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > +!if $(TOOL_CHAIN_TAG) != "XCODE5" > GCC:*_*_*_CC_FLAGS = -mno-mmx -mno-sse > +!endif > > # > # Disable deprecated APIs. > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index a9c667fed8..6bcbe70d64 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -1,7 +1,7 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # > # This program and the accompanying materials > @@ -64,7 +64,9 @@ > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > +!if $(TOOL_CHAIN_TAG) != "XCODE5" > GCC:*_*_*_CC_FLAGS = -mno-mmx -mno-sse > +!endif > !ifdef $(SOURCE_DEBUG_ENABLE) > MSFT:*_*_X64_GENFW_FLAGS = --keepexceptiontable > GCC:*_*_X64_GENFW_FLAGS = --keepexceptiontable > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index abf570512a..70fcdcba11 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -1,7 +1,7 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # > # This program and the accompanying materials > @@ -64,7 +64,9 @@ > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > +!if $(TOOL_CHAIN_TAG) != "XCODE5" > GCC:*_*_*_CC_FLAGS = -mno-mmx -mno-sse > +!endif > !ifdef $(SOURCE_DEBUG_ENABLE) > MSFT:*_*_X64_GENFW_FLAGS = --keepexceptiontable > GCC:*_*_X64_GENFW_FLAGS = --keepexceptiontable > Reviewed-by: Laszlo Ersek