From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.54]) by mx.groups.io with SMTP id smtpd.web11.24097.1659954931146446707 for ; Mon, 08 Aug 2022 03:35:32 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=b2PX3NhW; spf=pass (domain: arm.com, ip: 40.107.21.54, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=oNUkwYAy5YYR+Jd1FgJeO2W6VWPqVQiivlzRZWerqtgSmLh+SqA9HETotyX/SztKV4rk9cSbGJc8xGQ0QRo0tAFWsbiXtyXYHGJ1mCYhRyg7rh48MGhqFnAuVotyg8IAqwyJuc1WdVG6zRYWRKz4H8AyUuacEmFJPyClwX6PdUcCSinRQwHtvoqAoJERkHXJ+d9/HUPo2/NI+oBZcEITlh74aAAO3k62X6ZOHp4Bd3/9eJVlj8nkT8bf4RSjMd0cPI3xXrphrnOf5uTPxKQ8ZuBJpekOh1JuV8ui4f866LWcs0bRKCT7EaH92LFTSkIFBWpH+VnsqPhns0Jt2Pkayw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YbHc1Utv/1M3TTf5mRwUrwz1XFEuZ+XKQiyLoIR2mls=; b=BTX/vdrUHr6nGzUWPKn/keLc2omR3m1c3rX+WWzBaSsvH958jcKvtCpRaHh8X/9wZb427c/cdxV07emP5NothujYplRrh7rXHqMObFAdwiScry3SNkuFIxpoTTvvl74QKc9Ah0faQE/L1rvAzKtXrpeVmW+djPn5gk6t8i1HneGlNKnNWtgKDYugTy5CkYabPIAETgvQUmLWNAiaxB1nqPND+CLpoU48WM3QXgFIjLmkCZHd3fGMLD9guu/yABAvzOywjDY+IFJ2tq+dsscWe/v2Wo/lqfLpzPeQoxr/DjonqpgxDpXDWK+guHwHiu87mHe0RPrpgp33q9XCyO2vAw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YbHc1Utv/1M3TTf5mRwUrwz1XFEuZ+XKQiyLoIR2mls=; b=b2PX3NhW0L0fSA2S+qJYPFAYrbDk0YHYhP8swpon3ir8MVNZ7NtbUREqq+tVNDc6b8aYZ2fxOX8BpxTgT06P5XEMr28J+IAI4+zNwU8lRpMfOxWZrsgYabsubERYCl4Je8g0NyU5Dpja0RuHK/MWSu1Yf5PoBH5j1vE20JwkxeY= Received: from FR0P281CA0101.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::19) by VE1PR08MB5792.eurprd08.prod.outlook.com (2603:10a6:800:1a6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Mon, 8 Aug 2022 10:35:26 +0000 Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a9:cafe::b5) by FR0P281CA0101.outlook.office365.com (2603:10a6:d10:a9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.7 via Frontend Transport; Mon, 8 Aug 2022 10:35:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16 via Frontend Transport; Mon, 8 Aug 2022 10:35:25 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Mon, 08 Aug 2022 10:35:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ad8bb5f51f9ba5a0 X-CR-MTA-TID: 64aa7808 Received: from 9b8e28f81d0a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D066B368-B799-453D-B41C-A4873607A21D.1; Mon, 08 Aug 2022 10:35:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9b8e28f81d0a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 08 Aug 2022 10:35:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7l6NTrAsTTSx1izX88AuwtAIWFnq/fl49MJP4Ldmzn2YEPdelSIr87J81bnM/OhMzDjO84eAGaPCosPq9vL7Dgv6JH4KR9tE+TaAo5O+eK/MUfsdNu1dCzNrPb5wZPOB9GZv4pr5Uso6IRK2NONfgpzT/CmSfiQBhfmDEWkAbOJfD/r+WFfljRVKKXu85/s1cN0fdD5rr1ROFLF9r+bOPWLYibGVNX/10ZtaOdRUBTyWetNhSPIUGTv1mkU0I0OGbCgIeH7xdiSlfMVuQgEmQEsuuwMFJVhLY2fmvY9tWv1znJZ81wd3C8ypD3W+4mkHPPgHZR6y9AiQPmfOO5YeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YbHc1Utv/1M3TTf5mRwUrwz1XFEuZ+XKQiyLoIR2mls=; b=GtOxa5WNvTYnQuWIozmzAQ6J8H4uvsD2Fay+RrPTuriT60gP3cDeTEKDJclsUQSiWroxB2rgGXVruf7WX2facsp0Mqn9KH6IQjmnRUY16S23OdQAXMiEIM1hE7rcUuXZOLb6YJaeb068l+mv2yTm6dS7FdUhvht1ilvoTEZNYrOM0Duc9n9v31OzFloTjZYyikIeKgdavEniGJ/nA6l3di2LXpWIqCGCBf97rRlZn07u03Way110pEaksIemOuZqUAqDP7b2dhl58IgTsQAdF68dB6YojtxhfMf4qmy1FVtN5KLd5+B4Yu9RGoRPTCmw9W+MsHUc8ZomkqChQycLPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YbHc1Utv/1M3TTf5mRwUrwz1XFEuZ+XKQiyLoIR2mls=; b=b2PX3NhW0L0fSA2S+qJYPFAYrbDk0YHYhP8swpon3ir8MVNZ7NtbUREqq+tVNDc6b8aYZ2fxOX8BpxTgT06P5XEMr28J+IAI4+zNwU8lRpMfOxWZrsgYabsubERYCl4Je8g0NyU5Dpja0RuHK/MWSu1Yf5PoBH5j1vE20JwkxeY= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAXPR08MB6831.eurprd08.prod.outlook.com (2603:10a6:102:139::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15; Mon, 8 Aug 2022 10:35:12 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%4]) with mapi id 15.20.5504.020; Mon, 8 Aug 2022 10:35:12 +0000 Message-ID: <569735e2-394f-7be0-1530-40f8a2caacf3@arm.com> Date: Mon, 8 Aug 2022 11:35:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 0/5] Add support to build PRM for AARCH64 using GCC To: Michael Kubacki , devel@edk2.groups.io CC: ardb+tianocore@kernel.org, nathaniel.l.desimone@intel.com, ankit.sinha@intel.com, npham@amperecomputing.com, loc.ho@amperecomputing.com, jose.marinho@arm.com, Samer.El-Haj-Mahmoud@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20220803143547.27772-1-sami.mujawar@arm.com> From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO6P265CA0017.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::8) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 79582a06-bcc8-49a5-32e6-08da7929b4d9 X-MS-TrafficTypeDiagnostic: PAXPR08MB6831:EE_|VE1EUR03FT029:EE_|VE1PR08MB5792:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7FM9XrSe+hNWdn9VZtsnPyoSBOOltVfNOhcRRlLtCHKBFiW5mIIoWQ9yuJTwyilGtGtV374kdTTvTeHN3pbjP+Lpnpjx7tVqZzr8SUSu6mNagT1+2M3wQz5ECON4QO19RHMhMQ1WZ5UiZtC0D0Vhnj0hPa0jAbsF2XuWb2MSDre2eQqbZjM/kA6FvYdzvYGLA3J5HQ9gFTA0Woh7mPIR57ix/1vhWnWSOUiJbOGVrfZk/Ex1tInoOLEfEJ7h+KWwzSnlKyOsmiPsvBA6Jw4YWlFmGUvqCkXiwgHhLvfFrvVhU6+1yKCdVKhRaO+enuV+9P03l1hyD19iqURTM0Epq9WS3atKeEwBxXQ69VLRJjSXh1s58gmPNQVBfA7whe4HWDKiKicqziKSMhjCB/isvbXfrUObp4fOWeydcpN/XwYAhfzdnMgSW55v4/EEe2f5X+V4snltLYsP48ZRl4W+ODPqmhfwb172RBDLC/an+KlKnAIQKGo7o+B6kmzVCRQLU2GkYElSu4mLFZVZEL+CtDKOflcjviu9LTxJ23UdGFRLfDDpaGQPbOb+rt+oLn7wm0HuDAVRrMVVwkjLMTHgGSOzkcXXmPtJUYrK15KzKd40pXfGx9mxQTJB8qTdBfUPS193hiPQzuuJG0WewP0J1hRQ9u99UW7NVDPry0JIVDklbpA7PGUBfeBI+uM+VUuSYlm7xB/Oktet/2bn2DAssN9wx3TTdJ+0C+oSO7VEj5FmUxleV7UVMNdmtkaf0ebGgWvH7bBVYow6QXwzGpNtSJERmgQ2svdyQ1YqxJUnRyhO6jfsvncUBl/qeoKZIPGiB9cXogwCOR9hUi75bcLy5OGsyMdmJV12JPvyoO0FbO+qxvNQTdOBnNCtN8wg14r4TQ6ikrbkAJj/yRNVevTaOwKIVSHmSOnL7slYgaGB2UY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(19627235002)(31686004)(86362001)(4326008)(6486002)(966005)(316002)(45080400002)(8676002)(66946007)(66476007)(66556008)(8936002)(36756003)(5660300002)(478600001)(31696002)(41300700001)(44832011)(26005)(6512007)(6506007)(83380400001)(53546011)(2906002)(38100700002)(2616005)(186003)(43740500002)(45980500001)(460985005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6831 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 642999db-6629-4b1a-d41d-08da7929ac8b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RveWLJ9ck0NFUrZuO8spVem1m594ZVI0/GhGGl9inDuubcGHjo50wnDWCCGN3jhWVBkGd+0XQFCax3xlXDHZ6CHRAG3iOBSB7/ik+PesdPMXog/PBG0DHCIvHkZbd/F7S+gw52mIEMUREtR/c46APNvyYWT4qOuSAZFT3JK59bhX3F3qZ1QwNP+MGhg0nCD/LWPU7nZijngc3zXZW5Og9Q51LJ49vd8Q2SqGgmNYm8vZ9N5ReFlr2JTeJJ0wzpoYrsF/H6hQc4zaWhXncLiul66o83giwww1/iB1e5eQ2tW9ZpleqZbhxrLh1cAbPdlUzoX6xgQsfEi05sx5DFAW4gz3u+UV59nPdK9PBk7yPcRsWP0sRNC9myTgRfcBm3GlUok3rCCnC96gbK4DCE/RHk+DxUrDkSIWPkI125Mao5jOh3jsrRWlSixlzjrIbF4o1o9by5N03eZ/B4AXJu8T9FGiSSddfIa0q227Ne4+NZZi1Ij4JS+vfsM+ZNqRODZeVblpt1DHc8i2szFtyou5vrmKLV44EEUvXs5KmYRKC0SlOUt0gDdUc+fkKYokhmyAwV2zuK93c3aaWSPBIAMvCwT0ARVJLr+CnqVzRyk44crTnJkBtqDvePtwltVn3LWxdDJ95T9UWZGPvXy+6LKPv+6L7lMVFDCDbTwVljQaVihq/RqRm0PqPXoZcdFNM4DYa9OIHpOPSSjPuEDVcUcwAZ6At5MtyFcx6ylZoN0+qiS88fIoTPOpNCkIT1k8q9vOLYFTlOMH6x55SXKzqrcK3tAqKtVtbDpP/eokupJcUiEeYK7kYVBMcFeak/MpslyfVHXA+Z71w/2LG8uQehCXXI3wSbvo8CP7zJgOAIk4YNKb6sBJP6B659FZlnrheC3ewWCC9YPTdbkKSnHTVLaVdSwJTjrUiv7bcy76s7hV9h/Ia4loA2w7OYxB6oFtqj5i X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(376002)(39850400004)(46966006)(36840700001)(40470700004)(316002)(19627235002)(70586007)(70206006)(8676002)(4326008)(40480700001)(82310400005)(40460700003)(44832011)(8936002)(5660300002)(2906002)(36860700001)(356005)(82740400003)(81166007)(31696002)(86362001)(478600001)(36756003)(6512007)(53546011)(26005)(41300700001)(6506007)(45080400002)(966005)(6486002)(83380400001)(2616005)(186003)(336012)(47076005)(31686004)(43740500002)(460985005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2022 10:35:25.9916 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79582a06-bcc8-49a5-32e6-08da7929b4d9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5792 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Michael, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 04/08/2022 05:09 am, Michael Kubacki wrote: > For the series: Reviewed-by: Michael Kubacki=20 > > > The patch formatting seems a little strange: > > 1. The patches don't have "Cc" lines. > [SAMI] I have not been following the convention to add Cc lines to the=20 patches. However, I will start from the next patch series. > 2. What is this GUID message at the bottom of each patch? > > =C2=A0=C2=A0 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' [SAMI] I have added this so that I can easily search my patches. It does=20 not affect the patch though. > > By the way, I tested the AARCH64 PRM build with sample modules on=20 > VS2019 a while back, so I see that you mentioned only testing GCC=20 > (thanks for helping get the functions in the export table there) but=20 > it should work in VS as well. [SAMI] I have tried building PrmPkg with VS2019 and found that the=20 AARCH64 builds do not work. =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "C:\Program Files (x86)\Microso= ft Visual=20 Studio\2019\Professional\VC\Tools\MSVC\14.28.29910\bin\Hostx86\arm64\armasm= 64.exe"=20 /Fow:\edk2-exports\Build\Prm\DEBUG_VS2019\AARCH64\MdePkg\Library\BaseMemory= LibOptDxe\BaseMemoryLibOptDxe\OUTPUT\AArch64\CompareGuid.obj=20 /nologo /g=20 /Iw:\edk2-exports\edk2\MdePkg\Library\BaseMemoryLibOptDxe\AArch64=20 /Iw:\edk2-exports\edk2\MdePkg\Library\BaseMemoryLibOptDxe\Arm=20 /Iw:\edk2-exports\edk2\MdePkg\Library\BaseMemoryLibOptDxe\AArch64=20 /Iw:\edk2-exports\edk2\MdePkg\Library\BaseMemoryLibOptDxe=20 /Iw:\edk2-exports\Build\Prm\DEBUG_VS2019\AARCH64\MdePkg\Library\BaseMemoryL= ibOptDxe\BaseMemoryLibOptDxe\DEBUG=20 /Iw:\edk2-exports\edk2\MdePkg /Iw:\edk2-exports\edk2\MdePkg\Include=20 /Iw:\edk2-exports\edk2\MdePkg\Test\UnitTest\Include=20 /Iw:\edk2-exports\edk2\MdePkg\Include\AArch64=20 w:\edk2-exports\Build\Prm\DEBUG_VS2019\AARCH64\MdePkg\Library\BaseMemoryLib= OptDxe\BaseMemoryLibOptDxe\OUTPUT\AArch64\CompareGuid.iiii w:\edk2-exports\Build\Prm\DEBUG_VS2019\AARCH64\MdePkg\Library\BaseMemoryLib= OptDxe\BaseMemoryLibOptDxe\OUTPUT\AArch64\CompareGuid.iiii(7)=20 : error A2034: unknown opcode: . =C2=A0=C2=A0=C2=A0 .text w:\edk2-exports\Build\Prm\DEBUG_VS2019\AARCH64\MdePkg\Library\BaseMemoryLib= OptDxe\BaseMemoryLibOptDxe\OUTPUT\AArch64\CompareGuid.iiii(8)=20 : error A2034: unknown opcode: . =C2=A0=C2=A0=C2=A0 .align=C2=A0 5 w:\edk2-exports\Build\Prm\DEBUG_VS2019\AARCH64\MdePkg\Library\BaseMemoryLib= OptDxe\BaseMemoryLibOptDxe\OUTPUT\AArch64\CompareGuid.iiii(9)=20 : error A2034: unknown opcode: InternalMemCompareGuid ASM_GLOBAL InternalMemCompareGuid w:\edk2-exports\Build\Prm\DEBUG_VS2019\AARCH64\MdePkg\Library\BaseMemoryLib= OptDxe\BaseMemoryLibOptDxe\OUTPUT\AArch64\CompareGuid.iiii(13)=20 : error A2173: syntax error in expression =C2=A0=C2=A0=C2=A0 cbz=C2=A0=C2=A0=C2=A0=C2=A0 x1, 0f w:\edk2-exports\Build\Prm\DEBUG_VS2019\AARCH64\MdePkg\Library\BaseMemoryLib= OptDxe\BaseMemoryLibOptDxe\OUTPUT\AArch64\CompareGuid.iiii(19)=20 : warning A4045: missing END directive =C2=A0=C2=A0=C2=A0 ret NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual=20 Studio\2019\Professional\VC\Tools\MSVC\14.28.29910\bin\Hostx86\arm64\armasm= 64.exe"'=20 : return code '0x1' Stop. Can you please let me know if this is a configuration/environment issue=20 or the AARCH64 assembly files need to be ported for Visual Studio? I have tried building other Arm packages and though the assembler files=20 need porting, which I believe has been done as part of ProjectMu=20 (https://github.com/microsoft/mu_silicon_arm_tiano). It would be good to have AARCH64 builds of edk2 with Visual Studio as=20 this would allow to use the VS static analysis tool. Can you let me know if you have any plans to enable this support in=20 Tianocore\edk2 project, please? [/SAMI] > Regards, > Michael > > On 8/3/2022 10:35 AM, Sami Mujawar wrote: >> This patch series adds support to build PRM for AARCH64 using GCC. >> >> The changes can be seen at: >> https://github.com/samimujawar/edk2/tree/2238_aarch64_prm_support_v1 >> >> Jose Marinho (5): >> =C2=A0=C2=A0 Basetools/GenFw: Allow AARCH64 builds to use the --prm flag >> =C2=A0=C2=A0 PrmPkg: Enable external visibility on PRM symbols >> =C2=A0=C2=A0 PrmPkg: Build Prm Samples with GCC for AARCH64 >> =C2=A0=C2=A0 PrmPkg: Support AArch64 builds using GCC >> =C2=A0=C2=A0 PrmPkg: Add details on AArch64 build to the Readme. >> >> BaseTools/Source/C/GenFw/Elf64Convert.c |=C2=A0 6 ++--- >> PrmPkg/Include/Prm.h |=C2=A0 3 +++ >> PrmPkg/PrmPkg.ci.yaml |=C2=A0 1 + >> PrmPkg/PrmPkg.dsc | 24 +++++++++++++++++--- >> PrmPkg/Readme.md | 11 +++++++++ >> PrmPkg/Samples/PrmSampleAcpiParameterBufferModule/PrmSampleAcpiParameter= BufferModule.inf=20 >> |=C2=A0 4 ++++ >> PrmPkg/Samples/PrmSampleContextBufferModule/PrmSampleContextBufferModule= .inf=20 >> |=C2=A0 4 ++++ >> =C2=A0 7 files changed, 47 insertions(+), 6 deletions(-) >>