From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.29036.1673455327812709988
 for <devel@edk2.groups.io>;
 Wed, 11 Jan 2023 08:42:07 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: patrik.berglund@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EFBFEFEC;
	Wed, 11 Jan 2023 08:42:48 -0800 (PST)
Received: from [10.1.199.49] (e123756.cambridge.arm.com [10.1.199.49])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AAFE93F587;
	Wed, 11 Jan 2023 08:42:05 -0800 (PST)
Message-ID: <56b0a56e-b33b-e22e-41b9-01418578ae48@arm.com>
Date: Wed, 11 Jan 2023 16:41:48 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [edk2-devel] [PATCH v4 0/3] ArmPkg,MdeModulePkg: Implement EFI_MP_SERVICES_PROTOCOL for AArch64 and add an MpServicesTest application to exercise it
To: devel@edk2.groups.io, rebecca@quicinc.com,
 Sami Mujawar <sami.mujawar@arm.com>,
 Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Leif Lindholm <quic_llindhol@quicinc.com>,
 Jian J Wang <jian.j.wang@intel.com>, Liming Gao <gaoliming@byosoft.com.cn>,
 Tiger Liu <TigerLiu@zhaoxin.com>
References: <20230104153727.345236-1-rebecca@quicinc.com>
From: "Patrik Berglund" <patrik.berglund@arm.com>
In-Reply-To: <20230104153727.345236-1-rebecca@quicinc.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello Rebecca,

I have tested the v4 set on a single-chip N1SDP.
I had to fix N1SDP for the same reasons as in
https://edk2.groups.io/g/devel/message/93633 and I post that fix to the 
list separately.

I think it works but here is the output:

Shell> MpServicesTest -P
Number of CPUs: 4, Enabled: 4
Processor 0:
	ID: 0000000000000000
	Status: BSP | Enabled | Healthy
	Location: Package 0, Core 0, Thread 0
	Extended Information: Package 0, Module 0, Tile 0, Die 0, Core 0, Thread 0

Processor 1:
	ID: 0000000000000100
	Status: AP | Enabled | Healthy
	Location: Package 1, Core 0, Thread 0
	Extended Information: Package 0, Module 0, Tile 0, Die 1, Core 0, Thread 0

Processor 2:
	ID: 0000000000010000
	Status: AP | Enabled | Healthy
	Location: Package 0, Core 0, Thread 0
	Extended Information: Package 1, Module 0, Tile 0, Die 0, Core 0, Thread 0

Processor 3:
	ID: 0000000000010100
	Status: AP | Enabled | Healthy
	Location: Package 1, Core 0, Thread 0
	Extended Information: Package 1, Module 0, Tile 0, Die 1, Core 0, Thread 0

Shell> MpServicesTest -A
Running with SingleThread FALSE, 0 (infinite) timeout...done.
Hello from CPU 1
Hello from CPU 2
Hello from CPU 3
Shell>


One suggestion on the MpServicesTest utility, maybe check the AP number 
to give a bit friendlier error message if the user pass the BSP?

Regards,
Patrik