[PATCH v1 0/2] ArmPlatformPkg: Fix build warnings

[PATCH v1 0/2] ArmPlatformPkg: Fix build warnings

[Sami Mujawar]

This patch-set has the following updates:
  * PL061: Minor section alignment
    - Minor update to add an empty line before the 'sources' section in an inf file.
  * Fix 'missing header' warnings
    - Updates to inf files to include header files in the 'sources' section.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/700_armplatformpkg_fix_missing_header_warning_v1

Sami Mujawar (2):
  ArmPlatformPkg: PL061: Minor section alignment
  ArmPlatformPkg: Fix 'missing header' warnings

 ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 3 ++-
 ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf                 | 4 +++-
 ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf                   | 3 ++-
 ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf         | 3 ++-
 4 files changed, 9 insertions(+), 4 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH v1 1/2] ArmPlatformPkg: PL061: Minor section alignment

[Sami Mujawar]

Minor update to add an empty line before start of the
sources section.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v1:
      - Added an empty line before the 'sources' section.           [SAMI]

 ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
index 132f09ce2bf64f9110f1fb8c850aebb5cd427076..01cea6c3ab21c7b22df5afebde804e0131fa47f3 100644
--- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
+++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
@@ -1,6 +1,6 @@
 /** @file
 *
-*  Copyright (c) 2011, ARM Limited. All rights reserved.
+*  Copyright (c) 2011 - 2019, ARM Limited. All rights reserved.
 *
 *  SPDX-License-Identifier: BSD-2-Clause-Patent
 *
@@ -14,6 +14,7 @@ [Defines]
   VERSION_STRING                 = 1.0
 
   ENTRY_POINT                    = PL061InstallProtocol
+
 [Sources.common]
   PL061Gpio.c
 
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH v1 2/2] ArmPlatformPkg: Fix 'missing header' warnings

[Sami Mujawar]

The Basetools scripts have been updated to report
warnings if header files are not listed in the
[Sources] section of the inf files.

Update the inf files to include the respective
header files to fix the reported warnings.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v1:
      - Fix missing header warnings                                 [SAMI]

 ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 3 ++-
 ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf                 | 1 +
 ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf                   | 3 ++-
 ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf         | 3 ++-
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
index 2176e5a5789f3728964b7cc286f85fb03ee88cb4..662256d5aebef20d4223ab2b582b27bade4fa76a 100644
--- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
+++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
@@ -2,7 +2,7 @@
 #
 #  Component description file for LcdGraphicsOutputDxe module
 #
-#  Copyright (c) 2011-2012, ARM Ltd. All rights reserved.<BR>
+#  Copyright (c) 2011 - 2019, ARM Ltd. All rights reserved.<BR>
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -18,6 +18,7 @@ [Defines]
 
 [Sources.common]
   LcdGraphicsOutputDxe.c
+  LcdGraphicsOutputDxe.h
   LcdGraphicsOutputBlt.c
 
 [Packages]
diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
index 01cea6c3ab21c7b22df5afebde804e0131fa47f3..cdfaaccbff5195674db93f1bcf24754e25981435 100644
--- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
+++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
@@ -17,6 +17,7 @@ [Defines]
 
 [Sources.common]
   PL061Gpio.c
+  PL061Gpio.h
 
 [Packages]
   MdePkg/MdePkg.dec
diff --git a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
index c70377bc7cfaeac1128aae3754f5c56ac8e1ca5c..864cd5958d6761a6d9d520b701dbe7da62525628 100644
--- a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
+++ b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
@@ -1,7 +1,7 @@
 #/** @file
 #  INF file for the MMC Host Protocol implementation for the ARM PrimeCell PL180.
 #
-#  Copyright (c) 2011, ARM Limited. All rights reserved.
+#  Copyright (c) 2011 - 2019, ARM Limited. All rights reserved.
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -18,6 +18,7 @@ [Defines]
 
 [Sources.common]
   PL180Mci.c
+  PL180Mci.h
 
 [Packages]
   ArmPlatformPkg/ArmPlatformPkg.dec
diff --git a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
index 048f6697e93d702c5ec878ccc827e64e583893ea..f152a59fdcd72921528f1e9993f05df0d39aac89 100644
--- a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
+++ b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
@@ -1,6 +1,6 @@
 /** @file
 *
-*  Copyright (c) 2011-2012, ARM Limited. All rights reserved.
+*  Copyright (c) 2011 - 2019, ARM Limited. All rights reserved.
 *  Copyright (c) 2018, Linaro Limited. All rights reserved.
 *
 *  SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -17,6 +17,7 @@ [Defines]
 
 [Sources.common]
   SP805Watchdog.c
+  SP805Watchdog.h
 
 [Packages]
   ArmPkg/ArmPkg.dec
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [edk2-devel] [PATCH v1 0/2] ArmPlatformPkg: Fix build warnings

[Philippe Mathieu-Daudé]

On 11/21/19 3:32 PM, Sami Mujawar wrote:
> This patch-set has the following updates:
>    * PL061: Minor section alignment
>      - Minor update to add an empty line before the 'sources' section in an inf file.
>    * Fix 'missing header' warnings
>      - Updates to inf files to include header files in the 'sources' section.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/700_armplatformpkg_fix_missing_header_warning_v1
> 
> Sami Mujawar (2):
>    ArmPlatformPkg: PL061: Minor section alignment
>    ArmPlatformPkg: Fix 'missing header' warnings
> 
>   ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 3 ++-
>   ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf                 | 4 +++-
>   ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf                   | 3 ++-
>   ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf         | 3 ++-
>   4 files changed, 9 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>