From: "Benjamin Doron" <benjamin.doron00@gmail.com>
To: Guo Dong <guo.dong@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Add support for logging to CBMEM console
Date: Fri, 27 May 2022 09:33:22 -0700 [thread overview]
Message-ID: <5710.1653669202637627313@groups.io> (raw)
In-Reply-To: <CY5PR11MB6260F05DAAB8FF1C827C734E9ED89@CY5PR11MB6260.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
Hi Guo,
Dumping some of the coreboot table shows that some smaller entries/data (such as build information) are inserted inline while larger entries use the cb_cbmem_ref structure. This may answer why some users of FindCbTag() assign the returned pointer directly to their requested structure, while this library must first dereference the console's address.
For reasons unclear to me, cb_cbmem_ref->size == 0x0010, the size of the cb_cbmem_ref structure. Perhaps the structure of cb_cbmem_ref has been changed in the past and the size field informs coreboot payloads? Either way, it doesn't look like a useful field at the moment.
I will add comments and submit a v3. Is there anything else that needs some comments?
Regards,
Benjamin
[-- Attachment #2: Type: text/html, Size: 783 bytes --]
next prev parent reply other threads:[~2022-05-27 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 18:47 [PATCH v2] UefiPayloadPkg: Add support for logging to CBMEM console Benjamin Doron
2022-05-26 9:16 ` Sean Rhodes
2022-05-26 17:08 ` [edk2-devel] " Benjamin Doron
2022-05-27 5:59 ` Guo Dong
2022-05-27 16:33 ` Benjamin Doron [this message]
2022-05-27 17:08 ` Guo Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5710.1653669202637627313@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox