From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Add support for logging to CBMEM console To: Guo Dong ,devel@edk2.groups.io From: "Benjamin Doron" X-Originating-Location: Richmond Hill, Ontario, CA (24.52.200.135) X-Originating-Platform: Linux Firefox 100 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 27 May 2022 09:33:22 -0700 References: In-Reply-To: Message-ID: <5710.1653669202637627313@groups.io> Content-Type: multipart/alternative; boundary="4CTOBNhmEkLgrukbOqRi" --4CTOBNhmEkLgrukbOqRi Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Guo, Dumping some of the coreboot table shows that some smaller entries/data (su= ch as build information) are inserted inline while larger entries use the c= b_cbmem_ref structure. This may answer why some users of FindCbTag() assign= the returned pointer directly to their requested structure, while this lib= rary must first dereference the console's address. For reasons unclear to me, cb_cbmem_ref->size =3D=3D 0x0010, the size of th= e cb_cbmem_ref structure. Perhaps the structure of cb_cbmem_ref has been ch= anged in the past and the size field informs coreboot payloads? Either way,= it doesn't look like a useful field at the moment. I will add comments and submit a v3. Is there anything else that needs some= comments? Regards, Benjamin --4CTOBNhmEkLgrukbOqRi Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Guo,
Dumping some of the coreboot table shows that some smaller ent= ries/data (such as build information) are inserted inline while larger entr= ies use the cb_cbmem_ref structure. This may answer why some users of FindC= bTag() assign the returned pointer directly to their requested structure, w= hile this library must first dereference the console's address.

= For reasons unclear to me, cb_cbmem_ref->size =3D=3D 0x0010, the size of= the cb_cbmem_ref structure. Perhaps the structure of cb_cbmem_ref has been= changed in the past and the size field informs coreboot payloads? Either w= ay, it doesn't look like a useful field at the moment.

I will ad= d comments and submit a v3. Is there anything else that needs some comments= ?

Regards,
Benjamin --4CTOBNhmEkLgrukbOqRi--