From: "Laszlo Ersek" <lersek@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>, "Dong, Eric" <eric.dong@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Mammedov <imammedo@redhat.com>
Subject: Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection
Date: Thu, 10 Oct 2019 09:38:46 +0200 [thread overview]
Message-ID: <571f8d70-c046-516d-3536-a7d9314fb5ac@redhat.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C31955E@SHSMSX104.ccr.corp.intel.com>
On 10/10/19 04:52, Ni, Ray wrote:
> Laszlo,
> Can you add comments in the code you changed to describe the two different behaviors?
It's described in the DEC file, near the PCD:
+ # nonzero - PcdCpuApInitTimeOutInMicroSeconds is ignored. The initial
+ # AP detection finishes when the detected CPU count (BSP
+ # plus APs) reaches the value of this PCD.<BR>
(1) Do you want me to repeat this explanation in the code as well?
(2) Do you want me to emphasize in the explanation that, if at least one processor fails to check in, the boot is going to block forever, by design?
(3) Emphasize this in the DEC file only, in the code only, or in both?
Thanks
Laszlo
next prev parent reply other threads:[~2019-10-10 7:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 11:27 [PATCH 0/4] UefiCpuPkg, OvmfPkg: separate PCDs for boot CPU count vs. max CPU count Laszlo Ersek
2019-10-08 11:27 ` [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection Laszlo Ersek
2019-10-09 0:57 ` [edk2-devel] " Dong, Eric
2019-10-09 14:55 ` Laszlo Ersek
2019-10-10 2:52 ` Ni, Ray
2019-10-10 7:38 ` Laszlo Ersek [this message]
2019-10-10 7:50 ` Ni, Ray
2019-10-10 8:28 ` Laszlo Ersek
2019-10-08 11:27 ` [PATCH 2/4] OvmfPkg/OvmfXen.dsc: remove PcdCpu* dynamic defaults Laszlo Ersek
2019-10-08 13:11 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-10-08 20:27 ` Laszlo Ersek
2019-10-08 11:27 ` [PATCH 3/4] OvmfPkg/IndustryStandard: define FW_CFG_X86_TOPOLOGY structure type Laszlo Ersek
2019-10-08 11:27 ` [PATCH 4/4] OvmfPkg/PlatformPei: rewrite MaxCpuCountInitialization() for CPU hotplug Laszlo Ersek
2019-10-08 15:06 ` Igor Mammedov
2019-10-08 21:12 ` Laszlo Ersek
2019-10-09 10:23 ` Igor Mammedov
2019-10-09 14:43 ` Laszlo Ersek
2019-10-08 11:35 ` [PATCH 0/4] UefiCpuPkg, OvmfPkg: separate PCDs for boot CPU count vs. max CPU count Ard Biesheuvel
2019-10-08 20:27 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571f8d70-c046-516d-3536-a7d9314fb5ac@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox