From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8339DAC134C for ; Thu, 25 Jan 2024 12:48:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mJUbKvLCUkiixICnkIlmJQNq+rjOHUbMKRdG1S6PeSs=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706186908; v=1; b=lr2k3yoRnq5zxFWAJGKXmdiLeZ67IeyD1yDYiRF2F5FjYbfJBskY2V7tNd8hUdEflpZ6Pyw+ ca0RKr4RWANSa19fbkiXmir7i+cTHk5/6q4eJyrO/hJlkzsqILWU4GJPtg+PUKiRuONqXdfPogu ZTqy9h0xwsOjUfuu2mN2q8e0= X-Received: by 127.0.0.2 with SMTP id TeE4YY7687511xl1MG02pvcI; Thu, 25 Jan 2024 04:48:28 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.16698.1706186907776656630 for ; Thu, 25 Jan 2024 04:48:27 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C9C081FB; Thu, 25 Jan 2024 04:49:11 -0800 (PST) X-Received: from [192.168.1.13] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D43C43F5A1; Thu, 25 Jan 2024 04:48:25 -0800 (PST) Message-ID: <572ffafd-2cea-4d00-be06-eee1bc1ec4e0@arm.com> Date: Thu, 25 Jan 2024 13:48:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v4 2/3] Platform/ARM: Juno: Generate _PSD objects To: Sami Mujawar , "devel@edk2.groups.io" Cc: Leif Lindholm , Ard Biesheuvel , Thomas Abraham , nd References: <20231212093056.1255191-1-Pierre.Gondois@arm.com> <20231212093056.1255191-3-Pierre.Gondois@arm.com> <59D01B4A-A8F3-46E7-9516-6E2E923FE7E0@arm.com> From: "PierreGondois" In-Reply-To: <59D01B4A-A8F3-46E7-9516-6E2E923FE7E0@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: A6WL5qtunrLfpFcSNmHNmOmnx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lr2k3yoR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Sami, On 1/25/24 12:31, Sami Mujawar wrote: > Hi Pierre, >=20 > Thank you for this patch. > I just have a minor suggestion marked inline as [SAMI]. > Otherwise, this patch looks good to me. > With that addressed, > Reviewed-by: Sami Mujawar >=20 > Regards, >=20 > Sami Mujawar >=20 > =EF=BB=BFOn 12/12/2023, 09:31, "Pierre.Gondois@arm.com " > wro= te: >=20 >=20 > From: Pierre Gondois > >=20 >=20 > The SsdtCpuTopologyGenerator can generate _PSD objects. > Add _PSD information and handling to the Configuration Manager > to generate them. >=20 >=20 > Signed-off-by: Pierre Gondois > > --- > .../ConfigurationManager.c | 98 +++++++++++++++++-- > .../ConfigurationManager.h | 24 ++++- > 2 files changed, 113 insertions(+), 9 deletions(-) >=20 >=20 [snip] > @@ -283,6 +300,9 @@ typedef struct PlatformRepositoryInfo { > // Cores Low Power Idle state references (LPI) > CM_ARM_OBJ_REF CoresLpiRef[CORES_LPI_STATE_COUNT]; >=20 >=20 > + // Power domains > [SAMI] The comment could also say that this information is dynamically po= pulated by the configuration manager. I think the _PSD info is statically defined, only the _CPC information is dynamically populated. > + CM_ARM_PSD_INFO PsdInfo[PSD_DOMAIN_COUNT]; > + > /// Juno Board Revision > UINT32 JunoRevision; > } EDKII_PLATFORM_REPOSITORY_INFO; > -- > 2.25.1 >=20 >=20 >=20 >=20 >=20 Regards, Pierre -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114400): https://edk2.groups.io/g/devel/message/114400 Mute This Topic: https://groups.io/mt/103127067/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-