Re: [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

["Zeng, Star" <star.zeng@intel.com>]

On 2019/1/23 20:15, Julien Grall wrote:
> On 23/01/2019 01:41, Zeng, Star wrote:
>> Hi Julien,
> 
> Hi Star,
> 
>> On 2019/1/22 12:30, Zeng, Star wrote:
>>> On 2019/1/22 3:40, Ard Biesheuvel wrote:
>>>> On Mon, 21 Jan 2019 at 14:36, Julien Grall <julien.grall@linaro.org> 
>>>> wrote:
>>>> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
>>>> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
>>>> index a8bb9cf25ebd..adaf6ccb48b0 100644
>>>> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
>>>> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
>>>> @@ -236,14 +236,16 @@ VariableClassAddressChangeEvent (
>>>>   {
>>>>     UINTN          Index;
>>>>
>>>> -  EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->GetBlockSize);
>>>> -  EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->GetPhysicalAddress);
>>>> -  EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->GetAttributes);
>>>> -  EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->SetAttributes);
>>>> -  EfiConvertPointer (0x0, (VOID **) 
>>>> &mVariableModuleGlobal->FvbInstance->Read);
>>>> -  EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->Write);
>>>> -  EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->EraseBlocks);
>>>> -  EfiConvertPointer (0x0, (VOID **) 
>>>> &mVariableModuleGlobal->FvbInstance);
>>>> +  if (mVariableModuleGlobal->FvbInstance != NULL) {
>>>> +    EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->GetBlockSize);
>>>> +    EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->GetPhysicalAddress);
>>>> +    EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->GetAttributes);
>>>> +    EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->SetAttributes);
>>>> +    EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->Read);
>>>> +    EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->Write);
>>>> +    EfiConvertPointer (0x0, (VOID **)
>>>> &mVariableModuleGlobal->FvbInstance->EraseBlocks);
>>>> +    EfiConvertPointer (0x0, (VOID **) 
>>>> &mVariableModuleGlobal->FvbInstance);
>>>> +  }
>>>>     EfiConvertPointer (0x0, (VOID **) 
>>>> &mVariableModuleGlobal->PlatformLangCodes);
>>>>     EfiConvertPointer (0x0, (VOID **) 
>>>> &mVariableModuleGlobal->LangCodes);
>>>>     EfiConvertPointer (0x0, (VOID **) 
>>>> &mVariableModuleGlobal->PlatformLang);
>>>
>>> Thanks Ard. I integrated it into the patch 10 of V4.
>>> Repo: git@github.com:lzeng14/edk2.git
>>> Branch: MergedVariableDriver_EmuNvMode_V4
>>>
>>> Julien, could you help take a try?
>>
>> Sorry for a little push. Are you able to have a quick try? :)
> 
> Sorry for the late, I didn't have time yesterday to test at it.
> 
> I tried the new branch and was able to boot a Linux guest using UEFI.
> 
> Feel free to add my tags to the series:
> 
> Tested-by: Julien Grall <julien.grall@arm.com>
> Acked-by: Julien Grall <julien.grall@arm.com>

It is really very helpful to make the patch higher quality.

> 
> Many thanks to you, Ard and Laszlo for the feedback.

Thanks all of you.

Star

> 
> Best regards,
>