public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>, edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Subject: Re: [Patch v4 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Add logic to support semaphore type.
Date: Fri, 19 Oct 2018 16:01:30 +0200	[thread overview]
Message-ID: <57498881-d4be-9310-2f76-80548b72f4fa@redhat.com> (raw)
In-Reply-To: <20181019020622.6864-5-eric.dong@intel.com>

On 10/19/18 04:06, Eric Dong wrote:
> V4 changes:
> 1. Serial console log for different threads when program register table.
> 2. Check the AcpiCpuData before use it to avoid potential ASSERT.
> 
> V3 changes:
> 1. Use global variable instead of internal function to return string for register type
>    and dependence type.
> 2. Add comments for some complicated logic.
> 
> V1 changes:
> Because this driver needs to set MSRs saved in normal boot phase, sync
> semaphore logic from RegisterCpuFeaturesLib code which used for normal boot phase.
> 
> Detail see below change for RegisterCpuFeaturesLib:
>   UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to support semaphore type.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c          | 413 +++++++++++++++++++----------
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c      |   3 -
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h |   3 +-
>  3 files changed, 276 insertions(+), 143 deletions(-)

Acked-by: Laszlo Ersek <lersek@redhat.com>
Regression-tested-by: Laszlo Ersek <lersek@redhat.com>



  reply	other threads:[~2018-10-19 14:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19  2:06 [Patch v4 0/6] Fix performance issue caused by Set MSR task Eric Dong
2018-10-19  2:06 ` [Patch v4 1/6] UefiCpuPkg/Include/AcpiCpuData.h: Add Semaphore related Information Eric Dong
2018-10-19 13:32   ` Laszlo Ersek
2018-10-19 14:01   ` Laszlo Ersek
2018-10-19  2:06 ` [Patch v4 2/6] UefiCpuPkg/RegisterCpuFeaturesLib.h: Add new dependence types Eric Dong
2018-10-19  2:06 ` [Patch v4 3/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to support semaphore type Eric Dong
2018-10-19  2:06 ` [Patch v4 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: " Eric Dong
2018-10-19 14:01   ` Laszlo Ersek [this message]
2018-10-19  2:06 ` [Patch v4 5/6] UefiCpuPkg/CpuS3DataDxe: Keep old data if value already existed Eric Dong
2018-10-19 14:02   ` Laszlo Ersek
2018-10-19  2:06 ` [Patch v4 6/6] UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info Eric Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57498881-d4be-9310-2f76-80548b72f4fa@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox