From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5E9F72116822C for ; Fri, 19 Oct 2018 07:01:34 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E0103307D913; Fri, 19 Oct 2018 14:01:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-18.rdu2.redhat.com [10.10.121.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 35B2468B3F; Fri, 19 Oct 2018 14:01:31 +0000 (UTC) To: Eric Dong , edk2-devel@lists.01.org Cc: Ruiyu Ni References: <20181019020622.6864-1-eric.dong@intel.com> <20181019020622.6864-5-eric.dong@intel.com> From: Laszlo Ersek Message-ID: <57498881-d4be-9310-2f76-80548b72f4fa@redhat.com> Date: Fri, 19 Oct 2018 16:01:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181019020622.6864-5-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 19 Oct 2018 14:01:33 +0000 (UTC) Subject: Re: [Patch v4 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Add logic to support semaphore type. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2018 14:01:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/19/18 04:06, Eric Dong wrote: > V4 changes: > 1. Serial console log for different threads when program register table. > 2. Check the AcpiCpuData before use it to avoid potential ASSERT. > > V3 changes: > 1. Use global variable instead of internal function to return string for register type > and dependence type. > 2. Add comments for some complicated logic. > > V1 changes: > Because this driver needs to set MSRs saved in normal boot phase, sync > semaphore logic from RegisterCpuFeaturesLib code which used for normal boot phase. > > Detail see below change for RegisterCpuFeaturesLib: > UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to support semaphore type. > > Cc: Ruiyu Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 413 +++++++++++++++++++---------- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 3 - > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 3 +- > 3 files changed, 276 insertions(+), 143 deletions(-) Acked-by: Laszlo Ersek Regression-tested-by: Laszlo Ersek