From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: Star Zeng <star.zeng@intel.com>, edk2-devel@lists.01.org
Subject: Re: [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs
Date: Sat, 3 Mar 2018 15:46:02 +0800 [thread overview]
Message-ID: <5756d2fc-cee6-af10-d127-38a3e8d1b286@Intel.com> (raw)
In-Reply-To: <1520062281-47852-1-git-send-email-star.zeng@intel.com>
On 3/3/2018 3:31 PM, Star Zeng wrote:
> Current BLOCK IO API code is using TPL_CALLBACK,
> but comment is saying TPL_NOTIFY.
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
> index bb292ed3eba8..448bcc2f80ac 100644
> --- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
> +++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
> @@ -60,7 +60,7 @@ UsbMassReset (
> EFI_STATUS Status;
>
> //
> - // Raise TPL to TPL_NOTIFY to serialize all its operations
> + // Raise TPL to TPL_CALLBACK to serialize all its operations
> // to protect shared data structures.
> //
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
> @@ -114,7 +114,7 @@ UsbMassReadBlocks (
> UINTN TotalBlock;
>
> //
> - // Raise TPL to TPL_NOTIFY to serialize all its operations
> + // Raise TPL to TPL_CALLBACK to serialize all its operations
> // to protect shared data structures.
> //
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
> @@ -230,7 +230,7 @@ UsbMassWriteBlocks (
> UINTN TotalBlock;
>
> //
> - // Raise TPL to TPL_NOTIFY to serialize all its operations
> + // Raise TPL to TPL_CALLBACK to serialize all its operations
> // to protect shared data structures.
> //
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
prev parent reply other threads:[~2018-03-03 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 7:31 [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs Star Zeng
2018-03-03 7:46 ` Ni, Ruiyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756d2fc-cee6-af10-d127-38a3e8d1b286@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox