From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 55C752250EDE2 for ; Fri, 2 Mar 2018 23:39:54 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2018 23:46:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,416,1515484800"; d="scan'208";a="24816504" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.44]) ([10.239.9.44]) by fmsmga002.fm.intel.com with ESMTP; 02 Mar 2018 23:46:03 -0800 To: Star Zeng , edk2-devel@lists.01.org References: <1520062281-47852-1-git-send-email-star.zeng@intel.com> From: "Ni, Ruiyu" Message-ID: <5756d2fc-cee6-af10-d127-38a3e8d1b286@Intel.com> Date: Sat, 3 Mar 2018 15:46:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1520062281-47852-1-git-send-email-star.zeng@intel.com> Subject: Re: [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2018 07:39:54 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/3/2018 3:31 PM, Star Zeng wrote: > Current BLOCK IO API code is using TPL_CALLBACK, > but comment is saying TPL_NOTIFY. > > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c > index bb292ed3eba8..448bcc2f80ac 100644 > --- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c > +++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c > @@ -60,7 +60,7 @@ UsbMassReset ( > EFI_STATUS Status; > > // > - // Raise TPL to TPL_NOTIFY to serialize all its operations > + // Raise TPL to TPL_CALLBACK to serialize all its operations > // to protect shared data structures. > // > OldTpl = gBS->RaiseTPL (TPL_CALLBACK); > @@ -114,7 +114,7 @@ UsbMassReadBlocks ( > UINTN TotalBlock; > > // > - // Raise TPL to TPL_NOTIFY to serialize all its operations > + // Raise TPL to TPL_CALLBACK to serialize all its operations > // to protect shared data structures. > // > OldTpl = gBS->RaiseTPL (TPL_CALLBACK); > @@ -230,7 +230,7 @@ UsbMassWriteBlocks ( > UINTN TotalBlock; > > // > - // Raise TPL to TPL_NOTIFY to serialize all its operations > + // Raise TPL to TPL_CALLBACK to serialize all its operations > // to protect shared data structures. > // > OldTpl = gBS->RaiseTPL (TPL_CALLBACK); > Reviewed-by: Ruiyu Ni -- Thanks, Ray