* [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs
@ 2018-03-03 7:31 Star Zeng
2018-03-03 7:46 ` Ni, Ruiyu
0 siblings, 1 reply; 2+ messages in thread
From: Star Zeng @ 2018-03-03 7:31 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Ruiyu Ni
Current BLOCK IO API code is using TPL_CALLBACK,
but comment is saying TPL_NOTIFY.
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
index bb292ed3eba8..448bcc2f80ac 100644
--- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
+++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
@@ -60,7 +60,7 @@ UsbMassReset (
EFI_STATUS Status;
//
- // Raise TPL to TPL_NOTIFY to serialize all its operations
+ // Raise TPL to TPL_CALLBACK to serialize all its operations
// to protect shared data structures.
//
OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
@@ -114,7 +114,7 @@ UsbMassReadBlocks (
UINTN TotalBlock;
//
- // Raise TPL to TPL_NOTIFY to serialize all its operations
+ // Raise TPL to TPL_CALLBACK to serialize all its operations
// to protect shared data structures.
//
OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
@@ -230,7 +230,7 @@ UsbMassWriteBlocks (
UINTN TotalBlock;
//
- // Raise TPL to TPL_NOTIFY to serialize all its operations
+ // Raise TPL to TPL_CALLBACK to serialize all its operations
// to protect shared data structures.
//
OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs
2018-03-03 7:31 [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs Star Zeng
@ 2018-03-03 7:46 ` Ni, Ruiyu
0 siblings, 0 replies; 2+ messages in thread
From: Ni, Ruiyu @ 2018-03-03 7:46 UTC (permalink / raw)
To: Star Zeng, edk2-devel
On 3/3/2018 3:31 PM, Star Zeng wrote:
> Current BLOCK IO API code is using TPL_CALLBACK,
> but comment is saying TPL_NOTIFY.
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
> index bb292ed3eba8..448bcc2f80ac 100644
> --- a/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
> +++ b/MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c
> @@ -60,7 +60,7 @@ UsbMassReset (
> EFI_STATUS Status;
>
> //
> - // Raise TPL to TPL_NOTIFY to serialize all its operations
> + // Raise TPL to TPL_CALLBACK to serialize all its operations
> // to protect shared data structures.
> //
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
> @@ -114,7 +114,7 @@ UsbMassReadBlocks (
> UINTN TotalBlock;
>
> //
> - // Raise TPL to TPL_NOTIFY to serialize all its operations
> + // Raise TPL to TPL_CALLBACK to serialize all its operations
> // to protect shared data structures.
> //
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
> @@ -230,7 +230,7 @@ UsbMassWriteBlocks (
> UINTN TotalBlock;
>
> //
> - // Raise TPL to TPL_NOTIFY to serialize all its operations
> + // Raise TPL to TPL_CALLBACK to serialize all its operations
> // to protect shared data structures.
> //
> OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-03 7:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-03 7:31 [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs Star Zeng
2018-03-03 7:46 ` Ni, Ruiyu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox