Re: [edk2-devel] [RFC PATCH 1/1] BaseTools: drop tautological warning overrides for CLANGDWARF

["Leif Lindholm" <quic_llindhol@quicinc.com>]

Thanks Rebecca, Ard,

I'll fix the typo "progfile" -> "profile" in the commit message and 
merge after stable tag is done unless someone objects beforehand.

As a sidenote, it may be worth looking into this for CLANGPDB as well, 
but I don't have a setup for that.

/
     Leif

On 2023-08-23 18:21, Rebecca Cran wrote:
> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
> 
> On Wed, Aug 23, 2023, at 9:15 AM, Leif Lindholm wrote:
>> The CLANGDWARF progfile sets both -Wno-tautological-compare and
>> -Wno-tautological-constant-out-of-range-compare, but this prevents
>> compile-time detection of certain errors.
>> Drop these flags.
>>
>> Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Bob Feng <bob.c.feng@intel.com>
>> Cc: Yuwei Chen <yuwei.chen@intel.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> ---
>>
>> Does anyone remember why these were added?
>> I'm not running into any issues across armvirtqemu, qemusbsa, ovmfx64,
>> ovmfriscv64.
>>
>> /
>>      Leif
>>
>>   BaseTools/Conf/tools_def.template | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/BaseTools/Conf/tools_def.template
>> b/BaseTools/Conf/tools_def.template
>> index 1bf62362b611..5bd5283655ea 100755
>> --- a/BaseTools/Conf/tools_def.template
>> +++ b/BaseTools/Conf/tools_def.template
>> @@ -1859,7 +1859,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS        =
>> -Wl,--defsym=PECOFF_HEADER_SIZE=0x22
>>   DEFINE CLANGDWARF_IA32_TARGET             = -target i686-pc-linux-gnu
>>   DEFINE CLANGDWARF_X64_TARGET              = -target x86_64-pc-linux-gnu
>>
>> -DEFINE CLANGDWARF_WARNING_OVERRIDES    = -Wno-parentheses-equality
>> -Wno-tautological-compare
>> -Wno-tautological-constant-out-of-range-compare -Wno-empty-body
>> -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option
>> -Wno-unused-but-set-variable -Wno-unused-const-variable
>> -Wno-unaligned-access -Wno-unneeded-internal-declaration
>> +DEFINE CLANGDWARF_WARNING_OVERRIDES    = -Wno-parentheses-equality
>> -Wno-empty-body -Wno-unused-const-variable -Wno-varargs
>> -Wno-unknown-warning-option -Wno-unused-but-set-variable
>> -Wno-unused-const-variable -Wno-unaligned-access
>> -Wno-unneeded-internal-declaration
>>   DEFINE CLANGDWARF_ALL_CC_FLAGS         = DEF(GCC48_ALL_CC_FLAGS)
>> DEF(CLANGDWARF_WARNING_OVERRIDES) -fno-stack-protector -mms-bitfields
>> -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas
>> -Wno-incompatible-library-redeclaration -fno-asynchronous-unwind-tables
>> -mno-sse -mno-mmx -msoft-float -mno-implicit-float
>> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
>> -funsigned-char -fno-ms-extensions -Wno-null-dereference
>>
>>   ###########################
>> -- 
>> 2.39.2
>>
>>
>>
>> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108014): https://edk2.groups.io/g/devel/message/108014
Mute This Topic: https://groups.io/mt/100916818/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-