From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7A06E941AC5 for ; Thu, 24 Aug 2023 16:09:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=t8xJHPE7k69jvMwscc5OXwcegsv1rCzCMEJjBFQnPdc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692893349; v=1; b=vzDBWt4FWocjQggJZszhV1pMr17cyk3ZxmrcLdafBFh62/cmHZpqV9L01QLHpugWwyYl+HDi V6XAH/Uijh0eVHKxlieqTH0f483ynm0ubgYBkodajRJ/PTm9lUd/BA8GoKz6TLUA+Qs9l4XKjzI YfJOg+GVAeBHzhPWvyxEzbhI= X-Received: by 127.0.0.2 with SMTP id PgjqYY7687511xGpDNZ6iJwi; Thu, 24 Aug 2023 09:09:09 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.1217.1692893348316661747 for ; Thu, 24 Aug 2023 09:09:08 -0700 X-Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37OEZPNi002261; Thu, 24 Aug 2023 16:08:59 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3snkumu2te-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Aug 2023 16:08:58 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37OG8viS001608 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Aug 2023 16:08:57 GMT X-Received: from [10.111.132.151] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Thu, 24 Aug 2023 09:08:55 -0700 Message-ID: <575c5366-2bb5-7817-bffc-65efb02b6b38@quicinc.com> Date: Thu, 24 Aug 2023 17:08:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [RFC PATCH 1/1] BaseTools: drop tautological warning overrides for CLANGDWARF To: Rebecca Cran , CC: 'Ajay Iyengar ' , gaoliming , 'Bob Feng' , 'Yuwei Chen' , Ard Biesheuvel References: <20230823151522.168518-1-quic_llindhol@quicinc.com> <819fcd52-ee34-4a86-88d3-d9a2db69651c@app.fastmail.com> From: "Leif Lindholm" In-Reply-To: <819fcd52-ee34-4a86-88d3-d9a2db69651c@app.fastmail.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: PWqc_M8s61pNW6Wl74XFr9qw5L90TG6H X-Proofpoint-ORIG-GUID: PWqc_M8s61pNW6Wl74XFr9qw5L90TG6H Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QXxasz25bcYM7djGW5TGntqnx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vzDBWt4F; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Rebecca, Ard, I'll fix the typo "progfile" -> "profile" in the commit message and=20 merge after stable tag is done unless someone objects beforehand. As a sidenote, it may be worth looking into this for CLANGPDB as well,=20 but I don't have a setup for that. / Leif On 2023-08-23 18:21, Rebecca Cran wrote: > Reviewed-by: Rebecca Cran >=20 > On Wed, Aug 23, 2023, at 9:15 AM, Leif Lindholm wrote: >> The CLANGDWARF progfile sets both -Wno-tautological-compare and >> -Wno-tautological-constant-out-of-range-compare, but this prevents >> compile-time detection of certain errors. >> Drop these flags. >> >> Signed-off-by: Leif Lindholm >> Cc: Rebecca Cran >> Cc: Liming Gao >> Cc: Bob Feng >> Cc: Yuwei Chen >> Cc: Ard Biesheuvel >> --- >> >> Does anyone remember why these were added? >> I'm not running into any issues across armvirtqemu, qemusbsa, ovmfx64, >> ovmfriscv64. >> >> / >> Leif >> >> BaseTools/Conf/tools_def.template | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/BaseTools/Conf/tools_def.template >> b/BaseTools/Conf/tools_def.template >> index 1bf62362b611..5bd5283655ea 100755 >> --- a/BaseTools/Conf/tools_def.template >> +++ b/BaseTools/Conf/tools_def.template >> @@ -1859,7 +1859,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS =3D >> -Wl,--defsym=3DPECOFF_HEADER_SIZE=3D0x22 >> DEFINE CLANGDWARF_IA32_TARGET =3D -target i686-pc-linux-gn= u >> DEFINE CLANGDWARF_X64_TARGET =3D -target x86_64-pc-linux-= gnu >> >> -DEFINE CLANGDWARF_WARNING_OVERRIDES =3D -Wno-parentheses-equality >> -Wno-tautological-compare >> -Wno-tautological-constant-out-of-range-compare -Wno-empty-body >> -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option >> -Wno-unused-but-set-variable -Wno-unused-const-variable >> -Wno-unaligned-access -Wno-unneeded-internal-declaration >> +DEFINE CLANGDWARF_WARNING_OVERRIDES =3D -Wno-parentheses-equality >> -Wno-empty-body -Wno-unused-const-variable -Wno-varargs >> -Wno-unknown-warning-option -Wno-unused-but-set-variable >> -Wno-unused-const-variable -Wno-unaligned-access >> -Wno-unneeded-internal-declaration >> DEFINE CLANGDWARF_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) >> DEF(CLANGDWARF_WARNING_OVERRIDES) -fno-stack-protector -mms-bitfields >> -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas >> -Wno-incompatible-library-redeclaration -fno-asynchronous-unwind-tables >> -mno-sse -mno-mmx -msoft-float -mno-implicit-float >> -ftrap-function=3Dundefined_behavior_has_been_optimized_away_by_clang >> -funsigned-char -fno-ms-extensions -Wno-null-dereference >> >> ########################### >> --=20 >> 2.39.2 >> >> >> >>=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108014): https://edk2.groups.io/g/devel/message/108014 Mute This Topic: https://groups.io/mt/100916818/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-