From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.groups.io with SMTP id smtpd.web11.672.1585243193260202279 for ; Thu, 26 Mar 2020 10:19:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aArtTMCF; spf=pass (domain: redhat.com, ip: 216.205.24.74, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585243192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A00Mkzhxpa09Cug3/EP/vac//6mbcHgTzH/iy5r53Rs=; b=aArtTMCFpcb6tro6TP9YRj3SM8gwjQSQHF0zyBc39zwQtgHn1YSOOkEyG6O5yqHxkkyTVZ C2EiNVax43pFcgCqng0Tpwt5YVwubkH+tD2L2odB6gvftxhB2IocqkLMjkWCamT/Svctpz meZysdEnt5qPPoq+JKdJ1EXoTj7wcAw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271-yO9OF9b6MVSmUEdLz4jfjw-1; Thu, 26 Mar 2020 13:19:50 -0400 X-MC-Unique: yO9OF9b6MVSmUEdLz4jfjw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1F3DDBAA; Thu, 26 Mar 2020 17:19:48 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-128.ams2.redhat.com [10.36.113.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53D1BCDBC1; Thu, 26 Mar 2020 17:19:36 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 11/17] OvmfPkg/PvScsiDxe: Define device interface structures and constants To: devel@edk2.groups.io, liran.alon@oracle.com Cc: nikita.leshchenko@oracle.com, aaron.young@oracle.com, jordan.l.justen@intel.com, ard.biesheuvel@linaro.org References: <20200325161005.16743-1-liran.alon@oracle.com> <20200325161005.16743-12-liran.alon@oracle.com> From: "Laszlo Ersek" Message-ID: <57713bb7-a41a-6135-8247-ea84bdd7d1d9@redhat.com> Date: Thu, 26 Mar 2020 18:19:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200325161005.16743-12-liran.alon@oracle.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/25/20 17:09, Liran Alon wrote: > These definitions will be used by the following commits to complete the > implementation of PVSCSI device driver. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Signed-off-by: Liran Alon > --- > OvmfPkg/Include/IndustryStandard/PvScsi.h | 165 ++++++++++++++++++++++ > 1 file changed, 165 insertions(+) > > diff --git a/OvmfPkg/Include/IndustryStandard/PvScsi.h b/OvmfPkg/Include/IndustryStandard/PvScsi.h > index 004c0af84989..a4d6634f3ba0 100644 > --- a/OvmfPkg/Include/IndustryStandard/PvScsi.h > +++ b/OvmfPkg/Include/IndustryStandard/PvScsi.h > @@ -18,4 +18,169 @@ > #define PCI_VENDOR_ID_VMWARE (0x15ad) > #define PCI_DEVICE_ID_VMWARE_PVSCSI (0x07c0) > > +// > +// CDB (Command Descriptor Block) with size above this constant > +// should be considered out-of-band > +// > +#define PVSCSI_CDB_MAX_SIZE (16) > + > +typedef enum { > + PvScsiRegOffsetCommand = 0x0, > + PvScsiRegOffsetCommandData = 0x4, > + PvScsiRegOffsetCommandStatus = 0x8, > + PvScsiRegOffsetLastSts0 = 0x100, > + PvScsiRegOffsetLastSts1 = 0x104, > + PvScsiRegOffsetLastSts2 = 0x108, > + PvScsiRegOffsetLastSts3 = 0x10c, > + PvScsiRegOffsetIntrStatus = 0x100c, > + PvScsiRegOffsetIntrMask = 0x2010, > + PvScsiRegOffsetKickNonRwIo = 0x3014, > + PvScsiRegOffsetDebug = 0x3018, > + PvScsiRegOffsetKickRwIo = 0x4018, > +} PVSCSI_BAR0_OFFSETS; > + > +// > +// Define Interrupt-Status register flags > +// > +#define PVSCSI_INTR_CMPL_0 BIT0 > +#define PVSCSI_INTR_CMPL_1 BIT1 > +#define PVSCSI_INTR_CMPL_MASK (PVSCSI_INTR_CMPL_0 | PVSCSI_INTR_CMPL_1) > + > +typedef enum { > + PvScsiCmdFirst = 0, > + PvScsiCmdAdapterReset = 1, > + PvScsiCmdIssueScsi = 2, > + PvScsiCmdSetupRings = 3, > + PvScsiCmdResetBus = 4, > + PvScsiCmdResetDevice = 5, > + PvScsiCmdAbortCmd = 6, > + PvScsiCmdConfig = 7, > + PvScsiCmdSetupMsgRing = 8, > + PvScsiCmdDeviceUnplug = 9, > + PvScsiCmdLast = 10 > +} PVSCSI_COMMANDS; > + > +#define PVSCSI_SETUP_RINGS_MAX_NUM_PAGES (32) > + > +#pragma pack (1) > +typedef struct { > + UINT32 ReqRingNumPages; > + UINT32 CmpRingNumPages; > + UINT64 RingsStatePPN; > + UINT64 ReqRingPPNs[PVSCSI_SETUP_RINGS_MAX_NUM_PAGES]; > + UINT64 CmpRingPPNs[PVSCSI_SETUP_RINGS_MAX_NUM_PAGES]; > +} PVSCSI_CMD_DESC_SETUP_RINGS; > +#pragma pack () > + > +#define PVSCSI_MAX_CMD_DATA_WORDS \ > + (sizeof (PVSCSI_CMD_DESC_SETUP_RINGS) / sizeof (UINT32)) > + > +#pragma pack (1) > +typedef struct { > + UINT32 ReqProdIdx; > + UINT32 ReqConsIdx; > + UINT32 ReqNumEntriesLog2; > + > + UINT32 CmpProdIdx; > + UINT32 CmpConsIdx; > + UINT32 CmpNumEntriesLog2; > + > + UINT8 Pad[104]; > + > + UINT32 MsgProdIdx; > + UINT32 MsgConsIdx; > + UINT32 MsgNumEntriesLog2; > +} PVSCSI_RINGS_STATE; > +#pragma pack () > + > +// > +// Define PVSCSI request descriptor tags > +// > +#define PVSCSI_SIMPLE_QUEUE_TAG (0x20) > + > +// > +// Define PVSCSI request descriptor flags > +// > +#define PVSCSI_FLAG_CMD_WITH_SG_LIST BIT0 > +#define PVSCSI_FLAG_CMD_OUT_OF_BAND_CDB BIT1 > +#define PVSCSI_FLAG_CMD_DIR_NONE BIT2 > +#define PVSCSI_FLAG_CMD_DIR_TOHOST BIT3 > +#define PVSCSI_FLAG_CMD_DIR_TODEVICE BIT4 > + > +#pragma pack (1) > +typedef struct { > + UINT64 Context; > + UINT64 DataAddr; > + UINT64 DataLen; > + UINT64 SenseAddr; > + UINT32 SenseLen; > + UINT32 Flags; > + UINT8 Cdb[16]; > + UINT8 CdbLen; > + UINT8 Lun[8]; > + UINT8 Tag; > + UINT8 Bus; > + UINT8 Target; > + UINT8 VcpuHint; > + UINT8 Unused[59]; > +} PVSCSI_RING_REQ_DESC; > +#pragma pack () > + > +// > +// Host adapter status/error codes > +// > +typedef enum { > + PvScsiBtStatSuccess = 0x00, // CCB complete normally with no errors > + PvScsiBtStatLinkedCommandCompleted = 0x0a, > + PvScsiBtStatLinkedCommandCompletedWithFlag = 0x0b, > + PvScsiBtStatDataUnderrun = 0x0c, > + PvScsiBtStatSelTimeout = 0x11, // SCSI selection timeout > + PvScsiBtStatDatarun = 0x12, // Data overrun/underrun > + PvScsiBtStatBusFree = 0x13, // Unexpected bus free > + PvScsiBtStatInvPhase = 0x14, // > + // Invalid bus phase or sequence requested > + // by target > + // > + PvScsiBtStatLunMismatch = 0x17, // > + // Linked CCB has different LUN from first > + // CCB > + // > + PvScsiBtStatSensFailed = 0x1b, // Auto request sense failed > + PvScsiBtStatTagReject = 0x1c, // > + // SCSI II tagged queueing message rejected > + // by target > + // > + PvScsiBtStatBadMsg = 0x1d, // > + // Unsupported message received by the host > + // adapter > + // > + PvScsiBtStatHaHardware = 0x20, // Host adapter hardware failed > + PvScsiBtStatNoResponse = 0x21, // > + // Target did not respond to SCSI ATN sent > + // a SCSI RST > + // > + PvScsiBtStatSentRst = 0x22, // Host adapter asserted a SCSI RST > + PvScsiBtStatRecvRst = 0x23, // Other SCSI devices asserted a SCSI RST > + PvScsiBtStatDisconnect = 0x24, // > + // Target device reconnected improperly > + // (w/o tag) > + // > + PvScsiBtStatBusReset = 0x25, // Host adapter issued BUS device reset > + PvScsiBtStatAbortQueue = 0x26, // Abort queue generated > + PvScsiBtStatHaSoftware = 0x27, // Host adapter software error > + PvScsiBtStatHaTimeout = 0x30, // Host adapter hardware timeout error > + PvScsiBtStatScsiParity = 0x34, // SCSI parity error detected > +} PVSCSI_HOST_BUS_ADAPTER_STATUS; > + > +#pragma pack (1) > +typedef struct { > + UINT64 Context; > + UINT64 DataLen; > + UINT32 SenseLen; > + UINT16 HostStatus; > + UINT16 ScsiStatus; > + UINT32 Pad[2]; > +} PVSCSI_RING_CMP_DESC; > +#pragma pack () > + > #endif // __PVSCSI_H_ > Acked-by: Laszlo Ersek (Not an R-b because I haven't validated the various structures and constants against the device model. But stylistically, this patch can certainly be merged, now.) Thanks, Laszlo