From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=UcXr58Db; spf=pass (domain: gmx.de, ip: 212.227.17.20, mailfrom: xypron.glpk@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by groups.io with SMTP; Thu, 26 Sep 2019 23:00:36 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1569564025; bh=9fQaJAyFej/oG4yZ4aSVJQ62lIFLNzXNzTQC9bKPIYw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=UcXr58DbqDSbC6xvb5tYHY4hS9+fLNmli54aBZqaVhO0K7PzRXdLEW9BExcdF4pC/ 5TXcnNrnLkOgBFykZy6Gc1bRGeH8TdkKKBkTeJgRBn4zCoGIY8qcTeMhe1V8DIqn/i KAbeik/vfjUvQA5IJ/VusjZcCcq6gGorHyyqtlvk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.51] ([88.152.145.122]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MqJqN-1hrqw60yeJ-00nTNF; Fri, 27 Sep 2019 08:00:25 +0200 Subject: Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Add MediaPresentSupported check To: "Liu, XianhuiX" , "devel@edk2.groups.io" Cc: Supreeth Venkatesh , "Jin, Eric" References: <20190924085052.8484-1-xianhuix.liu@intel.com> <1ec6d2d9-561b-c04e-327e-20b82001929f@gmx.de> <15C78CE54FBDEE07.4626@groups.io> From: "Heinrich Schuchardt" Message-ID: <57813c28-f32e-e809-7006-e09d4f988555@gmx.de> Date: Fri, 27 Sep 2019 08:00:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K1:8FIWNfBrqw/MmRIff2+JamS5Y8BhyJC2T/ar+Ym6aj9c2JBQUSW Qk1hC5ufrX96SMscvaZJDhoshgBn72861Sou4umpLtoEArp1EcYqElNji2jjUilb7nevzIH t09rscx3lAiqZWODV0aD0IEjidHygZjeQmumcxZn7BPY7ENMRY5eGa93MXlLbsrFsgUzM6E S0Fx+s7+xy+NvXj9KyzJw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:+bii7Bv3xcA=:sRTLz6sJeHygYwDLIB9dD3 4XbNmBpOAfHQYHZHrdA4o56AY82Nixr3APWFdTxlookDxcelWRbYlcpPlf0J3C63afovCv2jx IJluTwaDcI+jfVit25xA8GrN8fn0mFP6NaGP2nHbF2wWGnToPMvNa4ogPFA56xLf6HZ1RXa1f mYeOSy/JG/qWc69qXAnyP1uTTvRZuNRw1LGOTArScXc74dodKhZlt95ZGrkHHpJKvM3Lt+mM5 bfvT3uHiHfXUBRnJ8Lm+9h24febaqDdUdiGJHL71ccLvfYeMiPW10OFgMx0iadDfz39kZnTQx cA49MiUHhuXqhg0bL8t0LF6QKrRJmQy2WRhxDDeYSsVDWiWEpBWyYZeBREuHAhKVXffCTLMVw zpHC5Lcs6lK6hK5MbBycKsp9clMj24ZiKQu4unYFdcUgFLKgLEDjcZc/zt+2W0oDt6orCnUmM 9kd52lmXDf5nFdTFHu4tVEqXP/MjwJrMawbo85MtjG6vZL/KFymrSISzV4clesR2eRkVJ/cyN N7XFTvrG5RbTz20frxJ5OcF0ziMjxT5MrzgIoWgTBejsUrnjjL2K3r2GJNQsU3IPNBFR7hGAf R41d/oAr4ke2C1Z0vCYLBbzPTLlHL1Lnm1NrXi0+tC56Tr6rqP+3Bz1hkHGXIImXuB4fDaalA +5IZdqI6DSt19ijOfG2fiTgoQagQ+JF61AJOyypyqWEWSpU4z5IN8rUanFTFybAPdB7AUYrnu k1S8ombEfAICqdeHLNTzucc3T7yzcLYkmZ47EBNQT5PvbMqjHag0TVQ/fA9Zkp5dRCgYvKDH0 AyhdsBpJu8auLvYFSCah1Lv/d7qnD+7TK/CojB+oz7Y/o3aMsxYdzCAmrd4x1f8Gp7Rh0+tCM 226WIPFLzxd3ga56uvbkh7/CFAEcCMh9t3mJOOlsh3eC99YULBczBVxhZXO+NkbxHSF7Wi9j5 1c9MhRkmT5oMSnlg0MvZ8vNPRzE2Eve8BgJYDSuMCJgAZ8TGOXuMlS/hdhgSGc5FoyFxSjyMo hO0vFcftlQK0LDwLZACWUZjzymle2Vk+fShoAsYFJzwKNAvL/HVaK4s+EA2wH7Oc8FL3oDOt4 cAV1icP71MLeZJzd26SHBrHfxJyUD5uuqq5x9SGwXsB7o0X1jqLFl/nvZHzKTIqd++QnamJ/W 1h2aRyoqSExPQL9ZRuHnuNrfhNXXaiWKuyPBJNcSTUGR2Z3PxN5PZUYqDzrW/SJSYRBYOgJvg nBRCTqn/AudsvoOaurToqRHqK2Dcb8R9Uiegynfoe70+VLM2O8nulM1fSLYA= Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/27/19 4:01 AM, Liu, XianhuiX wrote: > Hi Heinrich, > Any concern about it? Thanks. Your patch is correct. It is preceded by: SctPrint (L"\nPlease disconnect the machine from the LAN, press any key within 10 seconds\n"); If MediaPresentSupported is false you cannot detect if the user removed the LAN cable or not. Sorry for the noise. Best regards Heinrich > > Best Regards > Xianhui Liu > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> xianhui liu >> Sent: Wednesday, September 25, 2019 10:18 AM >> To: devel@edk2.groups.io; xypron.glpk@gmx.de >> Cc: Supreeth Venkatesh ; Jin, Eric >> >> Subject: Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Add >> MediaPresentSupported check >> >> Please refer to below comments. >> >>> -----Original Message----- >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>> Heinrich Schuchardt >>> Sent: Wednesday, September 25, 2019 3:06 AM >>> To: Liu, XianhuiX ; devel@edk2.groups.io >>> Cc: Supreeth Venkatesh ; Jin, Eric >>> >>> Subject: Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Add >>> MediaPresentSupported check >>> >>> On 9/24/19 10:50 AM, xianhui liu wrote: >>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2061 >>>> check MediaPresent while MediaPresentSupported is TRUE sync change >>>> from EFI to IHV SimpleNetworkBBTestFunction >>> >>> Thanks for addressing this issue. >>> >>>> >>>> Cc: Heinrich Schuchardt >>> >>> %s/Cc:/Reported-by:/ >>> >>>> Cc: Supreeth Venkatesh >>>> Cc: Eric Jin >>>> >>>> Signed-off-by: xianhui liu >>>> --- >>>> .../BlackBoxTest/SimpleNetworkBBTestFunction.c | 64 ++++++++++= +- >> -- >>> -------- >>>> 1 file changed, 33 insertions(+), 31 deletions(-) >>>> >>>> diff --git >>>> a/uefi- >>> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTes >>>> t/SimpleNetworkBBTestFunction.c >>>> b/uefi- >>> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTes >>>> t/SimpleNetworkBBTestFunction.c >>>> index b4c7b5ee..8559e894 100644 >>>> --- >>>> a/uefi- >>> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBoxTes >>>> t/SimpleNetworkBBTestFunction.c >>>> +++ b/uefi- >>> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleNetwork/BlackBo >>>> +++ xTest/SimpleNetworkBBTestFunction.c >>>> @@ -1888,38 +1888,40 @@ BBTestGetStatusFunctionTest ( >>>> Status =3D SnpInterface->GetStatus (SnpInterface, >>>> &InterruptStatus, >>> &TxBuf); >>>> Status1 =3D SnpInterface->GetStatus (SnpInterface, >>>> &InterruptStatus, &TxBuf); >>>> >>>> - if (SnpInterface->Mode->MediaPresent =3D=3D FALSE) { >>>> - if ((Status1 =3D=3D EFI_SUCCESS) && (Status =3D=3D EFI_SUCCESS) = && >>> (InterruptStatus =3D=3D 0)) { >>>> - AssertionType =3D EFI_TEST_ASSERTION_PASSED; >>>> - } else { >>>> - AssertionType =3D EFI_TEST_ASSERTION_FAILED; >>>> - } >>>> - } else { >>>> - if ((Status1 =3D=3D EFI_SUCCESS) && (Status =3D=3D EFI_SUCCESS))= { >>>> - AssertionType =3D EFI_TEST_ASSERTION_PASSED; >>>> - if (InterruptStatus & >>>> - ~( EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT | >>>> - EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT | >>>> - EFI_SIMPLE_NETWORK_COMMAND_INTERRUPT | >>>> - EFI_SIMPLE_NETWORK_SOFTWARE_INTERRUPT)) { >>>> - AssertionType =3D EFI_TEST_ASSERTION_FAILED; >>>> - } >>>> - } else { >>>> - AssertionType =3D EFI_TEST_ASSERTION_FAILED; >>>> - } >>>> + if (SnpInterface->Mode-> MediaPresentSupported =3D=3D TRUE) { >>>> + if (SnpInterface->Mode->MediaPresent =3D=3D FALSE) { >>> >>> >>> If MediaPresentSupported =3D=3D FALSE shouldn't we assume that Media i= s >>> present. >>> >>> So isn't a single 'if' enough: >>> >>> if (SnpInterface->Mode-> MediaPresentSupported =3D=3D TRUE && >>> SnpInterface->Mode->MediaPresent =3D=3D FALSE) { >>> >>> Best regards >>> >>> Heinrich Schuchardt >> >> Hi Heinrich, >> We will skip the checkpoint if MediaPresentSupported =3D=3D FALSE. Than= ks. >> >> Hi Eric, >> Please help correct me if any mistake here. Thanks. >> >> Best Regards >> Xianhui Liu >> >> >>> >>>> + if ((Status1 =3D=3D EFI_SUCCESS) && (Status =3D=3D EFI_SUCCES= S) && >>> (InterruptStatus =3D=3D 0)) { >>>> + AssertionType =3D EFI_TEST_ASSERTION_PASSED; >>>> + } else { >>>> + AssertionType =3D EFI_TEST_ASSERTION_FAILED; >>>> + } >>>> + } else { >>>> + if ((Status1 =3D=3D EFI_SUCCESS) && (Status =3D=3D EFI_SUCCES= S)) { >>>> + AssertionType =3D EFI_TEST_ASSERTION_PASSED; >>>> + if (InterruptStatus & >>>> + ~( EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT | >>>> + EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT | >>>> + EFI_SIMPLE_NETWORK_COMMAND_INTERRUPT | >>>> + EFI_SIMPLE_NETWORK_SOFTWARE_INTERRUPT)) { >>>> + AssertionType =3D EFI_TEST_ASSERTION_FAILED; >>>> + } >>>> + } else { >>>> + AssertionType =3D EFI_TEST_ASSERTION_FAILED; >>>> + } >>>> + } >>>> + StandardLib->RecordAssertion ( >>>> + StandardLib, >>>> + AssertionType, >>>> + gSimpleNetworkBBTestFunctionAssertionGuid022, >>>> + L"EFI_SIMPLE_NETWORK_PROTOCOL.GetStatus - >>>> + Invoke >>> GetStatus() and verify interface correctness within test case", >>>> + L"%a:%d:Status - %r, Status1 - %r, InterruptStat= us - %d", >>>> + __FILE__, >>>> + (UINTN)__LINE__, >>>> + Status, >>>> + Status1, >>>> + InterruptStatus >>>> + ); >>>> } >>>> - StandardLib->RecordAssertion ( >>>> - StandardLib, >>>> - AssertionType, >>>> - gSimpleNetworkBBTestFunctionAssertionGuid022, >>>> - L"EFI_SIMPLE_NETWORK_PROTOCOL.GetStatus - Invoke >>> GetStatus() and verify interface correctness within test case", >>>> - L"%a:%d:Status - %r, Status1 - %r, InterruptStatus = - %d", >>>> - __FILE__, >>>> - (UINTN)__LINE__, >>>> - Status, >>>> - Status1, >>>> - InterruptStatus >>>> - ); >>>> >>>> // >>>> // Restore SNP State >>>> >>> >>> >>> >> >> >>=20 >